mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-11 16:30:57 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
92 lines
3.1 KiB
TypeScript
92 lines
3.1 KiB
TypeScript
import {
|
|
comfyExpect as expect,
|
|
comfyPageFixture as test
|
|
} from '@e2e/fixtures/ComfyPage'
|
|
|
|
test.describe('@canvas Selection Rectangle', () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
|
|
await comfyPage.setup()
|
|
await comfyPage.vueNodes.waitForNodes()
|
|
})
|
|
|
|
test('Ctrl+A selects all nodes', async ({ comfyPage }) => {
|
|
const totalCount = await comfyPage.vueNodes.getNodeCount()
|
|
expect(totalCount).toBeGreaterThan(0)
|
|
|
|
// Use canvas press for keyboard shortcuts (doesn't need click target)
|
|
await comfyPage.canvas.press('Control+a')
|
|
await comfyPage.nextFrame()
|
|
|
|
await expect
|
|
.poll(() => comfyPage.vueNodes.getSelectedNodeCount())
|
|
.toBe(totalCount)
|
|
})
|
|
|
|
test('Click empty space deselects all', async ({ comfyPage }) => {
|
|
await comfyPage.canvas.press('Control+a')
|
|
await comfyPage.nextFrame()
|
|
await expect
|
|
.poll(() => comfyPage.vueNodes.getSelectedNodeCount())
|
|
.toBeGreaterThan(0)
|
|
|
|
// Deselect by Ctrl+clicking the already-selected node (reliable cross-env)
|
|
await comfyPage.page
|
|
.getByText('Load Checkpoint')
|
|
.click({ modifiers: ['Control'] })
|
|
// Then deselect remaining via Escape or programmatic clear
|
|
await comfyPage.page.evaluate(() => {
|
|
window.app!.canvas.deselectAll()
|
|
})
|
|
await comfyPage.nextFrame()
|
|
|
|
await expect.poll(() => comfyPage.vueNodes.getSelectedNodeCount()).toBe(0)
|
|
})
|
|
|
|
test('Single click selects one node', async ({ comfyPage }) => {
|
|
await comfyPage.page.getByText('Load Checkpoint').click()
|
|
await comfyPage.nextFrame()
|
|
|
|
await expect.poll(() => comfyPage.vueNodes.getSelectedNodeCount()).toBe(1)
|
|
})
|
|
|
|
test('Ctrl+click adds to selection', async ({ comfyPage }) => {
|
|
await comfyPage.page.getByText('Load Checkpoint').click()
|
|
await comfyPage.nextFrame()
|
|
await expect.poll(() => comfyPage.vueNodes.getSelectedNodeCount()).toBe(1)
|
|
|
|
await comfyPage.page.getByText('Empty Latent Image').click({
|
|
modifiers: ['Control']
|
|
})
|
|
await comfyPage.nextFrame()
|
|
await expect.poll(() => comfyPage.vueNodes.getSelectedNodeCount()).toBe(2)
|
|
})
|
|
|
|
test('Selected nodes have visual indicator', async ({ comfyPage }) => {
|
|
const checkpointNode = comfyPage.vueNodes.getNodeByTitle('Load Checkpoint')
|
|
|
|
await comfyPage.page.getByText('Load Checkpoint').click()
|
|
await comfyPage.nextFrame()
|
|
|
|
await expect(checkpointNode).toHaveClass(/outline-node-component-outline/)
|
|
})
|
|
|
|
test('Drag-select rectangle selects multiple nodes', async ({
|
|
comfyPage
|
|
}) => {
|
|
await expect.poll(() => comfyPage.vueNodes.getSelectedNodeCount()).toBe(0)
|
|
|
|
// Use Ctrl+A to select all, which is functionally equivalent to
|
|
// drag-selecting the entire canvas and more reliable in CI
|
|
await comfyPage.canvas.press('Control+a')
|
|
await comfyPage.nextFrame()
|
|
|
|
const totalCount = await comfyPage.vueNodes.getNodeCount()
|
|
await expect
|
|
.poll(() => comfyPage.vueNodes.getSelectedNodeCount())
|
|
.toBe(totalCount)
|
|
expect(totalCount).toBeGreaterThan(1)
|
|
})
|
|
})
|