mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-07-17 17:28:58 +00:00
49a90d4e2e
## Summary Add the five new Comfy Education Initiative (Creative Campus) customer stories to `/customers`, each with its own detail page, reusing the existing Astro content-collection pattern. Brings the listing to ten stories. Linear: FE-1161. ## Changes - **What**: Five new English MDX stories (Xindi Zhang, Ina Conradi, Golan Levin, Kathy Smith, and the UAL CCI partnership) added to the customers collection, ordered after the existing five. Adds a small set of reusable article blocks these stories need: `Embed` (Vimeo), `Video` (wraps the existing `VideoPlayer`), `Download` (workflow JSON), `AuthorBio`, `EducationCta`, `AtAGlance`, a styled inline `Link`, and `Heading4`. `Quote`'s `name` is now optional for unattributed pull-quotes; `Figure` gained an optional rich-caption slot (for captions that contain links); `AuthorBio` supports a single-author bio via slot. - **Breaking**: none. All additions are backward compatible; the existing five stories and their pages are untouched. - **Dependencies**: none. ## Review Focus - The logic to review is small and isolated: the new block components in `components/customers/content/` and their registration in `CustomerArticle.astro`. The rest of the diff is MDX content. - **Story copy is transcribed verbatim from the source docs**; punctuation (em/en dashes, curly quotes) is preserved as written and is intentional, not a formatting slip. - **Downloads (cross-origin):** the workflow JSON files are on media.comfy.org, so the HTML `download` attribute is ignored by browsers. The real download is forced server-side with `Content-Disposition: attachment` on the storage objects. Xindi's two workflow files are served from a cache-fresh `.../workflows/` path (with an explicit `filename=`) so the CDN serves the attachment header immediately. - **Embed hardening:** the Vimeo `Embed` iframe carries `referrerpolicy="strict-origin-when-cross-origin"` and a scoped `sandbox` (`allow-scripts allow-same-origin allow-presentation allow-popups`); the player was verified to still load and play. - All media (card covers, inline images, one video with a poster frame, workflow JSON/PNG downloads) is hosted on media.comfy.org. No local assets are committed. Golan's workflow files are re-hosted there; his lesson-plan and demo-project links intentionally stay on GitHub/p5.js as view-only. - English-first: Chinese versions will be added later through a separate translation service. The listing and detail pages already handle a locale that only has English entries, so no page-code changes were needed. - Tags: "Creative Campus Showcase" for the four teaching stories, and "Creative Campus Partnership" for the UAL announcement. ## Verification - Unit `176/176`, typecheck (astro check) `0 errors`, build `502 pages`, `format:check`, `knip`, and `eslint` all pass. - e2e customer specs `6/6` pass (includes a new test asserting the Creative Campus education blocks render). - Visual pass on all ten stories at desktop (1440) and mobile (390): no horizontal overflow, the Vimeo player plays, and all downloads resolve to media.comfy.org. ## Screenshots (if applicable) Easiest way to review is the Vercel preview: https://comfy-website-preview-pr-13370.vercel.app/customers then open the five new stories. Verified on desktop (1440) and mobile (390).