## Summary Redesign missing-model detection for ADR 0009 promoted subgraph widgets so candidates are created from the widget value the user can actually edit, while still using the concrete interior widget as the schema/options source. ## Why This PR Exists This PR comes from the follow-up missing-model detection work for the ADR 0009 / 1.46 subgraph widget changes introduced by [#12197](https://github.com/Comfy-Org/ComfyUI_frontend/pull/12197). [#12197](https://github.com/Comfy-Org/ComfyUI_frontend/pull/12197) intentionally changed promoted subgraph widgets to be represented through subgraph input links. After that change, the promoted widget on the host `SubgraphNode` is the editable value owner, and linked interior widgets are no longer guaranteed to mirror that value. The old missing-model contract still treated the concrete interior node widget as the effective source of truth in subgraph cases: - recursive scans entered the subgraph and scanned the interior widget value; - candidates were keyed by the interior node/widget identity; - the parent subgraph host mostly received propagated highlight/navigation behavior; - subgraph container widgets were not treated as first-class candidate sources. That contract breaks after ADR 0009. A user can resolve a missing model by changing the promoted host widget to an installed model, while the linked interior widget can still hold the old stale value. If detection keeps scanning the linked interior value, entering the subgraph or reloading the workflow can re-create a false missing-model error that no longer corresponds to the value the user can edit. ADR 0009 also means the same subgraph definition can be reused by multiple `SubgraphNode` hosts. Once missing-model detection moves from the interior definition widget to the promoted host widget, the selected value is no longer a property of the shared definition alone. It is a property of a specific host instance. That makes the old interior-node identity insufficient for mode changes, removal handling, and re-scan behavior: a single interior leaf definition can be reachable through multiple host execution paths, and only the affected host path should add, remove, or restore a candidate. This PR also builds on [#12990](https://github.com/Comfy-Org/ComfyUI_frontend/pull/12990), which narrowed workflow-level `models[]` and embedded model data to metadata enrichment only. Together, the intended boundary is: - live widgets create missing-model candidates; - workflow/root-level `models[]` and node metadata only enrich candidates that already came from a live widget; - promoted widget values are read from the editable host widget, not inferred from stale interior `widgets_values`. ## Changes - **What**: - Introduces promoted-widget scan targets that split: - host promoted widget value and candidate identity; - concrete leaf widget/node definition data. - Scans the outermost unlinked promoted widget on a `SubgraphNode` host as the selected value owner. - Skips linked interior widgets as candidate sources, preventing stale linked widget values from producing duplicate or false missing-model candidates. - Resolves the concrete leaf widget for combo options, asset-widget support, node type, directory lookup, and embedded metadata enrichment. - Keys promoted missing-model candidates by the host execution id and host promoted widget name. - Adds `sourceExecutionId` to promoted candidates so liveness still follows the concrete source execution path, including nested inactive subgraph containers. - Uses source-scope activity for pipeline filtering and async verification, while keeping highlight/store/clearing identity host-keyed. - Removes host-keyed promoted candidates when their source execution scope is removed or bypassed. - Re-scans ancestor subgraph hosts when an interior source path is un-bypassed, so host-keyed promoted errors can reappear correctly. - Handles shared subgraph definitions by deriving promoted source paths from the concrete host instance path, rather than treating the shared definition node id as globally unique. - Shares promoted source resolution between Vue node processing and the right-side panel to avoid drift. - Aligns missing-model clearing across Vue node widgets, legacy canvas widgets, and right-side panel Parameters/Nodes section widgets. - Adds unit coverage for scan identity, source-scope liveness, dynamic mode changes, source-scope removal, shared-definition host isolation, and right-side panel clearing. - Adds nested promoted-widget E2E coverage for OSS and Cloud flows across Vue, Parameters tab, and legacy widget surfaces. - **Breaking**: None expected. - **Dependencies**: None. ## New Detection Contract A missing-model candidate is created from an unlinked final editable value owner. That value owner can be: - a normal node model widget; or - the outermost promoted model widget displayed on a `SubgraphNode` host. For promoted widgets: - the host promoted widget supplies the selected value; - the host execution id and host widget name are the candidate identity; - the concrete leaf widget supplies definition data such as combo options and asset-browser support; - the concrete source execution path is retained as `sourceExecutionId` for liveness only; - linked interior widgets are skipped as candidate sources because their values are not authoritative when driven by a promoted input. For a nested chain: `Outer promoted widget A -> inner promoted widget B -> concrete widget C` only `A` creates the candidate. `B` and `C` are linked along the promoted-input path and are skipped as selected-value sources, while `C` still provides the concrete widget definition used to evaluate `A`. ## Shared Definition And Source-Scope Liveness ADR 0009 promoted widgets make subgraphs behave more like reusable definitions with host-owned inputs. Two host `SubgraphNode`s can point at the same interior subgraph definition while carrying different promoted widget values. In that shape, the missing-model candidate must be keyed to the editable host surface, but the activity check cannot use the host id alone. For example, if two outer hosts share the same nested subgraph definition, one host can select a valid model while the other still selects a missing model. The result should be one missing-model reference, not a single definition-level error and not two errors after one host is fixed. Likewise, bypassing or un-bypassing an interior nested container should affect only the host execution paths that actually pass through that container. This PR therefore separates two concepts: - **candidate identity**: host execution id + host promoted widget name, used for storage, highlight, navigation, and clearing; - **candidate liveness**: concrete source execution path, used for scan-time activity checks, pipeline filtering, async verification, source-scope removal, and re-exposure after mode changes. That separation is the reason this PR updates more than the scan itself. Moving the detection target to the subgraph host also requires the mode-change and removal paths to understand that a host-keyed candidate can be invalidated by a descendant source path, and can need to be restored by re-scanning an ancestor host when an interior source path becomes active again. ## Review Focus Please review the identity split carefully: - candidate/store/highlight/clearing identity should remain host-keyed for promoted widgets; - liveness should use `sourceExecutionId` when present, falling back to `nodeId` for normal candidates; - scan-time activity checks should account for the source node itself and all ancestor subgraph containers; - source-scope removal should remove host-keyed candidates whose concrete source path was removed or bypassed; - un-bypassing an interior source path should re-scan affected ancestor subgraph hosts so host-keyed candidates can reappear; - shared subgraph definitions should not merge errors across different host instances; - linked interior widgets should not produce their own missing-model candidates; - asset-browser eligibility should be resolved from the concrete leaf node type and widget name, not the synthetic subgraph host type; - right-side panel edits should clear host missing-model errors and source validation errors consistently. The E2E matrix intentionally keeps nested promoted workflows only. Nested promoted widgets cover the same editable host path as single promoted widgets while also exercising the `A -> B -> C` chain that can break source-scope liveness and re-scan behavior. The nested fixture also includes multiple host instances that share the same subgraph definition, so it verifies that fixing one host does not accidentally clear or suppress another host's missing-model candidate. Direct/single promoted behavior is still covered at the unit level. ## Non-Goals - This PR does not reintroduce workflow-level `models[]` candidate creation. - This PR does not infer selected model values from `widgets_values`. - This PR does not synchronize linked interior widget values back from promoted host widgets. - This PR does not redesign missing-media scanning; missing media still skips subgraph containers and remains keyed by concrete interior paths. The shared async post-verification active-scope filter is intentionally stricter, so a pending missing-media candidate is no longer surfaced if its own node is bypassed or removed while verification is in flight. ## Validation - `pnpm exec vitest run src/components/rightSidePanel/parameters/SectionWidgets.test.ts src/platform/missingModel/missingModelScan.test.ts src/composables/graph/useErrorClearingHooks.test.ts src/platform/missingModel/missingModelPipeline.test.ts src/platform/missingModel/missingModelStore.test.ts src/utils/graphTraversalUtil.test.ts src/composables/graph/useGraphNodeManager.test.ts src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts --reporter=dot` - 8 files passed, 294 tests passed. - `pnpm exec vitest run src/platform/missingModel/missingModelScan.test.ts src/core/graph/subgraph/resolveConcretePromotedWidget.test.ts src/components/rightSidePanel/parameters/SectionWidgets.test.ts` - 3 files passed, 71 tests passed. - `pnpm typecheck` - `pnpm typecheck:browser` - `pnpm format:check` - targeted ESLint for changed production/unit/E2E files - `git diff --check` - `pnpm build` - `pnpm build:cloud` - OSS affected E2E on the 8188 build: - `PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_TEST_URL=http://localhost:8188 pnpm exec playwright test browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts --project=chromium --grep "Changing an OSS .*promoted|Refreshing a resolved promoted|Reloading a resolved nested"` - 5 passed. - Cloud affected E2E on the 8188 cloud build: - `PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_TEST_URL=http://localhost:8188 pnpm exec playwright test browser_tests/tests/propertiesPanel/errorsTabCloudMissingModels.spec.ts --project=cloud --grep "Changing a Cloud .*promoted"` - 2 passed; the Cloud legacy promoted asset-modal case still fails until [#13075](https://github.com/Comfy-Org/ComfyUI_frontend/pull/13075) is merged. - Full OSS `errorsTabModeAware.spec.ts` on the 8188 build: - 23 passed; 3 existing paste/clipboard cases failed before the promoted subgraph section with node count remaining at 1 after `clipboard.paste()`. - Commit hooks ran `oxfmt`, `oxlint`, `eslint`, `pnpm typecheck`, and browser typecheck where applicable. - Pre-push hook ran `pnpm knip --cache`. ## Screenshots Before https://github.com/user-attachments/assets/6380c1da-1d92-4b70-888e-3ade572c4b5b After https://github.com/user-attachments/assets/4cfc24d6-3dc3-4e36-9b31-72fea6b3d9d5
Playwright Testing for ComfyUI_frontend
This document outlines the setup, usage, and common patterns for Playwright browser tests in the ComfyUI_frontend project.
Prerequisites
CRITICAL: Start ComfyUI backend with --multi-user flag:
python main.py --multi-user
Without this flag, parallel tests will conflict and fail randomly.
Setup
ComfyUI devtools
ComfyUI_devtools is included in this repository under tools/devtools/. During CI/CD, these files are automatically copied to the custom_nodes directory.
ComfyUI_devtools adds additional API endpoints and nodes to ComfyUI for browser testing.
For local development, copy the devtools files to your ComfyUI installation:
cp -r tools/devtools/* /path/to/your/ComfyUI/custom_nodes/ComfyUI_devtools/
Node.js & Playwright Prerequisites
Ensure you have the Node.js version specified in .nvmrc installed.
Then, set up the Chromium test driver:
pnpm exec playwright install chromium --with-deps
Environment Configuration
Create .env from the template:
cp .env_example .env
Key settings for debugging:
# Remove Vue dev overlay that blocks UI elements
DISABLE_VUE_PLUGINS=true
# Test against dev server (recommended) or backend directly
PLAYWRIGHT_TEST_URL=http://localhost:5173 # Dev server
# PLAYWRIGHT_TEST_URL=http://localhost:8188 # Direct backend
PLAYWRIGHT_SETUP_API_URL=http://localhost:8188 # Setup/auth API when using the dev server URL above
# Path to ComfyUI for backing up user data/settings before tests
TEST_COMFYUI_DIR=/path/to/your/ComfyUI
Common Setup Issues
Release API Mocking
By default, all tests mock the release API (api.comfy.org/releases) to prevent release notification popups from interfering with test execution. This is necessary because the release notifications can appear over UI elements and block test interactions.
To test with real release data, you can disable mocking:
await comfyPage.setup({ mockReleases: false })
For tests that specifically need to test release functionality, see the example in tests/releaseNotifications.spec.ts.
Running Tests
Always use UI mode for development:
pnpm test:browser:local --ui
UI mode features:
- Locator picker: Click the target icon, then click any element to get the exact locator code to use in your test. The code appears in the Locator tab.
- Step debugging: Step through your test line-by-line by clicking Source tab
- Time travel: In the Actions tab/panel, click any step to see the browser state at that moment
- Console/Network Tabs: View logs and API calls at each step
- Attachments Tab: View all snapshots with expected and actual images
For CI or headless testing:
pnpm test:browser:local # Run all tests
pnpm test:browser:local widget.spec.ts # Run specific test file
Slowing the browser down for debugging
When running with --headed (or --ui), set SLOW_MO to a millisecond delay
to slow every Playwright action down so you can watch what is happening. The
delay only applies when PLAYWRIGHT_LOCAL is set (the default for the
pnpm test:browser:local script).
SLOW_MO=250 pnpm test:browser:local --headed widget.spec.ts
Test Structure
Browser tests in this project follow a specific organization pattern:
-
Fixtures: Located in
fixtures/- These provide test setup and utilitiesComfyPage.ts- The main fixture for interacting with ComfyUIComfyMouse.ts- Utility for mouse interactions with the canvas- Components fixtures in
fixtures/components/- Page object models for UI components
-
Tests: Located in
tests/- The actual test specifications- Organized by functionality (e.g.,
widget.spec.ts,interaction.spec.ts) - Snapshot directories (e.g.,
widget.spec.ts-snapshots/) contain reference screenshots
- Organized by functionality (e.g.,
-
Utilities: Located in
utils/- Common utility functionslitegraphUtils.ts- Utilities for working with LiteGraph nodes
Writing Effective Tests
When writing new tests, follow these patterns:
Test Structure
// Import the test fixture
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
test.describe('Feature Name', () => {
// Set up test environment if needed
test.beforeEach(async ({ comfyPage }) => {
// Common setup
})
test('should do something specific', async ({ comfyPage }) => {
// Test implementation
})
})
Leverage Existing Fixtures and Helpers
Always check for existing helpers and fixtures before implementing new ones:
- ComfyPage: Main fixture with methods for canvas interaction and node management
- ComfyMouse: Helper for precise mouse operations on the canvas
- Component Fixtures: Check
browser_tests/fixtures/components/for UI component page objects (e.g.Actionbar.ts,Templates.ts,ContextMenu.ts) - Helper Classes: Check
browser_tests/fixtures/helpers/for domain-specific helper classes wired into ComfyPage (e.g.CanvasHelper.ts,WorkflowHelper.ts) - Utility Functions: Check
browser_tests/fixtures/utils/for standalone utilities (e.g.fitToView.ts,clipboardSpy.ts,builderTestUtils.ts)
Most common testing needs are already addressed by these helpers, which will make your tests more consistent and reliable.
Import Conventions
- Prefer
@e2e/*for imports withinbrowser_tests/ - Continue using
@/*for imports fromsrc/ - Avoid introducing new deep relative imports within
browser_tests/when the alias is available
Key Testing Patterns
-
Focus elements explicitly: Canvas-based elements often need explicit focus before interaction:
// Click the canvas first to focus it before pressing keys await comfyPage.canvas.click() await comfyPage.page.keyboard.press('a') -
Mark canvas as dirty if needed: Some interactions need explicit canvas updates:
// After programmatically changing node state, mark canvas dirty await comfyPage.page.evaluate(() => { window['app'].graph.setDirtyCanvas(true, true) }) -
Use node references over coordinates: Node references from
fixtures/utils/litegraphUtils.tsprovide stable ways to interact with nodes:// Prefer this: const node = await comfyPage.getNodeRefsByType('LoadImage')[0] await node.click('title') // Over this: await comfyPage.canvas.click({ position: { x: 100, y: 100 } }) -
Wait for canvas to render after UI interactions:
await comfyPage.nextFrame() -
Clean up persistent server state: While most state is reset between tests, anything stored on the server persists:
// Reset settings that affect other tests (these are stored on server) await comfyPage.setSetting('Comfy.ColorPalette', 'dark') await comfyPage.setSetting('Comfy.NodeBadge.NodeIdBadgeMode', 'None') // Clean up uploaded files if needed comfyPage.deleteFileAfterTest({ filename: 'image.png' }) -
Prefer functional assertions over screenshots: Use screenshots only when visual verification is necessary:
// Prefer this: await expect.poll(() => node.isPinned()).toBe(true) await expect.poll(() => node.getProperty('title')).toBe('Expected Title') // Over this - only use when needed: await expect(comfyPage.canvas).toHaveScreenshot('state.png') -
Use minimal test workflows: When creating test workflows, keep them as minimal as possible:
// Include only the components needed for the test await comfyPage.loadWorkflow('single_ksampler') -
Debug helpers for visual debugging (remove before committing):
ComfyPage includes temporary debug methods for troubleshooting:
test('debug failing interaction', async ({ comfyPage }, testInfo) => { // Add visual markers to see click positions await comfyPage.debugAddMarker({ x: 100, y: 200 }) // Attach screenshot with markers to test report await comfyPage.debugAttachScreenshot(testInfo, 'node-positions', { element: 'canvas', markers: [{ position: { x: 100, y: 200 } }] }) // Show canvas overlay for easier debugging await comfyPage.debugShowCanvasOverlay() // Remember to remove debug code before committing! })Available debug methods:
debugAddMarker(position)- Red circle at positiondebugAttachScreenshot(testInfo, name)- Attach to test reportdebugShowCanvasOverlay()- Show canvas as overlaydebugGetCanvasDataURL()- Get canvas as base64
Common Patterns and Utilities
Page Object Pattern
Tests use the Page Object pattern to create abstractions over the UI:
// Using the ComfyPage fixture
test('Can toggle boolean widget', async ({ comfyPage }) => {
await comfyPage.loadWorkflow('widgets/boolean_widget')
const node = (await comfyPage.getFirstNodeRef())!
const widget = await node.getWidget(0)
await widget.click()
})
Node References
The NodeReference class provides helpers for interacting with LiteGraph nodes:
// Getting node by type and interacting with it
const nodes = await comfyPage.getNodeRefsByType('LoadImage')
const loadImageNode = nodes[0]
const widget = await loadImageNode.getWidget(0)
await widget.click()
Visual Regression Testing
Tests use screenshot comparisons to verify UI state:
// Take a screenshot and compare to reference
await expect(comfyPage.canvas).toHaveScreenshot('boolean_widget_toggled.png')
Waiting for Animations
Always call nextFrame() after actions that trigger animations:
await comfyPage.canvas.click({ position: { x: 100, y: 100 } })
await comfyPage.nextFrame() // Wait for canvas to redraw
Mouse Interactions
Canvas operations use special helpers to ensure proper timing:
// Using ComfyMouse for drag and drop
await comfyMouse.dragAndDrop(
{ x: 100, y: 100 }, // From
{ x: 200, y: 200 } // To
)
// Standard ComfyPage helpers
await comfyPage.drag({ x: 100, y: 100 }, { x: 200, y: 200 })
await comfyPage.pan({ x: 200, y: 200 })
await comfyPage.zoom(-100) // Zoom in
Workflow Management
Tests use workflows stored in assets/ for consistent starting points:
// Load a test workflow
await comfyPage.loadWorkflow('single_ksampler')
// Wait for workflow to load and stabilize
await comfyPage.nextFrame()
Custom Assertions
The project includes custom Playwright assertions through comfyExpect:
// Check if a node is in a specific state
await expect(node).toBePinned()
await expect(node).toBeBypassed()
await expect(node).toBeCollapsed()
Troubleshooting Common Issues
Flaky Tests
- Timing Issues: Always wait for animations to complete with
nextFrame() - Coordinate Sensitivity: Canvas coordinates are viewport-relative; use node references when possible
- Test Isolation: Tests run in parallel; avoid dependencies between tests
- Screenshots vary: Ensure your OS and browser match the reference environment (Linux)
- Async / await: Race conditions are a very common cause of test flakiness
Screenshot Testing
Due to variations in system font rendering, screenshot expectations are platform-specific. Please note:
- Do not commit local screenshot expectations to the repository
- We maintain Linux screenshot expectations as our GitHub Action runner operates in a Linux environment
- While developing, you can generate local screenshots for your tests, but these will differ from CI-generated ones
Working with Screenshots Locally
Option 1 - Skip screenshot tests (add to playwright.config.ts):
export default defineConfig({
grep: process.env.CI ? undefined : /^(?!.*screenshot).*$/
})
Option 2 - Generate local baselines for comparison:
pnpm test:browser:local --update-snapshots
Creating New Screenshot Baselines
For PRs from Comfy-Org/ComfyUI_frontend branches:
- Write test with
toHaveScreenshot('filename.png') - Create PR and add
New Browser Test Expectationlabel - CI will generate and commit the Linux baseline screenshots
Note: Fork PRs cannot auto-commit screenshots. A maintainer will need to commit the screenshots manually for you (don't worry, they'll do it).
Viewing Test Reports
Automated Test Deployment
The project automatically deploys Playwright test reports to Cloudflare Pages for every PR and push to main branches.
Accessing Test Reports
- From PR comments: Click the "View Report" links for each browser
- Direct URLs: Reports are available at
https://[branch].comfyui-playwright-[browser].pages.dev(branch-specific deployments) - From GitHub Actions: Download artifacts from failed runs
How It Works
-
Test execution: All browser tests run in parallel across multiple browsers
-
Report generation: HTML reports are generated for each browser configuration
-
Cloudflare deployment: Each browser's report deploys to its own Cloudflare Pages project with branch isolation:
comfyui-playwright-chromium(with branch-specific URLs)comfyui-playwright-mobile-chrome(with branch-specific URLs)comfyui-playwright-chromium-2x(2x scale, with branch-specific URLs)comfyui-playwright-chromium-0-5x(0.5x scale, with branch-specific URLs)
-
PR comments: GitHub automatically updates PR comments with:
- ✅/❌ Test status for each browser
- Direct links to interactive test reports
- Real-time progress updates as tests complete
Resources
- Playwright UI Mode - Interactive test debugging
- Playwright Debugging Guide
- act - Run GitHub Actions locally for CI debugging