mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-01-31 13:29:55 +00:00
82bacb82a7
## Summary
Adds structured test tags to all 54 Playwright test files to enable
flexible test filtering during development and CI.
## Tags Added
| Tag | Count | Purpose |
|-----|-------|---------|
| `@screenshot` | 32 files | Tests with visual assertions
(`toHaveScreenshot`) |
| `@smoke` | 5 files | Quick essential tests for fast validation |
| `@slow` | 5 files | Long-running tests (templates, subgraph,
featureFlags) |
| `@canvas` | 15 files | Canvas/graph rendering tests |
| `@node` | 10 files | Node behavior tests |
| `@ui` | 8 files | UI component tests |
| `@widget` | 5 files | Widget-specific tests |
| `@workflow` | 3 files | Workflow operations |
| `@subgraph` | 1 file | Subgraph functionality |
| `@keyboard` | 2 files | Keyboard shortcuts |
| `@settings` | 2 files | Settings/preferences |
## Usage Examples
```bash
# Quick validation (~16 tests, ~30s)
pnpm test:browser -- --grep @smoke
# Skip slow tests for faster CI feedback
pnpm test:browser -- --grep-invert @slow
# Skip visual tests (useful for local development without snapshots)
pnpm test:browser -- --grep-invert @screenshot
# Run only canvas-related tests
pnpm test:browser -- --grep @canvas
# Combine filters
pnpm test:browser -- --grep @smoke --grep-invert @screenshot
```
## Implementation Details
- Uses Playwright's native tag syntax: `test.describe('Name', { tag:
'@tag' }, ...)`
- Tags inherit from describe blocks to child tests
- Preserves existing project-level tags: `@mobile`, `@2x`, `@0.5x`
- Multiple tags supported: `{ tag: ['@screenshot', '@smoke'] }`
## Test Plan
- [x] All existing tests pass unchanged
- [x] Tag filtering works with `--grep` and `--grep-invert`
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8441-test-add-Playwright-test-tags-for-filtering-smoke-slow-screenshot-domains-2f76d73d36508184990ec859c8fd7629)
by [Unito](https://www.unito.io)
---------
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: GitHub Action <action@github.com>
54 lines
1.9 KiB
TypeScript
54 lines
1.9 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
})
|
|
|
|
test.describe('Execution', { tag: ['@smoke', '@workflow'] }, () => {
|
|
test(
|
|
'Report error on unconnected slot',
|
|
{ tag: '@screenshot' },
|
|
async ({ comfyPage }) => {
|
|
await comfyPage.disconnectEdge()
|
|
await comfyPage.clickEmptySpace()
|
|
|
|
await comfyPage.executeCommand('Comfy.QueuePrompt')
|
|
await expect(comfyPage.page.locator('.comfy-error-report')).toBeVisible()
|
|
await comfyPage.page.locator('.p-dialog-close-button').click()
|
|
await comfyPage.page.locator('.comfy-error-report').waitFor({
|
|
state: 'hidden'
|
|
})
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'execution-error-unconnected-slot.png'
|
|
)
|
|
}
|
|
)
|
|
})
|
|
|
|
test.describe(
|
|
'Execute to selected output nodes',
|
|
{ tag: ['@smoke', '@workflow'] },
|
|
() => {
|
|
test('Execute to selected output nodes', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('execution/partial_execution')
|
|
const input = await comfyPage.getNodeRefById(3)
|
|
const output1 = await comfyPage.getNodeRefById(1)
|
|
const output2 = await comfyPage.getNodeRefById(4)
|
|
expect(await (await input.getWidget(0)).getValue()).toBe('foo')
|
|
expect(await (await output1.getWidget(0)).getValue()).toBe('')
|
|
expect(await (await output2.getWidget(0)).getValue()).toBe('')
|
|
|
|
await output1.click('title')
|
|
|
|
await comfyPage.executeCommand('Comfy.QueueSelectedOutputNodes')
|
|
await expect(async () => {
|
|
expect(await (await input.getWidget(0)).getValue()).toBe('foo')
|
|
expect(await (await output1.getWidget(0)).getValue()).toBe('foo')
|
|
expect(await (await output2.getWidget(0)).getValue()).toBe('')
|
|
}).toPass({ timeout: 2_000 })
|
|
})
|
|
}
|
|
)
|