mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-01-31 13:29:55 +00:00
## Summary
Adds structured test tags to all 54 Playwright test files to enable
flexible test filtering during development and CI.
## Tags Added
| Tag | Count | Purpose |
|-----|-------|---------|
| `@screenshot` | 32 files | Tests with visual assertions
(`toHaveScreenshot`) |
| `@smoke` | 5 files | Quick essential tests for fast validation |
| `@slow` | 5 files | Long-running tests (templates, subgraph,
featureFlags) |
| `@canvas` | 15 files | Canvas/graph rendering tests |
| `@node` | 10 files | Node behavior tests |
| `@ui` | 8 files | UI component tests |
| `@widget` | 5 files | Widget-specific tests |
| `@workflow` | 3 files | Workflow operations |
| `@subgraph` | 1 file | Subgraph functionality |
| `@keyboard` | 2 files | Keyboard shortcuts |
| `@settings` | 2 files | Settings/preferences |
## Usage Examples
```bash
# Quick validation (~16 tests, ~30s)
pnpm test:browser -- --grep @smoke
# Skip slow tests for faster CI feedback
pnpm test:browser -- --grep-invert @slow
# Skip visual tests (useful for local development without snapshots)
pnpm test:browser -- --grep-invert @screenshot
# Run only canvas-related tests
pnpm test:browser -- --grep @canvas
# Combine filters
pnpm test:browser -- --grep @smoke --grep-invert @screenshot
```
## Implementation Details
- Uses Playwright's native tag syntax: `test.describe('Name', { tag:
'@tag' }, ...)`
- Tags inherit from describe blocks to child tests
- Preserves existing project-level tags: `@mobile`, `@2x`, `@0.5x`
- Multiple tags supported: `{ tag: ['@screenshot', '@smoke'] }`
## Test Plan
- [x] All existing tests pass unchanged
- [x] Tag filtering works with `--grep` and `--grep-invert`
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8441-test-add-Playwright-test-tags-for-filtering-smoke-slow-screenshot-domains-2f76d73d36508184990ec859c8fd7629)
by [Unito](https://www.unito.io)
---------
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: GitHub Action <action@github.com>
86 lines
3.4 KiB
TypeScript
86 lines
3.4 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
})
|
|
|
|
// If an input is optional by node definition, it should be shown as
|
|
// a hollow circle no matter what shape it was defined in the workflow JSON.
|
|
test.describe('Optional input', { tag: ['@screenshot', '@node'] }, () => {
|
|
test('No shape specified', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/optional_input_no_shape')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('optional_input.png')
|
|
})
|
|
|
|
test('Wrong shape specified', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/optional_input_wrong_shape')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('optional_input.png')
|
|
})
|
|
|
|
test('Correct shape specified', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/optional_input_correct_shape')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('optional_input.png')
|
|
})
|
|
|
|
test('Force input', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/force_input')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('force_input.png')
|
|
})
|
|
|
|
test('Default input', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/default_input')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('default_input.png')
|
|
})
|
|
|
|
test('Only optional inputs', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/only_optional_inputs')
|
|
expect(await comfyPage.getGraphNodesCount()).toBe(1)
|
|
await expect(
|
|
comfyPage.page.locator('.comfy-missing-nodes')
|
|
).not.toBeVisible()
|
|
|
|
// If the node's multiline text widget is visible, then it was loaded successfully
|
|
await expect(comfyPage.page.locator('.comfy-multiline-input')).toHaveCount(
|
|
1
|
|
)
|
|
})
|
|
test('Old workflow with converted input', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/old_workflow_converted_input')
|
|
const node = await comfyPage.getNodeRefById('1')
|
|
const inputs = await node.getProperty('inputs')
|
|
const vaeInput = inputs.find((w) => w.name === 'vae')
|
|
const convertedInput = inputs.find((w) => w.name === 'strength')
|
|
|
|
expect(vaeInput).toBeDefined()
|
|
expect(convertedInput).toBeDefined()
|
|
expect(vaeInput.link).toBeNull()
|
|
expect(convertedInput.link).not.toBeNull()
|
|
})
|
|
test('Renamed converted input', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/renamed_converted_widget')
|
|
const node = await comfyPage.getNodeRefById('3')
|
|
const inputs = await node.getProperty('inputs')
|
|
const renamedInput = inputs.find((w) => w.name === 'breadth')
|
|
expect(renamedInput).toBeUndefined()
|
|
})
|
|
test('slider', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/simple_slider')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('simple_slider.png')
|
|
})
|
|
test('unknown converted widget', async ({ comfyPage }) => {
|
|
await comfyPage.setSetting('Comfy.Workflow.ShowMissingNodesWarning', false)
|
|
await comfyPage.loadWorkflow('missing/missing_nodes_converted_widget')
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'missing_nodes_converted_widget.png'
|
|
)
|
|
})
|
|
test('dynamically added input', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/dynamically_added_input')
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'dynamically_added_input.png'
|
|
)
|
|
})
|
|
})
|