mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-01-31 13:29:55 +00:00
82bacb82a7
## Summary
Adds structured test tags to all 54 Playwright test files to enable
flexible test filtering during development and CI.
## Tags Added
| Tag | Count | Purpose |
|-----|-------|---------|
| `@screenshot` | 32 files | Tests with visual assertions
(`toHaveScreenshot`) |
| `@smoke` | 5 files | Quick essential tests for fast validation |
| `@slow` | 5 files | Long-running tests (templates, subgraph,
featureFlags) |
| `@canvas` | 15 files | Canvas/graph rendering tests |
| `@node` | 10 files | Node behavior tests |
| `@ui` | 8 files | UI component tests |
| `@widget` | 5 files | Widget-specific tests |
| `@workflow` | 3 files | Workflow operations |
| `@subgraph` | 1 file | Subgraph functionality |
| `@keyboard` | 2 files | Keyboard shortcuts |
| `@settings` | 2 files | Settings/preferences |
## Usage Examples
```bash
# Quick validation (~16 tests, ~30s)
pnpm test:browser -- --grep @smoke
# Skip slow tests for faster CI feedback
pnpm test:browser -- --grep-invert @slow
# Skip visual tests (useful for local development without snapshots)
pnpm test:browser -- --grep-invert @screenshot
# Run only canvas-related tests
pnpm test:browser -- --grep @canvas
# Combine filters
pnpm test:browser -- --grep @smoke --grep-invert @screenshot
```
## Implementation Details
- Uses Playwright's native tag syntax: `test.describe('Name', { tag:
'@tag' }, ...)`
- Tags inherit from describe blocks to child tests
- Preserves existing project-level tags: `@mobile`, `@2x`, `@0.5x`
- Multiple tags supported: `{ tag: ['@screenshot', '@smoke'] }`
## Test Plan
- [x] All existing tests pass unchanged
- [x] Tag filtering works with `--grep` and `--grep-invert`
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8441-test-add-Playwright-test-tags-for-filtering-smoke-slow-screenshot-domains-2f76d73d36508184990ec859c8fd7629)
by [Unito](https://www.unito.io)
---------
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: GitHub Action <action@github.com>
44 lines
1.5 KiB
TypeScript
44 lines
1.5 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { userSelectPageFixture as test } from '../fixtures/UserSelectPage'
|
|
|
|
/**
|
|
* Expects ComfyUI backend to be launched with `--multi-user` flag.
|
|
*/
|
|
test.describe('User Select View', { tag: '@settings' }, () => {
|
|
test.beforeEach(async ({ userSelectPage, page }) => {
|
|
await page.goto(userSelectPage.url)
|
|
await page.evaluate(() => {
|
|
localStorage.clear()
|
|
sessionStorage.clear()
|
|
})
|
|
})
|
|
|
|
test('Redirects to user select view if no user is logged in', async ({
|
|
userSelectPage,
|
|
page
|
|
}) => {
|
|
await page.goto(userSelectPage.url)
|
|
await expect(userSelectPage.container).toBeVisible()
|
|
expect(page.url()).toBe(userSelectPage.selectionUrl)
|
|
})
|
|
|
|
test('Can create new user', async ({ userSelectPage, page }) => {
|
|
const randomUser = `test-user-${Math.random().toString(36).substring(2, 7)}`
|
|
await page.goto(userSelectPage.url)
|
|
await expect(page).toHaveURL(userSelectPage.selectionUrl)
|
|
await userSelectPage.newUserInput.fill(randomUser)
|
|
await userSelectPage.nextButton.click()
|
|
await expect(page).toHaveURL(userSelectPage.url)
|
|
})
|
|
|
|
test('Can choose existing user', async ({ userSelectPage, page }) => {
|
|
await page.goto(userSelectPage.url)
|
|
await expect(page).toHaveURL(userSelectPage.selectionUrl)
|
|
await userSelectPage.existingUserSelect.click()
|
|
await page.locator('.p-select-list .p-select-option').first().click()
|
|
await userSelectPage.nextButton.click()
|
|
await expect(page).toHaveURL(userSelectPage.url)
|
|
})
|
|
})
|