mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-04 15:10:06 +00:00
## Summary We added the menu button to both the tabs & where the subgraph menu button was previously in order to get feedback on where this button should be. We've received feedback that the one on the tabs is not a common UX element, and that having both seems like a bug, and that the one on the graph is prefered. Due to this, we're removing the one on the tabs. ## Changes - Remove tab menu button ## Screenshots (if applicable) Before: <img width="733" height="224" alt="image" src="https://github.com/user-attachments/assets/3f916d96-4bfe-482d-a8eb-8b18a7327334" /> After: <img width="731" height="248" alt="image" src="https://github.com/user-attachments/assets/5eeb31e5-e49f-409a-8eac-04773182a145" /> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8067-Remove-hamburger-menu-from-tabs-2e96d73d3650815aa80af4d5aa8767cd) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <github-actions@github.com>
190 lines
5.4 KiB
Vue
190 lines
5.4 KiB
Vue
<template>
|
|
<div
|
|
ref="workflowTabRef"
|
|
class="workflow-tab group flex gap-2 p-2"
|
|
v-bind="$attrs"
|
|
@mouseenter="handleMouseEnter"
|
|
@mouseleave="handleMouseLeave"
|
|
@click="handleClick"
|
|
>
|
|
<i
|
|
v-if="workflowOption.workflow.activeState?.extra?.linearMode"
|
|
class="icon-[lucide--panels-top-left] bg-primary-background"
|
|
/>
|
|
<span class="workflow-label inline-block max-w-[150px] truncate text-sm">
|
|
{{ workflowOption.workflow.filename }}
|
|
</span>
|
|
<div class="relative">
|
|
<span
|
|
v-if="shouldShowStatusIndicator"
|
|
class="absolute top-1/2 left-1/2 z-10 w-4 -translate-1/2 bg-(--comfy-menu-bg) text-2xl font-bold group-hover:hidden"
|
|
>•</span
|
|
>
|
|
<Button
|
|
class="close-button invisible w-auto p-0"
|
|
variant="muted-textonly"
|
|
size="icon-sm"
|
|
:aria-label="t('g.close')"
|
|
@click.stop="onCloseWorkflow(workflowOption)"
|
|
>
|
|
<i class="pi pi-times" />
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
|
|
<WorkflowTabPopover
|
|
ref="popoverRef"
|
|
:workflow-filename="workflowOption.workflow.filename"
|
|
:thumbnail-url="thumbnailUrl"
|
|
:is-active-tab="isActiveTab"
|
|
/>
|
|
</template>
|
|
|
|
<script setup lang="ts">
|
|
import { computed, onUnmounted, ref } from 'vue'
|
|
import { useI18n } from 'vue-i18n'
|
|
|
|
import Button from '@/components/ui/button/Button.vue'
|
|
import {
|
|
usePragmaticDraggable,
|
|
usePragmaticDroppable
|
|
} from '@/composables/usePragmaticDragAndDrop'
|
|
import { useSettingStore } from '@/platform/settings/settingStore'
|
|
import { useWorkflowService } from '@/platform/workflow/core/services/workflowService'
|
|
import type { ComfyWorkflow } from '@/platform/workflow/management/stores/workflowStore'
|
|
import { useWorkflowStore } from '@/platform/workflow/management/stores/workflowStore'
|
|
import { useWorkflowThumbnail } from '@/renderer/core/thumbnail/useWorkflowThumbnail'
|
|
import { useWorkspaceStore } from '@/stores/workspaceStore'
|
|
|
|
import WorkflowTabPopover from './WorkflowTabPopover.vue'
|
|
|
|
interface WorkflowOption {
|
|
value: string
|
|
workflow: ComfyWorkflow
|
|
}
|
|
|
|
const props = defineProps<{
|
|
workflowOption: WorkflowOption
|
|
}>()
|
|
|
|
const { t } = useI18n()
|
|
|
|
const workspaceStore = useWorkspaceStore()
|
|
const workflowStore = useWorkflowStore()
|
|
const settingStore = useSettingStore()
|
|
const workflowTabRef = ref<HTMLElement | null>(null)
|
|
const popoverRef = ref<InstanceType<typeof WorkflowTabPopover> | null>(null)
|
|
const workflowThumbnail = useWorkflowThumbnail()
|
|
|
|
// Use computed refs to cache autosave settings
|
|
const autoSaveSetting = computed(() =>
|
|
settingStore.get('Comfy.Workflow.AutoSave')
|
|
)
|
|
const autoSaveDelay = computed(() =>
|
|
settingStore.get('Comfy.Workflow.AutoSaveDelay')
|
|
)
|
|
|
|
const shouldShowStatusIndicator = computed(() => {
|
|
if (workspaceStore.shiftDown) {
|
|
// Branch 1: Shift key is held down, do not show the status indicator.
|
|
return false
|
|
}
|
|
if (!props.workflowOption.workflow.isPersisted) {
|
|
// Branch 2: Workflow is not persisted, show the status indicator.
|
|
return true
|
|
}
|
|
if (props.workflowOption.workflow.isModified) {
|
|
// Branch 3: Workflow is modified.
|
|
if (autoSaveSetting.value === 'off') {
|
|
// Sub-branch 3a: Autosave is off, so show the status indicator.
|
|
return true
|
|
}
|
|
if (autoSaveSetting.value === 'after delay' && autoSaveDelay.value > 3000) {
|
|
// Sub-branch 3b: Autosave delay is too high, so show the status indicator.
|
|
return true
|
|
}
|
|
// Sub-branch 3c: Workflow is modified but no condition applies, do not show the status indicator.
|
|
return false
|
|
}
|
|
// Default: do not show the status indicator. This should not be reachable.
|
|
return false
|
|
})
|
|
|
|
const isActiveTab = computed(() => {
|
|
return workflowStore.activeWorkflow?.key === props.workflowOption.workflow.key
|
|
})
|
|
|
|
const thumbnailUrl = computed(() => {
|
|
return workflowThumbnail.getThumbnail(props.workflowOption.workflow.key)
|
|
})
|
|
|
|
// Event handlers that delegate to the popover component
|
|
const handleMouseEnter = (event: Event) => {
|
|
popoverRef.value?.showPopover(event)
|
|
}
|
|
|
|
const handleMouseLeave = () => {
|
|
popoverRef.value?.hidePopover()
|
|
}
|
|
|
|
const handleClick = (event: Event) => {
|
|
popoverRef.value?.togglePopover(event)
|
|
}
|
|
|
|
const closeWorkflows = async (options: WorkflowOption[]) => {
|
|
for (const opt of options) {
|
|
if (
|
|
!(await useWorkflowService().closeWorkflow(opt.workflow, {
|
|
warnIfUnsaved: !workspaceStore.shiftDown,
|
|
hint: t('sideToolbar.workflowTab.dirtyCloseHint')
|
|
}))
|
|
) {
|
|
// User clicked cancel
|
|
break
|
|
}
|
|
}
|
|
}
|
|
|
|
const onCloseWorkflow = async (option: WorkflowOption) => {
|
|
await closeWorkflows([option])
|
|
}
|
|
const tabGetter = () => workflowTabRef.value as HTMLElement
|
|
|
|
usePragmaticDraggable(tabGetter, {
|
|
getInitialData: () => {
|
|
return {
|
|
workflowKey: props.workflowOption.workflow.key
|
|
}
|
|
}
|
|
})
|
|
|
|
usePragmaticDroppable(tabGetter, {
|
|
getData: () => {
|
|
return {
|
|
workflowKey: props.workflowOption.workflow.key
|
|
}
|
|
},
|
|
onDrop: (e) => {
|
|
const fromIndex = workflowStore.openWorkflows.findIndex(
|
|
(wf) => wf.key === e.source.data.workflowKey
|
|
)
|
|
const toIndex = workflowStore.openWorkflows.findIndex(
|
|
(wf) => wf.key === e.location.current.dropTargets[0]?.data.workflowKey
|
|
)
|
|
if (fromIndex !== toIndex) {
|
|
workflowStore.reorderWorkflows(fromIndex, toIndex)
|
|
}
|
|
}
|
|
})
|
|
|
|
onUnmounted(() => {
|
|
popoverRef.value?.hidePopover()
|
|
})
|
|
</script>
|
|
|
|
<style>
|
|
.p-tooltip.workflow-tab-tooltip {
|
|
z-index: 1200 !important;
|
|
}
|
|
</style>
|