mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
## Summary Add eslint-plugin-playwright as an oxlint JS plugin scoped to browser_tests/, enforcing Playwright best practices at lint time. ## Changes - **What**: Configure eslint-plugin-playwright@2.10.1 via oxlint's alpha `jsPlugins` field (`.oxlintrc.json` override scoped to `browser_tests/**/*.ts`). 18 recommended rules + `prefer-native-locators` + `require-to-pass-timeout` at error severity. All 173 initial violations resolved (config, auto-fix, manual fixes). `no-force-option` set to off — 28 violations need triage (canvas overlay workarounds vs unnecessary force) in a dedicated PR. - **Dependencies**: `eslint-plugin-playwright@^2.10.1` (devDependency, required by oxlint jsPlugins at runtime) ## Review Focus - `.oxlintrc.json` override structure — this is the first use of oxlint's JS plugins alpha feature in this repo - Manual fixes in spec files: `waitForSelector` → `locator.waitFor`, deprecated page methods → locator equivalents, `toPass()` timeout additions - Compound CSS selectors replaced with `.and()` (Playwright native locator composition) to avoid `prefer-native-locators` suppressions - Lint script changes in `package.json` to include `browser_tests/` in oxlint targets --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com>
186 lines
5.8 KiB
TypeScript
186 lines
5.8 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import type { ComfyPage } from '@e2e/fixtures/ComfyPage'
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
import { TestIds } from '@e2e/fixtures/selectors'
|
|
import { openErrorsTabViaSeeErrors } from '@e2e/tests/propertiesPanel/ErrorsTabHelper'
|
|
|
|
async function uploadFileViaDropzone(comfyPage: ComfyPage) {
|
|
const dropzone = comfyPage.page.getByTestId(
|
|
TestIds.dialogs.missingMediaUploadDropzone
|
|
)
|
|
const [fileChooser] = await Promise.all([
|
|
comfyPage.page.waitForEvent('filechooser'),
|
|
dropzone.click()
|
|
])
|
|
await fileChooser.setFiles(comfyPage.assetPath('test_upload_image.png'))
|
|
}
|
|
|
|
async function confirmPendingSelection(comfyPage: ComfyPage) {
|
|
const confirmButton = comfyPage.page.getByTestId(
|
|
TestIds.dialogs.missingMediaConfirmButton
|
|
)
|
|
await expect(confirmButton).toBeEnabled()
|
|
await confirmButton.click()
|
|
}
|
|
|
|
function getMediaRow(comfyPage: ComfyPage) {
|
|
return comfyPage.page.getByTestId(TestIds.dialogs.missingMediaRow)
|
|
}
|
|
|
|
function getStatusCard(comfyPage: ComfyPage) {
|
|
return comfyPage.page.getByTestId(TestIds.dialogs.missingMediaStatusCard)
|
|
}
|
|
|
|
function getDropzone(comfyPage: ComfyPage) {
|
|
return comfyPage.page.getByTestId(TestIds.dialogs.missingMediaUploadDropzone)
|
|
}
|
|
|
|
test.describe('Errors tab - Missing media', { tag: '@ui' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
await comfyPage.settings.setSetting(
|
|
'Comfy.RightSidePanel.ShowErrorsTab',
|
|
true
|
|
)
|
|
})
|
|
|
|
test.describe('Detection', () => {
|
|
test('Shows missing media group in errors tab', async ({ comfyPage }) => {
|
|
await openErrorsTabViaSeeErrors(comfyPage, 'missing/missing_media_single')
|
|
|
|
await expect(
|
|
comfyPage.page.getByTestId(TestIds.dialogs.missingMediaGroup)
|
|
).toBeVisible()
|
|
})
|
|
|
|
test('Shows correct number of missing media rows', async ({
|
|
comfyPage
|
|
}) => {
|
|
await openErrorsTabViaSeeErrors(
|
|
comfyPage,
|
|
'missing/missing_media_multiple'
|
|
)
|
|
|
|
await expect(getMediaRow(comfyPage)).toHaveCount(2)
|
|
})
|
|
|
|
test('Shows upload dropzone and library select for each missing item', async ({
|
|
comfyPage
|
|
}) => {
|
|
await openErrorsTabViaSeeErrors(comfyPage, 'missing/missing_media_single')
|
|
|
|
await expect(getDropzone(comfyPage)).toBeVisible()
|
|
await expect(
|
|
comfyPage.page.getByTestId(TestIds.dialogs.missingMediaLibrarySelect)
|
|
).toBeVisible()
|
|
})
|
|
})
|
|
|
|
test.describe('Upload flow', () => {
|
|
test('Upload via file picker shows status card then allows confirm', async ({
|
|
comfyPage
|
|
}) => {
|
|
await openErrorsTabViaSeeErrors(comfyPage, 'missing/missing_media_single')
|
|
await uploadFileViaDropzone(comfyPage)
|
|
|
|
await expect(getStatusCard(comfyPage)).toBeVisible()
|
|
|
|
await confirmPendingSelection(comfyPage)
|
|
await expect(getMediaRow(comfyPage)).toHaveCount(0)
|
|
})
|
|
})
|
|
|
|
test.describe('Library select flow', () => {
|
|
test('Selecting from library shows status card then allows confirm', async ({
|
|
comfyPage
|
|
}) => {
|
|
await openErrorsTabViaSeeErrors(comfyPage, 'missing/missing_media_single')
|
|
|
|
const librarySelect = comfyPage.page.getByTestId(
|
|
TestIds.dialogs.missingMediaLibrarySelect
|
|
)
|
|
await librarySelect.getByRole('combobox').click()
|
|
|
|
const optionCount = await comfyPage.page.getByRole('option').count()
|
|
if (optionCount === 0) {
|
|
// oxlint-disable-next-line playwright/no-skipped-test -- no library options available in CI
|
|
test.skip()
|
|
return
|
|
}
|
|
|
|
await comfyPage.page.getByRole('option').first().click()
|
|
|
|
await expect(getStatusCard(comfyPage)).toBeVisible()
|
|
|
|
await confirmPendingSelection(comfyPage)
|
|
await expect(getMediaRow(comfyPage)).toHaveCount(0)
|
|
})
|
|
})
|
|
|
|
test.describe('Cancel selection', () => {
|
|
test('Cancelling pending selection returns to upload/library UI', async ({
|
|
comfyPage
|
|
}) => {
|
|
await openErrorsTabViaSeeErrors(comfyPage, 'missing/missing_media_single')
|
|
await uploadFileViaDropzone(comfyPage)
|
|
|
|
await expect(getStatusCard(comfyPage)).toBeVisible()
|
|
await expect(getDropzone(comfyPage)).toBeHidden()
|
|
|
|
await comfyPage.page
|
|
.getByTestId(TestIds.dialogs.missingMediaCancelButton)
|
|
.click()
|
|
|
|
await expect(getStatusCard(comfyPage)).toBeHidden()
|
|
await expect(getDropzone(comfyPage)).toBeVisible()
|
|
})
|
|
})
|
|
|
|
test.describe('All resolved', () => {
|
|
test('Missing Inputs group disappears when all items are resolved', async ({
|
|
comfyPage
|
|
}) => {
|
|
await openErrorsTabViaSeeErrors(comfyPage, 'missing/missing_media_single')
|
|
await uploadFileViaDropzone(comfyPage)
|
|
await confirmPendingSelection(comfyPage)
|
|
|
|
await expect(
|
|
comfyPage.page.getByTestId(TestIds.dialogs.missingMediaGroup)
|
|
).toBeHidden()
|
|
})
|
|
})
|
|
|
|
test.describe('Locate node', () => {
|
|
test('Locate button navigates canvas to the missing media node', async ({
|
|
comfyPage
|
|
}) => {
|
|
await openErrorsTabViaSeeErrors(comfyPage, 'missing/missing_media_single')
|
|
|
|
const offsetBefore = await comfyPage.page.evaluate(() => {
|
|
const canvas = window['app']?.canvas
|
|
return canvas?.ds?.offset
|
|
? [canvas.ds.offset[0], canvas.ds.offset[1]]
|
|
: null
|
|
})
|
|
|
|
const locateButton = comfyPage.page.getByTestId(
|
|
TestIds.dialogs.missingMediaLocateButton
|
|
)
|
|
await expect(locateButton).toBeVisible()
|
|
await locateButton.click()
|
|
|
|
await expect
|
|
.poll(async () => {
|
|
return await comfyPage.page.evaluate(() => {
|
|
const canvas = window['app']?.canvas
|
|
return canvas?.ds?.offset
|
|
? [canvas.ds.offset[0], canvas.ds.offset[1]]
|
|
: null
|
|
})
|
|
})
|
|
.not.toEqual(offsetBefore)
|
|
})
|
|
})
|
|
})
|