mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
8c9328c1b2
## Summary Add eslint-plugin-playwright as an oxlint JS plugin scoped to browser_tests/, enforcing Playwright best practices at lint time. ## Changes - **What**: Configure eslint-plugin-playwright@2.10.1 via oxlint's alpha `jsPlugins` field (`.oxlintrc.json` override scoped to `browser_tests/**/*.ts`). 18 recommended rules + `prefer-native-locators` + `require-to-pass-timeout` at error severity. All 173 initial violations resolved (config, auto-fix, manual fixes). `no-force-option` set to off — 28 violations need triage (canvas overlay workarounds vs unnecessary force) in a dedicated PR. - **Dependencies**: `eslint-plugin-playwright@^2.10.1` (devDependency, required by oxlint jsPlugins at runtime) ## Review Focus - `.oxlintrc.json` override structure — this is the first use of oxlint's JS plugins alpha feature in this repo - Manual fixes in spec files: `waitForSelector` → `locator.waitFor`, deprecated page methods → locator equivalents, `toPass()` timeout additions - Compound CSS selectors replaced with `.and()` (Playwright native locator composition) to avoid `prefer-native-locators` suppressions - Lint script changes in `package.json` to include `browser_tests/` in oxlint targets --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com>
69 lines
2.2 KiB
TypeScript
69 lines
2.2 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import type { ComfyPage } from '@e2e/fixtures/ComfyPage'
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
|
|
test.describe('MediaLightbox', { tag: ['@slow'] }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
|
|
await comfyPage.setup()
|
|
})
|
|
|
|
async function runAndOpenGallery(comfyPage: ComfyPage) {
|
|
await comfyPage.workflow.loadWorkflow(
|
|
'widgets/save_image_and_animated_webp'
|
|
)
|
|
await comfyPage.vueNodes.waitForNodes()
|
|
await comfyPage.runButton.click()
|
|
|
|
// Wait for SaveImage node to produce output
|
|
const saveImageNode = comfyPage.vueNodes.getNodeByTitle('Save Image')
|
|
await expect(saveImageNode.locator('.image-preview img')).toBeVisible({
|
|
timeout: 30_000
|
|
})
|
|
|
|
// Open Assets sidebar tab and wait for it to load
|
|
await comfyPage.page.locator('.assets-tab-button').click()
|
|
await comfyPage.page
|
|
.locator('.sidebar-content-container')
|
|
.waitFor({ state: 'visible' })
|
|
|
|
// Wait for any asset card to appear (may contain img or video)
|
|
const assetCard = comfyPage.page
|
|
.getByRole('button')
|
|
.filter({ has: comfyPage.page.locator('img, video') })
|
|
.first()
|
|
|
|
await expect(assetCard).toBeVisible({ timeout: 30_000 })
|
|
|
|
// Hover to reveal zoom button, then click it
|
|
await assetCard.hover()
|
|
await assetCard.getByLabel('Zoom in').click()
|
|
|
|
const { root } = comfyPage.mediaLightbox
|
|
await expect(root).toBeVisible()
|
|
}
|
|
|
|
test('opens gallery and shows dialog with close button', async ({
|
|
comfyPage
|
|
}) => {
|
|
await runAndOpenGallery(comfyPage)
|
|
await expect(comfyPage.mediaLightbox.closeButton).toBeVisible()
|
|
})
|
|
|
|
test('closes gallery on Escape key', async ({ comfyPage }) => {
|
|
await runAndOpenGallery(comfyPage)
|
|
|
|
await comfyPage.page.keyboard.press('Escape')
|
|
await expect(comfyPage.mediaLightbox.root).toBeHidden()
|
|
})
|
|
|
|
test('closes gallery when clicking close button', async ({ comfyPage }) => {
|
|
await runAndOpenGallery(comfyPage)
|
|
|
|
await comfyPage.mediaLightbox.closeButton.click()
|
|
await expect(comfyPage.mediaLightbox.root).toBeHidden()
|
|
})
|
|
})
|