mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 06:20:11 +00:00
0b83926c3e
## Summary Fixes an issue where handlers would be leaked causing Vue node rendering to be corrupted (Vue nodes would not render) due to the 00000000-0000-0000-0000-000000000000 ID being used on the root graph. ## Changes - **What**: - LGraph clear() skips store cleanup for the zero uuid, leaking handlers that cause the node manager/handlers to be overwritten during operations such as undo due to stale onNodeAdded hooks - Ensures that graph configuration assigns a valid ID for root graphs ## Screenshots (if applicable) Before fix, after doing ctrl+z after entering subgraph <img width="1011" height="574" alt="image" src="https://github.com/user-attachments/assets/1ff4692b-b961-4777-bf2d-9b981e311f91" /> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10825-fix-Ensure-zero-uuid-root-graphs-get-assigned-a-valid-id-3366d73d3650817d8603c71ffb5e5742) by [Unito](https://www.unito.io) --------- Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
198 lines
4.8 KiB
JSON
198 lines
4.8 KiB
JSON
{
|
|
"id": "00000000-0000-0000-0000-000000000000",
|
|
"revision": 0,
|
|
"last_node_id": 2,
|
|
"last_link_id": 0,
|
|
"nodes": [
|
|
{
|
|
"id": 2,
|
|
"type": "e5fb1765-9323-4548-801a-5aead34d879e",
|
|
"pos": [627.5973510742188, 423.0972900390625],
|
|
"size": [144.15234375, 46],
|
|
"flags": {},
|
|
"order": 0,
|
|
"mode": 0,
|
|
"inputs": [
|
|
{
|
|
"name": "positive",
|
|
"type": "CONDITIONING",
|
|
"link": null
|
|
}
|
|
],
|
|
"outputs": [
|
|
{
|
|
"name": "LATENT",
|
|
"type": "LATENT",
|
|
"links": null
|
|
}
|
|
],
|
|
"properties": {},
|
|
"widgets_values": []
|
|
}
|
|
],
|
|
"links": [],
|
|
"groups": [],
|
|
"definitions": {
|
|
"subgraphs": [
|
|
{
|
|
"id": "e5fb1765-9323-4548-801a-5aead34d879e",
|
|
"version": 1,
|
|
"state": {
|
|
"lastGroupId": 0,
|
|
"lastNodeId": 2,
|
|
"lastLinkId": 4,
|
|
"lastRerouteId": 0
|
|
},
|
|
"revision": 0,
|
|
"config": {},
|
|
"name": "New Subgraph",
|
|
"inputNode": {
|
|
"id": -10,
|
|
"bounding": [347.90441582814213, 417.3822440655296, 120, 60]
|
|
},
|
|
"outputNode": {
|
|
"id": -20,
|
|
"bounding": [892.5973510742188, 416.0972900390625, 120, 60]
|
|
},
|
|
"inputs": [
|
|
{
|
|
"id": "c5cc99d8-a2b6-4bf3-8be7-d4949ef736cd",
|
|
"name": "positive",
|
|
"type": "CONDITIONING",
|
|
"linkIds": [1],
|
|
"pos": {
|
|
"0": 447.9044189453125,
|
|
"1": 437.3822326660156
|
|
}
|
|
}
|
|
],
|
|
"outputs": [
|
|
{
|
|
"id": "9bd488b9-e907-4c95-a7a4-85c5597a87af",
|
|
"name": "LATENT",
|
|
"type": "LATENT",
|
|
"linkIds": [2],
|
|
"pos": {
|
|
"0": 912.5973510742188,
|
|
"1": 436.0972900390625
|
|
}
|
|
}
|
|
],
|
|
"widgets": [],
|
|
"nodes": [
|
|
{
|
|
"id": 1,
|
|
"type": "KSampler",
|
|
"pos": [554.8743286132812, 100.95539093017578],
|
|
"size": [270, 262],
|
|
"flags": {},
|
|
"order": 1,
|
|
"mode": 0,
|
|
"inputs": [
|
|
{
|
|
"localized_name": "model",
|
|
"name": "model",
|
|
"type": "MODEL",
|
|
"link": null
|
|
},
|
|
{
|
|
"localized_name": "positive",
|
|
"name": "positive",
|
|
"type": "CONDITIONING",
|
|
"link": 1
|
|
},
|
|
{
|
|
"localized_name": "negative",
|
|
"name": "negative",
|
|
"type": "CONDITIONING",
|
|
"link": null
|
|
},
|
|
{
|
|
"localized_name": "latent_image",
|
|
"name": "latent_image",
|
|
"type": "LATENT",
|
|
"link": null
|
|
}
|
|
],
|
|
"outputs": [
|
|
{
|
|
"localized_name": "LATENT",
|
|
"name": "LATENT",
|
|
"type": "LATENT",
|
|
"links": [2]
|
|
}
|
|
],
|
|
"properties": {
|
|
"Node name for S&R": "KSampler"
|
|
},
|
|
"widgets_values": [0, "randomize", 20, 8, "euler", "simple", 1]
|
|
},
|
|
{
|
|
"id": 2,
|
|
"type": "VAEEncode",
|
|
"pos": [685.1265869140625, 439.1734619140625],
|
|
"size": [140, 46],
|
|
"flags": {},
|
|
"order": 0,
|
|
"mode": 0,
|
|
"inputs": [
|
|
{
|
|
"localized_name": "pixels",
|
|
"name": "pixels",
|
|
"type": "IMAGE",
|
|
"link": null
|
|
},
|
|
{
|
|
"localized_name": "vae",
|
|
"name": "vae",
|
|
"type": "VAE",
|
|
"link": null
|
|
}
|
|
],
|
|
"outputs": [
|
|
{
|
|
"localized_name": "LATENT",
|
|
"name": "LATENT",
|
|
"type": "LATENT",
|
|
"links": [4]
|
|
}
|
|
],
|
|
"properties": {
|
|
"Node name for S&R": "VAEEncode"
|
|
}
|
|
}
|
|
],
|
|
"groups": [],
|
|
"links": [
|
|
{
|
|
"id": 1,
|
|
"origin_id": -10,
|
|
"origin_slot": 0,
|
|
"target_id": 1,
|
|
"target_slot": 1,
|
|
"type": "CONDITIONING"
|
|
},
|
|
{
|
|
"id": 2,
|
|
"origin_id": 1,
|
|
"origin_slot": 0,
|
|
"target_id": -20,
|
|
"target_slot": 0,
|
|
"type": "LATENT"
|
|
}
|
|
],
|
|
"extra": {}
|
|
}
|
|
]
|
|
},
|
|
"config": {},
|
|
"extra": {
|
|
"ds": {
|
|
"scale": 0.8894351682943402,
|
|
"offset": [58.7671207025881, 137.7124650620126]
|
|
},
|
|
"frontendVersion": "1.24.1"
|
|
},
|
|
"version": 0.4
|
|
}
|