mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-22 05:19:03 +00:00
b059c22def
Backport of #12035 to `core/1.44` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-12337-backport-core-1-44-fix-keep-node-context-menu-overflow-visible-when-content-fits-3656d73d36508101b0d3ee3d2f699804) by [Unito](https://www.unito.io) Co-authored-by: Dante <bunggl@naver.com> Co-authored-by: GitHub Action <action@github.com>
66 lines
2.3 KiB
TypeScript
66 lines
2.3 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import type { ComfyPage } from '@e2e/fixtures/ComfyPage'
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
import { openMoreOptionsMenu } from '@e2e/fixtures/utils/selectionToolboxMoreOptions'
|
|
|
|
test.describe(
|
|
'Node context menu shape submenu (FE-570)',
|
|
{ tag: '@ui' },
|
|
() => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
await comfyPage.settings.setSetting('Comfy.Canvas.SelectionToolbox', true)
|
|
await comfyPage.workflow.loadWorkflow('nodes/single_ksampler')
|
|
})
|
|
|
|
async function expectShapePopoverVisible(comfyPage: ComfyPage) {
|
|
const popover = comfyPage.page
|
|
.locator('.p-popover')
|
|
.filter({ hasText: 'Default' })
|
|
await expect(popover).toBeVisible()
|
|
await expect(popover).toContainText('Box')
|
|
await expect(popover).toContainText('Card')
|
|
|
|
const popoverBox = await popover.boundingBox()
|
|
expect(popoverBox).not.toBeNull()
|
|
expect(popoverBox!.width).toBeGreaterThan(0)
|
|
expect(popoverBox!.height).toBeGreaterThan(0)
|
|
}
|
|
|
|
test('Shape popover opens when the menu fits in the viewport', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.page.setViewportSize({ width: 1280, height: 900 })
|
|
const menu = await openMoreOptionsMenu(comfyPage, 'KSampler')
|
|
const rootList = menu.locator(':scope > ul')
|
|
|
|
await expect
|
|
.poll(() => rootList.evaluate((el) => getComputedStyle(el).overflowY))
|
|
.toBe('visible')
|
|
|
|
await menu.getByRole('menuitem', { name: 'Shape' }).click()
|
|
await expectShapePopoverVisible(comfyPage)
|
|
})
|
|
|
|
test('Shape popover opens even when the menu must scroll', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.page.setViewportSize({ width: 1280, height: 520 })
|
|
const menu = await openMoreOptionsMenu(comfyPage, 'KSampler')
|
|
const rootList = menu.locator(':scope > ul')
|
|
|
|
await expect
|
|
.poll(() =>
|
|
rootList.evaluate((el) => el.scrollHeight > el.clientHeight)
|
|
)
|
|
.toBe(true)
|
|
|
|
const shapeItem = menu.getByRole('menuitem', { name: 'Shape' })
|
|
await shapeItem.scrollIntoViewIfNeeded()
|
|
await shapeItem.click()
|
|
await expectShapePopoverVisible(comfyPage)
|
|
})
|
|
}
|
|
)
|