mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-03-11 08:00:21 +00:00
## Summary
During workflow loading, the workflow data & active workflow object can
be out of sync, meaning any checkState calls will overwrite data into
the wrong workflow.
Recreation steps:
* Open 2-3 workflows
* Enter builder mode > select step
* Select some different inputs on each
* Quickly tap the shift key (this triggers checkState) while switching
tabs
* After a while, you'll see the wrong inputs on the workflows
Alternatively, register an extension that guarantees to call checkState
during the bad phase, run this in browser devtools and switch tabs:
```
window.app.registerExtension({
name: 'bad',
async afterConfigureGraph() {
window.app.extensionManager.workflow.activeWorkflow.changeTracker.checkState()
}
})
```
## Changes
- **What**:
- Add loading graph flag
- Prevent checkState calls while loading
- Prevent app mode data sync while loading
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-9531-fix-Prevent-corruption-of-workflow-data-due-to-checkState-during-graph-loading-31c6d73d365081e2ab91d9145bf1d025)
by [Unito](https://www.unito.io)
140 lines
4.0 KiB
TypeScript
140 lines
4.0 KiB
TypeScript
import { defineStore } from 'pinia'
|
|
import { reactive, computed, watch } from 'vue'
|
|
|
|
import { useEmptyWorkflowDialog } from '@/components/builder/useEmptyWorkflowDialog'
|
|
import { useAppMode } from '@/composables/useAppMode'
|
|
import type { NodeId } from '@/lib/litegraph/src/LGraphNode'
|
|
import type { LinearData } from '@/platform/workflow/management/stores/comfyWorkflow'
|
|
import { useCanvasStore } from '@/renderer/core/canvas/canvasStore'
|
|
import { useWorkflowStore } from '@/platform/workflow/management/stores/workflowStore'
|
|
import { useSidebarTabStore } from '@/stores/workspace/sidebarTabStore'
|
|
import { app } from '@/scripts/app'
|
|
import { ChangeTracker } from '@/scripts/changeTracker'
|
|
import { resolveNode } from '@/utils/litegraphUtil'
|
|
|
|
export const useAppModeStore = defineStore('appMode', () => {
|
|
const { getCanvas } = useCanvasStore()
|
|
const workflowStore = useWorkflowStore()
|
|
const { mode, setMode, isBuilderMode, isSelectMode } = useAppMode()
|
|
const emptyWorkflowDialog = useEmptyWorkflowDialog()
|
|
|
|
const selectedInputs = reactive<[NodeId, string][]>([])
|
|
const selectedOutputs = reactive<NodeId[]>([])
|
|
const hasOutputs = computed(() => !!selectedOutputs.length)
|
|
const hasNodes = computed(() => {
|
|
// Nodes are not reactive, so trigger recomputation when workflow changes
|
|
void workflowStore.activeWorkflow
|
|
void mode.value
|
|
return !!app.rootGraph?.nodes?.length
|
|
})
|
|
|
|
// Prune entries referencing nodes deleted in workflow mode.
|
|
// Only check node existence, not widgets — dynamic widgets can
|
|
// hide/show other widgets so a missing widget does not mean stale data.
|
|
function pruneLinearData(data: Partial<LinearData> | undefined): LinearData {
|
|
const rawInputs = data?.inputs ?? []
|
|
const rawOutputs = data?.outputs ?? []
|
|
|
|
return {
|
|
inputs: app.rootGraph
|
|
? rawInputs.filter(([nodeId]) => resolveNode(nodeId))
|
|
: rawInputs,
|
|
outputs: app.rootGraph
|
|
? rawOutputs.filter((nodeId) => resolveNode(nodeId))
|
|
: rawOutputs
|
|
}
|
|
}
|
|
|
|
function loadSelections(data: Partial<LinearData> | undefined) {
|
|
const { inputs, outputs } = pruneLinearData(data)
|
|
selectedInputs.splice(0, selectedInputs.length, ...inputs)
|
|
selectedOutputs.splice(0, selectedOutputs.length, ...outputs)
|
|
}
|
|
|
|
function resetSelectedToWorkflow() {
|
|
const { activeWorkflow } = workflowStore
|
|
if (!activeWorkflow) return
|
|
|
|
loadSelections(activeWorkflow.changeTracker?.activeState?.extra?.linearData)
|
|
}
|
|
|
|
watch(
|
|
() => workflowStore.activeWorkflow,
|
|
(newWorkflow) => {
|
|
if (newWorkflow) {
|
|
loadSelections(
|
|
newWorkflow.changeTracker?.activeState?.extra?.linearData
|
|
)
|
|
} else {
|
|
loadSelections(undefined)
|
|
}
|
|
},
|
|
{ immediate: true }
|
|
)
|
|
|
|
watch(
|
|
() =>
|
|
isBuilderMode.value
|
|
? { inputs: selectedInputs, outputs: selectedOutputs }
|
|
: null,
|
|
(data) => {
|
|
if (!data || ChangeTracker.isLoadingGraph) return
|
|
const graph = app.rootGraph
|
|
if (!graph) return
|
|
const extra = (graph.extra ??= {})
|
|
extra.linearData = {
|
|
inputs: [...data.inputs],
|
|
outputs: [...data.outputs]
|
|
}
|
|
},
|
|
{ deep: true }
|
|
)
|
|
|
|
let unwatch: () => void | undefined
|
|
watch(isSelectMode, (inSelect) => {
|
|
const { state } = getCanvas()
|
|
if (!state) return
|
|
state.readOnly = inSelect
|
|
unwatch?.()
|
|
if (inSelect)
|
|
unwatch = watch(
|
|
() => state.readOnly,
|
|
() => (state.readOnly = true)
|
|
)
|
|
})
|
|
|
|
function enterBuilder() {
|
|
if (!hasNodes.value) {
|
|
emptyWorkflowDialog.show({
|
|
onEnterBuilder: () => enterBuilder(),
|
|
onDismiss: () => setMode('graph')
|
|
})
|
|
return
|
|
}
|
|
|
|
useSidebarTabStore().activeSidebarTabId = null
|
|
|
|
setMode(
|
|
mode.value === 'app' && hasOutputs.value
|
|
? 'builder:arrange'
|
|
: 'builder:inputs'
|
|
)
|
|
}
|
|
|
|
function exitBuilder() {
|
|
resetSelectedToWorkflow()
|
|
setMode('graph')
|
|
}
|
|
|
|
return {
|
|
enterBuilder,
|
|
exitBuilder,
|
|
hasNodes,
|
|
hasOutputs,
|
|
pruneLinearData,
|
|
resetSelectedToWorkflow,
|
|
selectedInputs,
|
|
selectedOutputs
|
|
}
|
|
})
|