Files
ComfyUI_frontend/src/platform/nodeReplacement/missingNodeScan.test.ts
jaeone94 66daa6d645 refactor: error system cleanup — store separation, DDD fix, test improvements (#10302)
## Summary

Refactors the error system to improve separation of concerns, fix DDD
layer violations, and address code quality issues.

- Extract `missingNodesErrorStore` from `executionErrorStore`, removing
the delegation pattern that coupled missing-node logic into the
execution error store
- Extract `useNodeErrorFlagSync` composable for node error flag
reconciliation (previously inlined)
- Extract `useErrorClearingHooks` composable with explicit callback
cleanup on node removal
- Extract `useErrorActions` composable to deduplicate telemetry+command
patterns across error card components
- Move `getCnrIdFromNode`/`getCnrIdFromProperties` to
`platform/nodeReplacement` layer (DDD fix)
- Move `missingNodesErrorStore` to `platform/nodeReplacement` (DDD
alignment)
- Add unmount cancellation guard to `useErrorReport` async `onMounted`
- Return watch stop handle from `useNodeErrorFlagSync`
- Add `asyncResolvedIds` eviction on `missingNodesError` reset
- Add `console.warn` to silent catch blocks and empty array guard
- Hoist `useCommandStore` to setup scope, fix floating promises
- Add `data-testid` to error groups, image/video error spans, copy
button
- Update E2E tests to use scoped locators and testids
- Add unit tests for `onNodeRemoved` restoration and double-install
guard

Fixes #9875, Fixes #10027, Fixes #10033, Fixes #10085

## Test plan

- [x] Existing unit tests pass with updated imports and mocks
- [x] New unit tests for `useErrorClearingHooks` (callback restoration,
double-install guard)
- [x] E2E tests updated to use scoped locators and `data-testid`
- [ ] Manual: verify error tab shows runtime errors and missing nodes
correctly
- [ ] Manual: verify "Find on GitHub", "Copy", and "Get Help" buttons
work in error cards

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-10302-refactor-error-system-cleanup-store-separation-DDD-fix-test-improvements-3286d73d365081838279d045b8dd957a)
by [Unito](https://www.unito.io)

---------

Co-authored-by: GitHub Action <action@github.com>
2026-03-24 16:43:22 +09:00

233 lines
7.1 KiB
TypeScript

import { createPinia, setActivePinia } from 'pinia'
import { beforeEach, describe, expect, it, vi } from 'vitest'
import type { LGraph, LGraphNode } from '@/lib/litegraph/src/litegraph'
import { LiteGraph } from '@/lib/litegraph/src/litegraph'
vi.mock('@/lib/litegraph/src/litegraph', async (importOriginal) => {
const actual = await importOriginal<Record<string, unknown>>()
return {
...actual,
LiteGraph: {
...(actual.LiteGraph as Record<string, unknown>),
registered_node_types: {} as Record<string, unknown>
}
}
})
vi.mock('@/utils/graphTraversalUtil', () => ({
collectAllNodes: vi.fn(),
getExecutionIdByNode: vi.fn()
}))
vi.mock('@/platform/nodeReplacement/cnrIdUtil', () => ({
getCnrIdFromNode: vi.fn(() => undefined)
}))
vi.mock('@/i18n', () => ({
st: vi.fn((_key: string, fallback: string) => fallback)
}))
vi.mock('@/platform/distribution/types', () => ({
isCloud: false
}))
vi.mock('@/stores/settingStore', () => ({
useSettingStore: () => ({
get: vi.fn(() => true)
})
}))
vi.mock('@/platform/settings/settingStore', () => ({
useSettingStore: () => ({
get: vi.fn(() => true)
})
}))
import {
collectAllNodes,
getExecutionIdByNode
} from '@/utils/graphTraversalUtil'
import { getCnrIdFromNode } from '@/platform/nodeReplacement/cnrIdUtil'
import { useNodeReplacementStore } from '@/platform/nodeReplacement/nodeReplacementStore'
import { rescanAndSurfaceMissingNodes } from './missingNodeScan'
import { useMissingNodesErrorStore } from '@/platform/nodeReplacement/missingNodesErrorStore'
function mockNode(
id: number,
type: string,
overrides: Partial<LGraphNode> = {}
): LGraphNode {
return {
id,
type,
last_serialization: { type },
...overrides
} as unknown as LGraphNode
}
function mockGraph(): LGraph {
return {} as unknown as LGraph
}
function getMissingNodesError(
store: ReturnType<typeof useMissingNodesErrorStore>
) {
const error = store.missingNodesError
if (!error) throw new Error('Expected missingNodesError to be defined')
return error
}
describe('scanMissingNodes (via rescanAndSurfaceMissingNodes)', () => {
beforeEach(() => {
setActivePinia(createPinia())
vi.clearAllMocks()
// Reset registered_node_types
const reg = LiteGraph.registered_node_types as Record<string, unknown>
for (const key of Object.keys(reg)) {
delete reg[key]
}
})
it('returns empty when all nodes are registered', () => {
const reg = LiteGraph.registered_node_types as Record<string, unknown>
reg['KSampler'] = {}
vi.mocked(collectAllNodes).mockReturnValue([mockNode(1, 'KSampler')])
vi.mocked(getExecutionIdByNode).mockReturnValue(null)
rescanAndSurfaceMissingNodes(mockGraph())
const store = useMissingNodesErrorStore()
expect(store.missingNodesError).toBeNull()
})
it('detects unregistered nodes as missing', () => {
vi.mocked(collectAllNodes).mockReturnValue([
mockNode(1, 'OldNode'),
mockNode(2, 'AnotherOldNode')
])
vi.mocked(getExecutionIdByNode).mockReturnValue(null)
rescanAndSurfaceMissingNodes(mockGraph())
const store = useMissingNodesErrorStore()
const error = getMissingNodesError(store)
expect(error.nodeTypes).toHaveLength(2)
})
it('skips registered nodes and lists only unregistered', () => {
const reg = LiteGraph.registered_node_types as Record<string, unknown>
reg['RegisteredNode'] = {}
vi.mocked(collectAllNodes).mockReturnValue([
mockNode(1, 'RegisteredNode'),
mockNode(2, 'UnregisteredNode')
])
vi.mocked(getExecutionIdByNode).mockReturnValue(null)
rescanAndSurfaceMissingNodes(mockGraph())
const store = useMissingNodesErrorStore()
const error = getMissingNodesError(store)
expect(error.nodeTypes).toHaveLength(1)
const missing = error.nodeTypes[0]
expect(typeof missing !== 'string' && missing.type).toBe('UnregisteredNode')
})
it('uses executionId when available for nodeId', () => {
vi.mocked(collectAllNodes).mockReturnValue([mockNode(1, 'Missing')])
vi.mocked(getExecutionIdByNode).mockReturnValue('exec-42')
rescanAndSurfaceMissingNodes(mockGraph())
const store = useMissingNodesErrorStore()
const error = getMissingNodesError(store)
const missing = error.nodeTypes[0]
expect(typeof missing !== 'string' && missing.nodeId).toBe('exec-42')
})
it('falls back to node.id when executionId is null', () => {
vi.mocked(collectAllNodes).mockReturnValue([mockNode(99, 'Missing')])
vi.mocked(getExecutionIdByNode).mockReturnValue(null)
rescanAndSurfaceMissingNodes(mockGraph())
const store = useMissingNodesErrorStore()
const error = getMissingNodesError(store)
const missing = error.nodeTypes[0]
expect(typeof missing !== 'string' && missing.nodeId).toBe('99')
})
it('populates cnrId from getCnrIdFromNode', () => {
vi.mocked(collectAllNodes).mockReturnValue([mockNode(1, 'Missing')])
vi.mocked(getExecutionIdByNode).mockReturnValue(null)
vi.mocked(getCnrIdFromNode).mockReturnValue('comfy-nodes/my-pack')
rescanAndSurfaceMissingNodes(mockGraph())
const store = useMissingNodesErrorStore()
const error = getMissingNodesError(store)
const missing = error.nodeTypes[0]
expect(typeof missing !== 'string' && missing.cnrId).toBe(
'comfy-nodes/my-pack'
)
})
it('marks node as replaceable when replacement exists', () => {
vi.mocked(collectAllNodes).mockReturnValue([mockNode(1, 'OldNode')])
vi.mocked(getExecutionIdByNode).mockReturnValue(null)
const replacementStore = useNodeReplacementStore()
replacementStore.replacements = {
OldNode: [
{
old_node_id: 'OldNode',
new_node_id: 'NewNode',
old_widget_ids: null,
input_mapping: null,
output_mapping: null
}
]
}
rescanAndSurfaceMissingNodes(mockGraph())
const store = useMissingNodesErrorStore()
const error = getMissingNodesError(store)
const missing = error.nodeTypes[0]
expect(typeof missing !== 'string' && missing.isReplaceable).toBe(true)
expect(
typeof missing !== 'string' && missing.replacement?.new_node_id
).toBe('NewNode')
})
it('marks node as not replaceable when no replacement', () => {
vi.mocked(collectAllNodes).mockReturnValue([mockNode(1, 'OldNode')])
vi.mocked(getExecutionIdByNode).mockReturnValue(null)
rescanAndSurfaceMissingNodes(mockGraph())
const store = useMissingNodesErrorStore()
const error = getMissingNodesError(store)
const missing = error.nodeTypes[0]
expect(typeof missing !== 'string' && missing.isReplaceable).toBe(false)
})
it('uses last_serialization.type over node.type', () => {
const node = mockNode(1, 'LiveType')
node.last_serialization = {
type: 'OriginalType'
} as unknown as LGraphNode['last_serialization']
vi.mocked(collectAllNodes).mockReturnValue([node])
vi.mocked(getExecutionIdByNode).mockReturnValue(null)
rescanAndSurfaceMissingNodes(mockGraph())
const store = useMissingNodesErrorStore()
const error = getMissingNodesError(store)
const missing = error.nodeTypes[0]
expect(typeof missing !== 'string' && missing.type).toBe('OriginalType')
})
})