mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-11 08:20:53 +00:00
## Summary Rename `useFirebaseAuthStore` → `useAuthStore` and `FirebaseAuthStoreError` → `AuthStoreError`. Introduce shared mock factory (`authStoreMock.ts`) to replace 16 independent bespoke mocks. ## Changes - **What**: Mechanical rename of store, composable, class, and store ID (`firebaseAuth` → `auth`). Created `src/stores/__tests__/authStoreMock.ts` — a shared mock factory with reactive controls, used by all consuming test files. Migrated all 16 test files from ad-hoc mocks to the shared factory. - **Files**: 62 files changed (rename propagation + new test infra) ## Review Focus - Mock factory API design in `authStoreMock.ts` — covers all store properties with reactive `controls` for per-test customization - Self-test in `authStoreMock.test.ts` validates computed reactivity Fixes #8219 ## Stack This is PR 1/5 in a stacked refactoring series: 1. **→ This PR**: Rename + shared test fixtures 2. #10484: Extract auth-routing from workspaceApi 3. #10485: Auth token priority tests 4. #10486: Decompose MembersPanelContent 5. #10487: Consolidate SubscriptionTier type --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
486 lines
14 KiB
TypeScript
486 lines
14 KiB
TypeScript
import { createPinia, setActivePinia } from 'pinia'
|
|
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
import { ref } from 'vue'
|
|
|
|
import { useCoreCommands } from '@/composables/useCoreCommands'
|
|
import type { LGraphNode } from '@/lib/litegraph/src/litegraph'
|
|
import { useSettingStore } from '@/platform/settings/settingStore'
|
|
import { api } from '@/scripts/api'
|
|
import { app } from '@/scripts/app'
|
|
import { createMockLGraphNode } from '@/utils/__tests__/litegraphTestUtils'
|
|
|
|
// Mock vue-i18n for useExternalLink
|
|
const mockLocale = ref('en')
|
|
vi.mock('vue-i18n', async () => {
|
|
const actual = await vi.importActual('vue-i18n')
|
|
return {
|
|
...actual,
|
|
useI18n: vi.fn(() => ({
|
|
locale: mockLocale
|
|
}))
|
|
}
|
|
})
|
|
|
|
vi.mock('@/scripts/app', () => {
|
|
const mockGraphClear = vi.fn()
|
|
const mockCanvas = {
|
|
subgraph: undefined,
|
|
selectedItems: new Set(),
|
|
copyToClipboard: vi.fn(),
|
|
pasteFromClipboard: vi.fn(),
|
|
selectItems: vi.fn()
|
|
}
|
|
|
|
return {
|
|
app: {
|
|
clean: vi.fn(() => {
|
|
// Simulate app.clean() calling graph.clear() only when not in subgraph
|
|
if (!mockCanvas.subgraph) {
|
|
mockGraphClear()
|
|
}
|
|
}),
|
|
canvas: mockCanvas,
|
|
rootGraph: {
|
|
clear: mockGraphClear
|
|
}
|
|
}
|
|
}
|
|
})
|
|
|
|
vi.mock('@/scripts/api', () => ({
|
|
api: {
|
|
dispatchCustomEvent: vi.fn(),
|
|
apiURL: vi.fn(() => 'http://localhost:8188')
|
|
}
|
|
}))
|
|
|
|
vi.mock('@/platform/settings/settingStore')
|
|
|
|
vi.mock('@/stores/authStore', () => ({
|
|
useAuthStore: vi.fn(() => ({}))
|
|
}))
|
|
|
|
vi.mock('@/composables/auth/useFirebaseAuth', () => ({
|
|
useFirebaseAuth: vi.fn(() => null)
|
|
}))
|
|
|
|
vi.mock('firebase/auth', () => ({
|
|
setPersistence: vi.fn(),
|
|
browserLocalPersistence: {},
|
|
onAuthStateChanged: vi.fn()
|
|
}))
|
|
|
|
vi.mock('@/platform/workflow/core/services/workflowService', () => ({
|
|
useWorkflowService: vi.fn(() => ({}))
|
|
}))
|
|
|
|
const mockDialogService = vi.hoisted(() => ({
|
|
prompt: vi.fn()
|
|
}))
|
|
vi.mock('@/services/dialogService', () => ({
|
|
useDialogService: vi.fn(() => mockDialogService)
|
|
}))
|
|
|
|
vi.mock('@/services/litegraphService', () => ({
|
|
useLitegraphService: vi.fn(() => ({}))
|
|
}))
|
|
|
|
vi.mock('@/stores/executionStore', () => ({
|
|
useExecutionStore: vi.fn(() => ({}))
|
|
}))
|
|
|
|
vi.mock('@/stores/toastStore', () => ({
|
|
useToastStore: vi.fn(() => ({}))
|
|
}))
|
|
|
|
const mockChangeTracker = vi.hoisted(() => ({
|
|
checkState: vi.fn()
|
|
}))
|
|
const mockWorkflowStore = vi.hoisted(() => ({
|
|
activeWorkflow: {
|
|
changeTracker: mockChangeTracker
|
|
}
|
|
}))
|
|
vi.mock('@/platform/workflow/management/stores/workflowStore', () => ({
|
|
useWorkflowStore: vi.fn(() => mockWorkflowStore)
|
|
}))
|
|
|
|
vi.mock('@/stores/subgraphStore', () => ({
|
|
useSubgraphStore: vi.fn(() => ({}))
|
|
}))
|
|
|
|
vi.mock('@/renderer/core/canvas/canvasStore', () => ({
|
|
useCanvasStore: vi.fn(() => ({
|
|
getCanvas: () => app.canvas,
|
|
canvas: app.canvas
|
|
})),
|
|
useTitleEditorStore: vi.fn(() => ({
|
|
titleEditorTarget: null
|
|
}))
|
|
}))
|
|
|
|
vi.mock('@/stores/workspace/colorPaletteStore', () => ({
|
|
useColorPaletteStore: vi.fn(() => ({}))
|
|
}))
|
|
|
|
vi.mock('@/composables/auth/useAuthActions', () => ({
|
|
useAuthActions: vi.fn(() => ({}))
|
|
}))
|
|
|
|
vi.mock('@/platform/cloud/subscription/composables/useSubscription', () => ({
|
|
useSubscription: vi.fn(() => ({
|
|
isActiveSubscription: vi.fn().mockReturnValue(true),
|
|
showSubscriptionDialog: vi.fn()
|
|
}))
|
|
}))
|
|
|
|
vi.mock('@/composables/billing/useBillingContext', () => ({
|
|
useBillingContext: vi.fn(() => ({
|
|
isActiveSubscription: { value: true },
|
|
showSubscriptionDialog: vi.fn()
|
|
}))
|
|
}))
|
|
|
|
describe('useCoreCommands', () => {
|
|
const createMockNode = (id: number, comfyClass: string): LGraphNode => {
|
|
const baseNode = createMockLGraphNode({ id })
|
|
return Object.assign(baseNode, {
|
|
constructor: {
|
|
...baseNode.constructor,
|
|
comfyClass
|
|
}
|
|
})
|
|
}
|
|
|
|
const createMockSubgraph = () => {
|
|
const mockNodes = [
|
|
// Mock input node
|
|
createMockNode(1, 'SubgraphInputNode'),
|
|
// Mock output node
|
|
createMockNode(2, 'SubgraphOutputNode'),
|
|
// Mock user node
|
|
createMockNode(3, 'SomeUserNode'),
|
|
// Another mock user node
|
|
createMockNode(4, 'AnotherUserNode')
|
|
]
|
|
|
|
return {
|
|
nodes: mockNodes,
|
|
remove: vi.fn(),
|
|
events: {
|
|
dispatch: vi.fn(),
|
|
addEventListener: vi.fn(),
|
|
removeEventListener: vi.fn(),
|
|
dispatchEvent: vi.fn()
|
|
},
|
|
name: 'test-subgraph',
|
|
inputNode: undefined,
|
|
outputNode: undefined,
|
|
add: vi.fn(),
|
|
clear: vi.fn(),
|
|
serialize: vi.fn(),
|
|
configure: vi.fn(),
|
|
start: vi.fn(),
|
|
stop: vi.fn(),
|
|
runStep: vi.fn(),
|
|
findNodeByTitle: vi.fn(),
|
|
findNodesByTitle: vi.fn(),
|
|
findNodesByType: vi.fn(),
|
|
findNodeById: vi.fn(),
|
|
getNodeById: vi.fn(),
|
|
setDirtyCanvas: vi.fn(),
|
|
sendActionToCanvas: vi.fn(),
|
|
extra: {} as Record<string, unknown>
|
|
} as Partial<typeof app.canvas.subgraph> as typeof app.canvas.subgraph
|
|
}
|
|
|
|
const mockSubgraph = createMockSubgraph()!
|
|
|
|
function createMockSettingStore(
|
|
getReturnValue: boolean
|
|
): ReturnType<typeof useSettingStore> {
|
|
return {
|
|
get: vi.fn().mockReturnValue(getReturnValue),
|
|
addSetting: vi.fn(),
|
|
load: vi.fn(),
|
|
set: vi.fn(),
|
|
setMany: vi.fn(),
|
|
exists: vi.fn(),
|
|
getDefaultValue: vi.fn(),
|
|
isReady: true,
|
|
isLoading: false,
|
|
error: undefined,
|
|
settingValues: {},
|
|
settingsById: {},
|
|
$id: 'setting',
|
|
$state: {
|
|
settingValues: {},
|
|
settingsById: {},
|
|
isReady: true,
|
|
isLoading: false,
|
|
error: undefined
|
|
},
|
|
$patch: vi.fn(),
|
|
$reset: vi.fn(),
|
|
$subscribe: vi.fn(),
|
|
$onAction: vi.fn(),
|
|
$dispose: vi.fn(),
|
|
_customProperties: new Set()
|
|
} satisfies ReturnType<typeof useSettingStore>
|
|
}
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
|
|
// Set up Pinia
|
|
setActivePinia(createPinia())
|
|
|
|
// Reset app state
|
|
app.canvas.subgraph = undefined
|
|
|
|
// Mock settings store
|
|
vi.mocked(useSettingStore).mockReturnValue(createMockSettingStore(false))
|
|
|
|
// Mock global confirm
|
|
global.confirm = vi.fn().mockReturnValue(true)
|
|
})
|
|
|
|
describe('ClearWorkflow command', () => {
|
|
it('should clear main graph when not in subgraph', async () => {
|
|
const commands = useCoreCommands()
|
|
const clearCommand = commands.find(
|
|
(cmd) => cmd.id === 'Comfy.ClearWorkflow'
|
|
)!
|
|
|
|
// Execute the command
|
|
await clearCommand.function()
|
|
|
|
expect(app.clean).toHaveBeenCalled()
|
|
expect(app.rootGraph.clear).toHaveBeenCalled()
|
|
expect(api.dispatchCustomEvent).toHaveBeenCalledWith('graphCleared')
|
|
})
|
|
|
|
it('should preserve input/output nodes when clearing subgraph', async () => {
|
|
// Set up subgraph context
|
|
app.canvas.subgraph = mockSubgraph
|
|
|
|
const commands = useCoreCommands()
|
|
const clearCommand = commands.find(
|
|
(cmd) => cmd.id === 'Comfy.ClearWorkflow'
|
|
)!
|
|
|
|
// Execute the command
|
|
await clearCommand.function()
|
|
|
|
expect(app.clean).toHaveBeenCalled()
|
|
expect(app.rootGraph.clear).not.toHaveBeenCalled()
|
|
|
|
// Should only remove user nodes, not input/output nodes
|
|
const subgraph = app.canvas.subgraph!
|
|
expect(subgraph.remove).toHaveBeenCalledTimes(2)
|
|
expect(subgraph.remove).toHaveBeenCalledWith(subgraph.nodes[2]) // user1
|
|
expect(subgraph.remove).toHaveBeenCalledWith(subgraph.nodes[3]) // user2
|
|
expect(subgraph.remove).not.toHaveBeenCalledWith(subgraph.nodes[0]) // input1
|
|
expect(subgraph.remove).not.toHaveBeenCalledWith(subgraph.nodes[1]) // output1
|
|
|
|
expect(api.dispatchCustomEvent).toHaveBeenCalledWith('graphCleared')
|
|
})
|
|
|
|
it('should respect confirmation setting', async () => {
|
|
// Mock confirmation required
|
|
vi.mocked(useSettingStore).mockReturnValue(createMockSettingStore(true))
|
|
|
|
global.confirm = vi.fn().mockReturnValue(false) // User cancels
|
|
|
|
const commands = useCoreCommands()
|
|
const clearCommand = commands.find(
|
|
(cmd) => cmd.id === 'Comfy.ClearWorkflow'
|
|
)!
|
|
|
|
// Execute the command
|
|
await clearCommand.function()
|
|
|
|
// Should not clear anything when user cancels
|
|
expect(app.clean).not.toHaveBeenCalled()
|
|
expect(app.rootGraph.clear).not.toHaveBeenCalled()
|
|
expect(api.dispatchCustomEvent).not.toHaveBeenCalled()
|
|
})
|
|
})
|
|
|
|
describe('Canvas clipboard commands', () => {
|
|
function findCommand(id: string) {
|
|
return useCoreCommands().find((cmd) => cmd.id === id)!
|
|
}
|
|
|
|
beforeEach(() => {
|
|
app.canvas.selectedItems = new Set()
|
|
vi.mocked(app.canvas.copyToClipboard).mockClear()
|
|
vi.mocked(app.canvas.pasteFromClipboard).mockClear()
|
|
vi.mocked(app.canvas.selectItems).mockClear()
|
|
})
|
|
|
|
it('should copy selected items when selection exists', async () => {
|
|
app.canvas.selectedItems = new Set([
|
|
{}
|
|
]) as typeof app.canvas.selectedItems
|
|
|
|
await findCommand('Comfy.Canvas.CopySelected').function()
|
|
|
|
expect(app.canvas.copyToClipboard).toHaveBeenCalledWith()
|
|
})
|
|
|
|
it('should not copy when no items are selected', async () => {
|
|
await findCommand('Comfy.Canvas.CopySelected').function()
|
|
|
|
expect(app.canvas.copyToClipboard).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('should paste from clipboard', async () => {
|
|
await findCommand('Comfy.Canvas.PasteFromClipboard').function()
|
|
|
|
expect(app.canvas.pasteFromClipboard).toHaveBeenCalledWith()
|
|
})
|
|
|
|
it('should select all items', async () => {
|
|
await findCommand('Comfy.Canvas.SelectAll').function()
|
|
|
|
// No arguments means "select all items on canvas"
|
|
expect(app.canvas.selectItems).toHaveBeenCalledWith()
|
|
})
|
|
})
|
|
|
|
describe('Subgraph metadata commands', () => {
|
|
beforeEach(() => {
|
|
mockSubgraph.extra = {}
|
|
vi.clearAllMocks()
|
|
})
|
|
|
|
describe('SetDescription command', () => {
|
|
it('should do nothing when not in subgraph', async () => {
|
|
app.canvas.subgraph = undefined
|
|
|
|
const commands = useCoreCommands()
|
|
const setDescCommand = commands.find(
|
|
(cmd) => cmd.id === 'Comfy.Subgraph.SetDescription'
|
|
)!
|
|
|
|
await setDescCommand.function()
|
|
|
|
expect(mockDialogService.prompt).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('should set description on subgraph.extra', async () => {
|
|
app.canvas.subgraph = mockSubgraph
|
|
mockDialogService.prompt.mockResolvedValue('Test description')
|
|
|
|
const commands = useCoreCommands()
|
|
const setDescCommand = commands.find(
|
|
(cmd) => cmd.id === 'Comfy.Subgraph.SetDescription'
|
|
)!
|
|
|
|
await setDescCommand.function()
|
|
|
|
expect(mockDialogService.prompt).toHaveBeenCalled()
|
|
expect(mockSubgraph.extra.BlueprintDescription).toBe('Test description')
|
|
expect(mockChangeTracker.checkState).toHaveBeenCalled()
|
|
})
|
|
|
|
it('should not set description when user cancels', async () => {
|
|
app.canvas.subgraph = mockSubgraph
|
|
mockDialogService.prompt.mockResolvedValue(null)
|
|
|
|
const commands = useCoreCommands()
|
|
const setDescCommand = commands.find(
|
|
(cmd) => cmd.id === 'Comfy.Subgraph.SetDescription'
|
|
)!
|
|
|
|
await setDescCommand.function()
|
|
|
|
expect(mockSubgraph.extra.BlueprintDescription).toBeUndefined()
|
|
expect(mockChangeTracker.checkState).not.toHaveBeenCalled()
|
|
})
|
|
})
|
|
|
|
describe('SetSearchAliases command', () => {
|
|
it('should do nothing when not in subgraph', async () => {
|
|
app.canvas.subgraph = undefined
|
|
|
|
const commands = useCoreCommands()
|
|
const setAliasesCommand = commands.find(
|
|
(cmd) => cmd.id === 'Comfy.Subgraph.SetSearchAliases'
|
|
)!
|
|
|
|
await setAliasesCommand.function()
|
|
|
|
expect(mockDialogService.prompt).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('should set search aliases on subgraph.extra', async () => {
|
|
app.canvas.subgraph = mockSubgraph
|
|
mockDialogService.prompt.mockResolvedValue('alias1, alias2, alias3')
|
|
|
|
const commands = useCoreCommands()
|
|
const setAliasesCommand = commands.find(
|
|
(cmd) => cmd.id === 'Comfy.Subgraph.SetSearchAliases'
|
|
)!
|
|
|
|
await setAliasesCommand.function()
|
|
|
|
expect(mockDialogService.prompt).toHaveBeenCalled()
|
|
expect(mockSubgraph.extra.BlueprintSearchAliases).toEqual([
|
|
'alias1',
|
|
'alias2',
|
|
'alias3'
|
|
])
|
|
expect(mockChangeTracker.checkState).toHaveBeenCalled()
|
|
})
|
|
|
|
it('should trim whitespace and filter empty strings', async () => {
|
|
app.canvas.subgraph = mockSubgraph
|
|
mockDialogService.prompt.mockResolvedValue(' alias1 , , alias2 , ')
|
|
|
|
const commands = useCoreCommands()
|
|
const setAliasesCommand = commands.find(
|
|
(cmd) => cmd.id === 'Comfy.Subgraph.SetSearchAliases'
|
|
)!
|
|
|
|
await setAliasesCommand.function()
|
|
|
|
expect(mockSubgraph.extra.BlueprintSearchAliases).toEqual([
|
|
'alias1',
|
|
'alias2'
|
|
])
|
|
})
|
|
|
|
it('should set undefined when empty input', async () => {
|
|
app.canvas.subgraph = mockSubgraph
|
|
mockDialogService.prompt.mockResolvedValue('')
|
|
|
|
const commands = useCoreCommands()
|
|
const setAliasesCommand = commands.find(
|
|
(cmd) => cmd.id === 'Comfy.Subgraph.SetSearchAliases'
|
|
)!
|
|
|
|
await setAliasesCommand.function()
|
|
|
|
expect(mockSubgraph.extra.BlueprintSearchAliases).toBeUndefined()
|
|
})
|
|
|
|
it('should not set aliases when user cancels', async () => {
|
|
app.canvas.subgraph = mockSubgraph
|
|
mockDialogService.prompt.mockResolvedValue(null)
|
|
|
|
const commands = useCoreCommands()
|
|
const setAliasesCommand = commands.find(
|
|
(cmd) => cmd.id === 'Comfy.Subgraph.SetSearchAliases'
|
|
)!
|
|
|
|
await setAliasesCommand.function()
|
|
|
|
expect(mockSubgraph.extra.BlueprintSearchAliases).toBeUndefined()
|
|
expect(mockChangeTracker.checkState).not.toHaveBeenCalled()
|
|
})
|
|
})
|
|
})
|
|
})
|