mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 06:20:11 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
58 lines
1.8 KiB
TypeScript
58 lines
1.8 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
import type { Locator } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
|
|
async function verifyCustomIconSvg(iconElement: Locator) {
|
|
const svgVariable = await iconElement.evaluate((element) => {
|
|
const styles = getComputedStyle(element)
|
|
return styles.getPropertyValue('--svg')
|
|
})
|
|
|
|
expect(svgVariable).toBeTruthy()
|
|
const dataUrlMatch = svgVariable.match(
|
|
/url\("data:image\/svg\+xml,([^"]+)"\)/
|
|
)
|
|
expect(dataUrlMatch).toBeTruthy()
|
|
|
|
const encodedSvg = dataUrlMatch![1]
|
|
const decodedSvg = decodeURIComponent(encodedSvg)
|
|
|
|
// Check for SVG header to confirm it's a valid SVG
|
|
expect(decodedSvg).toContain("<svg xmlns='http://www.w3.org/2000/svg'")
|
|
}
|
|
|
|
test.describe('Custom Icons', { tag: '@settings' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
})
|
|
|
|
test('sidebar tab icons use custom SVGs', async ({ comfyPage }) => {
|
|
// Find the icon in the sidebar
|
|
const icon = comfyPage.page.locator(
|
|
'.icon-\\[comfy--ai-model\\].side-bar-button-icon'
|
|
)
|
|
await expect(icon).toBeVisible()
|
|
|
|
// Verify the custom SVG content
|
|
await verifyCustomIconSvg(icon)
|
|
})
|
|
|
|
test('Browse Templates menu item uses custom template icon', async ({
|
|
comfyPage
|
|
}) => {
|
|
// Open the topbar menu
|
|
await comfyPage.menu.topbar.openTopbarMenu()
|
|
const menuItem = comfyPage.menu.topbar.getMenuItem('Browse Templates')
|
|
|
|
// Find the icon as a previous sibling of the menu item label
|
|
const templateIcon = menuItem
|
|
.locator('..')
|
|
.locator('.icon-\\[comfy--template\\]')
|
|
await expect(templateIcon).toBeVisible()
|
|
|
|
// Verify the custom SVG content
|
|
await verifyCustomIconSvg(templateIcon)
|
|
})
|
|
})
|