mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
95 lines
3.1 KiB
TypeScript
95 lines
3.1 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
import { SignInDialog } from '@e2e/fixtures/components/SignInDialog'
|
|
|
|
test.describe('Sign In dialog', { tag: '@ui' }, () => {
|
|
let dialog: SignInDialog
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
dialog = new SignInDialog(comfyPage.page)
|
|
await dialog.open()
|
|
})
|
|
|
|
test('Should open and show the sign-in form by default', async () => {
|
|
await expect(
|
|
dialog.root.getByRole('heading', { name: 'Log in to your account' })
|
|
).toBeVisible()
|
|
await expect(dialog.emailInput).toBeVisible()
|
|
await expect(dialog.passwordInput).toBeVisible()
|
|
await expect(dialog.signInButton).toBeVisible()
|
|
})
|
|
|
|
test('Should toggle from sign-in to sign-up form', async () => {
|
|
await dialog.signUpLink.click()
|
|
|
|
await expect(
|
|
dialog.root.getByRole('heading', { name: 'Create an account' })
|
|
).toBeVisible()
|
|
await expect(dialog.signUpEmailInput).toBeVisible()
|
|
await expect(dialog.signUpPasswordInput).toBeVisible()
|
|
await expect(dialog.signUpConfirmPasswordInput).toBeVisible()
|
|
await expect(dialog.signUpButton).toBeVisible()
|
|
})
|
|
|
|
test('Should toggle back from sign-up to sign-in form', async () => {
|
|
await dialog.signUpLink.click()
|
|
await expect(
|
|
dialog.root.getByRole('heading', { name: 'Create an account' })
|
|
).toBeVisible()
|
|
|
|
await dialog.signInLink.click()
|
|
await expect(
|
|
dialog.root.getByRole('heading', { name: 'Log in to your account' })
|
|
).toBeVisible()
|
|
await expect(dialog.emailInput).toBeVisible()
|
|
await expect(dialog.passwordInput).toBeVisible()
|
|
})
|
|
|
|
test('Should navigate to the API Key form and back', async () => {
|
|
await dialog.apiKeyButton.click()
|
|
|
|
await expect(dialog.apiKeyHeading).toBeVisible()
|
|
await expect(dialog.apiKeyInput).toBeVisible()
|
|
|
|
await dialog.backButton.click()
|
|
await expect(
|
|
dialog.root.getByRole('heading', { name: 'Log in to your account' })
|
|
).toBeVisible()
|
|
})
|
|
|
|
test('Should display Terms of Service and Privacy Policy links', async () => {
|
|
await expect(dialog.termsLink).toBeVisible()
|
|
await expect(dialog.termsLink).toHaveAttribute(
|
|
'href',
|
|
'https://www.comfy.org/terms-of-service'
|
|
)
|
|
|
|
await expect(dialog.privacyLink).toBeVisible()
|
|
await expect(dialog.privacyLink).toHaveAttribute(
|
|
'href',
|
|
'https://www.comfy.org/privacy'
|
|
)
|
|
})
|
|
|
|
test('Should display the "Or continue with" divider and API key button', async () => {
|
|
await expect(dialog.dividerText).toBeVisible()
|
|
await expect(dialog.apiKeyButton).toBeVisible()
|
|
})
|
|
|
|
test('Should show forgot password link on sign-in form', async () => {
|
|
await expect(dialog.forgotPasswordLink).toBeVisible()
|
|
})
|
|
|
|
test('Should close dialog via close button', async () => {
|
|
await dialog.closeButton.click()
|
|
await expect(dialog.root).toBeHidden()
|
|
})
|
|
|
|
test('Should close dialog via Escape key', async ({ comfyPage }) => {
|
|
await comfyPage.page.keyboard.press('Escape')
|
|
await expect(dialog.root).toBeHidden()
|
|
})
|
|
})
|