mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
57 lines
1.7 KiB
TypeScript
57 lines
1.7 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
})
|
|
|
|
test.describe('Keybindings', { tag: '@keyboard' }, () => {
|
|
test('Should not trigger non-modifier keybinding when typing in input fields', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.command.registerKeybinding({ key: 'k' }, () => {
|
|
window.TestCommand = true
|
|
})
|
|
|
|
const textBox = comfyPage.widgetTextBox
|
|
await textBox.click()
|
|
await textBox.fill('k')
|
|
await expect(textBox).toHaveValue('k')
|
|
expect(await comfyPage.page.evaluate(() => window.TestCommand)).toBe(
|
|
undefined
|
|
)
|
|
})
|
|
|
|
test('Should not trigger modifier keybinding when typing in input fields', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.command.registerKeybinding({ key: 'k', ctrl: true }, () => {
|
|
window.TestCommand = true
|
|
})
|
|
|
|
const textBox = comfyPage.widgetTextBox
|
|
await textBox.click()
|
|
await textBox.fill('q')
|
|
await textBox.press('Control+k')
|
|
await expect(textBox).toHaveValue('q')
|
|
expect(await comfyPage.page.evaluate(() => window.TestCommand)).toBe(true)
|
|
})
|
|
|
|
test('Should not trigger keybinding reserved by text input when typing in input fields', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.command.registerKeybinding({ key: 'Ctrl+v' }, () => {
|
|
window.TestCommand = true
|
|
})
|
|
|
|
const textBox = comfyPage.widgetTextBox
|
|
await textBox.click()
|
|
await textBox.press('Control+v')
|
|
await expect(textBox).toBeFocused()
|
|
expect(await comfyPage.page.evaluate(() => window.TestCommand)).toBe(
|
|
undefined
|
|
)
|
|
})
|
|
})
|