mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 06:20:11 +00:00
## Summary Add 30 E2E tests across 5 spec files covering medium-impact UI interactions: node search V2, bottom panel logs, focus mode, job history actions, and right side panel tabs. ## Tests | Spec file | Tests | Coverage | |---|---|---| | `nodeSearchBoxV2Extended.spec.ts` | 6 | V2 search filtering, keyboard navigation, category display | | `bottomPanelLogs.spec.ts` | 6 | Bottom panel toggle, logs tab, xterm terminal rendering | | `focusMode.spec.ts` | 6 | Focus mode hide/show UI chrome, sidebar/menu visibility | | `jobHistoryActions.spec.ts` | 6 | More options popover, docked history panel, queue interactions | | `rightSidePanelTabs.spec.ts` | 6 | Properties panel, node details, search from side panel | ## Review Focus - Bottom panel logs tests interact with xterm.js — the approach uses terminal container visibility rather than text content assertions. Is this the right level of testing? - Focus mode tests verify UI element hiding — they check element count/visibility rather than visual regression. Appropriate? ## Stack Depends on #9554 for FeatureFlagHelper/QueueHelper infrastructure. - #9554: Test infrastructure helpers - #9555: Toasts, error overlay, selection toolbox, linear mode, selection rectangle - **→ This PR**: Node search, bottom panel, focus mode, job history, side panel - #9557: Errors tab, node headers, queue notifications, settings sidebar - #9558: Minimap, widget copy, floating menus, node library essentials
144 lines
4.9 KiB
TypeScript
144 lines
4.9 KiB
TypeScript
import {
|
|
comfyExpect as expect,
|
|
comfyPageFixture as test
|
|
} from '../fixtures/ComfyPage'
|
|
|
|
test.describe('Node search box V2 extended', { tag: '@node' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
await comfyPage.settings.setSetting('Comfy.NodeSearchBoxImpl', 'default')
|
|
await comfyPage.settings.setSetting(
|
|
'Comfy.LinkRelease.Action',
|
|
'search box'
|
|
)
|
|
await comfyPage.settings.setSetting(
|
|
'Comfy.LinkRelease.ActionShift',
|
|
'search box'
|
|
)
|
|
await comfyPage.searchBoxV2.reload(comfyPage)
|
|
})
|
|
|
|
test('Double-click on empty canvas opens search', async ({ comfyPage }) => {
|
|
const { searchBoxV2 } = comfyPage
|
|
|
|
await comfyPage.canvasOps.doubleClick()
|
|
await expect(searchBoxV2.input).toBeVisible()
|
|
await expect(searchBoxV2.dialog).toBeVisible()
|
|
})
|
|
|
|
test('Escape closes search box without adding node', async ({
|
|
comfyPage
|
|
}) => {
|
|
const { searchBoxV2 } = comfyPage
|
|
const initialCount = await comfyPage.nodeOps.getGraphNodesCount()
|
|
|
|
await comfyPage.canvasOps.doubleClick()
|
|
await expect(searchBoxV2.input).toBeVisible()
|
|
|
|
await searchBoxV2.input.fill('KSampler')
|
|
await expect(searchBoxV2.results.first()).toBeVisible()
|
|
|
|
await comfyPage.page.keyboard.press('Escape')
|
|
await expect(searchBoxV2.input).not.toBeVisible()
|
|
|
|
const newCount = await comfyPage.nodeOps.getGraphNodesCount()
|
|
expect(newCount).toBe(initialCount)
|
|
})
|
|
|
|
test('Search clears when reopening', async ({ comfyPage }) => {
|
|
const { searchBoxV2 } = comfyPage
|
|
|
|
await comfyPage.canvasOps.doubleClick()
|
|
await expect(searchBoxV2.input).toBeVisible()
|
|
|
|
await searchBoxV2.input.fill('KSampler')
|
|
await expect(searchBoxV2.results.first()).toBeVisible()
|
|
|
|
await comfyPage.page.keyboard.press('Escape')
|
|
await expect(searchBoxV2.input).not.toBeVisible()
|
|
|
|
await comfyPage.canvasOps.doubleClick()
|
|
await expect(searchBoxV2.input).toBeVisible()
|
|
await expect(searchBoxV2.input).toHaveValue('')
|
|
})
|
|
|
|
test.describe('Category navigation', () => {
|
|
test('Category navigation updates results', async ({ comfyPage }) => {
|
|
const { searchBoxV2 } = comfyPage
|
|
|
|
await comfyPage.canvasOps.doubleClick()
|
|
await expect(searchBoxV2.input).toBeVisible()
|
|
|
|
await searchBoxV2.categoryButton('sampling').click()
|
|
await expect(searchBoxV2.results.first()).toBeVisible()
|
|
const samplingResults = await searchBoxV2.results.allTextContents()
|
|
|
|
await searchBoxV2.categoryButton('loaders').click()
|
|
await expect(searchBoxV2.results.first()).toBeVisible()
|
|
const loaderResults = await searchBoxV2.results.allTextContents()
|
|
|
|
expect(samplingResults).not.toEqual(loaderResults)
|
|
})
|
|
})
|
|
|
|
test.describe('Filter workflow', () => {
|
|
test('Filter chip removal restores results', async ({ comfyPage }) => {
|
|
const { searchBoxV2 } = comfyPage
|
|
|
|
await comfyPage.canvasOps.doubleClick()
|
|
await expect(searchBoxV2.input).toBeVisible()
|
|
|
|
// Record initial result text for comparison
|
|
await expect(searchBoxV2.results.first()).toBeVisible()
|
|
const unfilteredResults = await searchBoxV2.results.allTextContents()
|
|
|
|
// Apply Input filter with MODEL type
|
|
await searchBoxV2.filterBarButton('Input').click()
|
|
await expect(searchBoxV2.filterOptions.first()).toBeVisible()
|
|
await searchBoxV2.input.fill('MODEL')
|
|
await searchBoxV2.filterOptions
|
|
.filter({ hasText: 'MODEL' })
|
|
.first()
|
|
.click()
|
|
|
|
// Verify filter chip appeared and results changed
|
|
const filterChip = searchBoxV2.dialog.locator(
|
|
'[data-testid="filter-chip"]'
|
|
)
|
|
await expect(filterChip).toBeVisible()
|
|
await expect(searchBoxV2.results.first()).toBeVisible()
|
|
const filteredResults = await searchBoxV2.results.allTextContents()
|
|
expect(filteredResults).not.toEqual(unfilteredResults)
|
|
|
|
// Remove filter by clicking the chip delete button
|
|
await filterChip.getByTestId('chip-delete').click()
|
|
|
|
// Filter chip should be removed
|
|
await expect(filterChip).not.toBeVisible()
|
|
await expect(searchBoxV2.results.first()).toBeVisible()
|
|
})
|
|
})
|
|
|
|
test.describe('Keyboard navigation', () => {
|
|
test('ArrowUp on first item keeps first selected', async ({
|
|
comfyPage
|
|
}) => {
|
|
const { searchBoxV2 } = comfyPage
|
|
|
|
await comfyPage.canvasOps.doubleClick()
|
|
await expect(searchBoxV2.input).toBeVisible()
|
|
|
|
await searchBoxV2.input.fill('KSampler')
|
|
const results = searchBoxV2.results
|
|
await expect(results.first()).toBeVisible()
|
|
|
|
// First result should be selected by default
|
|
await expect(results.first()).toHaveAttribute('aria-selected', 'true')
|
|
|
|
// ArrowUp on first item should keep first selected
|
|
await comfyPage.page.keyboard.press('ArrowUp')
|
|
await expect(results.first()).toHaveAttribute('aria-selected', 'true')
|
|
})
|
|
})
|
|
})
|