mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-01-26 19:09:52 +00:00
bc4549244e
## Summary UseNewMenu has been defaulted to Top in the app for over a year; Playwright’s test default lagged behind. This PR aligns the test default with reality and keeps legacy specs stable. ## Changes - tests(e2e): default to 'Top' via fixture; specs that previously relied on the old implicit default now explicitly set 'Comfy.UseNewMenu' to 'Disabled'. - docs(browser-tests): remove outdated README note suggesting tests set 'Top' manually. ## Review Focus - Intentional uses of 'Top' and 'Bottom' remain unchanged. - Confirm ComfyPage default remains 'Top' (see browser_tests/fixtures/ComfyPage.ts). ## Screenshots (if applicable) N/A ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5746-test-e2e-align-test-default-menu-to-Top-make-legacy-specs-explicit-2786d73d365081218d06c1346f3ae18e) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <github-actions@github.com>
62 lines
2.5 KiB
TypeScript
62 lines
2.5 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
import type { NodeReference } from '../fixtures/utils/litegraphUtils'
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
})
|
|
|
|
test.describe('Primitive Node', () => {
|
|
test('Can load with correct size', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('primitive/primitive_node')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('primitive_node.png')
|
|
})
|
|
|
|
// When link is dropped on widget, it should automatically convert the widget
|
|
// to input.
|
|
test('Can connect to widget', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('primitive/primitive_node_unconnected')
|
|
const primitiveNode: NodeReference = await comfyPage.getNodeRefById(1)
|
|
const ksamplerNode: NodeReference = await comfyPage.getNodeRefById(2)
|
|
// Connect the output of the primitive node to the input of first widget of the ksampler node
|
|
await primitiveNode.connectWidget(0, ksamplerNode, 0)
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'primitive_node_connected.png'
|
|
)
|
|
})
|
|
|
|
test('Can connect to dom widget', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow(
|
|
'primitive/primitive_node_unconnected_dom_widget'
|
|
)
|
|
const primitiveNode: NodeReference = await comfyPage.getNodeRefById(1)
|
|
const clipEncoderNode: NodeReference = await comfyPage.getNodeRefById(2)
|
|
await primitiveNode.connectWidget(0, clipEncoderNode, 0)
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'primitive_node_connected_dom_widget.png'
|
|
)
|
|
})
|
|
|
|
test('Can connect to static primitive node', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('primitive/static_primitive_unconnected')
|
|
const primitiveNode: NodeReference = await comfyPage.getNodeRefById(1)
|
|
const ksamplerNode: NodeReference = await comfyPage.getNodeRefById(2)
|
|
await primitiveNode.connectWidget(0, ksamplerNode, 0)
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'static_primitive_connected.png'
|
|
)
|
|
})
|
|
|
|
test('Report missing nodes when connect to missing node', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.loadWorkflow(
|
|
'primitive/primitive_node_connect_missing_node'
|
|
)
|
|
// Wait for the element with the .comfy-missing-nodes selector to be visible
|
|
const missingNodesWarning = comfyPage.page.locator('.comfy-missing-nodes')
|
|
await expect(missingNodesWarning).toBeVisible()
|
|
})
|
|
})
|