mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-07-15 03:37:48 +00:00
## Summary Migrate 13 component test files from @vue/test-utils to @testing-library/vue as Phase 1 of incremental VTL adoption. ## Changes - **What**: Rewrite 13 test files (88 tests) to use `render`/`screen` queries, `userEvent` interactions, and `jest-dom` assertions. Add `data-testid` attributes to 6 components for lint-clean icon/element queries. Delete unused `src/utils/test-utils.ts`. - **Dependencies**: `@testing-library/vue`, `@testing-library/user-event`, `@testing-library/jest-dom` (installed in Phase 0) ## Review Focus - `data-testid` additions to component templates are minimal and non-behavioral - PrimeVue passthrough (`pt`) usage in UserAvatar.vue for icon testid - 2 targeted `eslint-disable` in FormRadioGroup.test.ts where PrimeVue places `aria-describedby` on wrapper div, not input ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10471-test-migrate-13-component-tests-from-VTU-to-VTL-Phase-1-32d6d73d36508159a33ffa285afb4c38) by [Unito](https://www.unito.io) --------- Co-authored-by: Amp <amp@ampcode.com>
120 lines
3.2 KiB
TypeScript
120 lines
3.2 KiB
TypeScript
import { createTestingPinia } from '@pinia/testing'
|
|
import { render, screen } from '@testing-library/vue'
|
|
import userEvent from '@testing-library/user-event'
|
|
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
import { defineComponent } from 'vue'
|
|
|
|
import QueueProgressOverlay from '@/components/queue/QueueProgressOverlay.vue'
|
|
import { i18n } from '@/i18n'
|
|
import type { JobStatus } from '@/platform/remote/comfyui/jobs/jobTypes'
|
|
import { TaskItemImpl, useQueueStore } from '@/stores/queueStore'
|
|
import { useSidebarTabStore } from '@/stores/workspace/sidebarTabStore'
|
|
|
|
vi.mock('@/platform/distribution/types', () => ({
|
|
isCloud: false
|
|
}))
|
|
|
|
const QueueOverlayExpandedStub = defineComponent({
|
|
name: 'QueueOverlayExpanded',
|
|
props: {
|
|
headerTitle: {
|
|
type: String,
|
|
required: true
|
|
}
|
|
},
|
|
template: `
|
|
<div>
|
|
<div data-testid="expanded-title">{{ headerTitle }}</div>
|
|
<button data-testid="show-assets-button" @click="$emit('show-assets')" />
|
|
</div>
|
|
`
|
|
})
|
|
|
|
function createTask(id: string, status: JobStatus): TaskItemImpl {
|
|
return new TaskItemImpl({
|
|
id,
|
|
status,
|
|
create_time: 0,
|
|
priority: 0
|
|
})
|
|
}
|
|
|
|
function renderComponent(
|
|
runningTasks: TaskItemImpl[],
|
|
pendingTasks: TaskItemImpl[]
|
|
) {
|
|
const pinia = createTestingPinia({
|
|
createSpy: vi.fn,
|
|
stubActions: false
|
|
})
|
|
const queueStore = useQueueStore(pinia)
|
|
const sidebarTabStore = useSidebarTabStore(pinia)
|
|
queueStore.runningTasks = runningTasks
|
|
queueStore.pendingTasks = pendingTasks
|
|
|
|
const user = userEvent.setup()
|
|
|
|
render(QueueProgressOverlay, {
|
|
props: {
|
|
expanded: true
|
|
},
|
|
global: {
|
|
plugins: [pinia, i18n],
|
|
stubs: {
|
|
QueueOverlayExpanded: QueueOverlayExpandedStub,
|
|
QueueOverlayActive: true,
|
|
MediaLightbox: true
|
|
},
|
|
directives: {
|
|
tooltip: () => {}
|
|
}
|
|
}
|
|
})
|
|
|
|
return { sidebarTabStore, user }
|
|
}
|
|
|
|
describe('QueueProgressOverlay', () => {
|
|
beforeEach(() => {
|
|
i18n.global.locale.value = 'en'
|
|
})
|
|
|
|
it('shows expanded header with running and queued labels', () => {
|
|
renderComponent(
|
|
[
|
|
createTask('running-1', 'in_progress'),
|
|
createTask('running-2', 'in_progress')
|
|
],
|
|
[createTask('pending-1', 'pending')]
|
|
)
|
|
|
|
expect(screen.getByTestId('expanded-title')).toHaveTextContent(
|
|
'2 running, 1 queued'
|
|
)
|
|
})
|
|
|
|
it('shows only running label when queued count is zero', () => {
|
|
renderComponent([createTask('running-1', 'in_progress')], [])
|
|
|
|
expect(screen.getByTestId('expanded-title')).toHaveTextContent('1 running')
|
|
})
|
|
|
|
it('shows job queue title when there are no active jobs', () => {
|
|
renderComponent([], [])
|
|
|
|
expect(screen.getByTestId('expanded-title')).toHaveTextContent('Job Queue')
|
|
})
|
|
|
|
it('toggles the assets sidebar tab when show-assets is clicked', async () => {
|
|
const { sidebarTabStore, user } = renderComponent([], [])
|
|
|
|
expect(sidebarTabStore.activeSidebarTabId).toBe(null)
|
|
|
|
await user.click(screen.getByTestId('show-assets-button'))
|
|
expect(sidebarTabStore.activeSidebarTabId).toBe('assets')
|
|
|
|
await user.click(screen.getByTestId('show-assets-button'))
|
|
expect(sidebarTabStore.activeSidebarTabId).toBe(null)
|
|
})
|
|
})
|