mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-03-04 20:50:06 +00:00
f2d5bfab73
## Summary Major refactoring of browser tests to improve reliability, maintainability, and type safety. ## Changes ### Test Infrastructure Decomposition - Decomposed `ComfyPage.ts` (~1000 lines) into focused helpers: - `CanvasHelper`, `DebugHelper`, `SubgraphHelper`, `NodeOperationsHelper` - `SettingsHelper`, `WorkflowHelper`, `ClipboardHelper`, `KeyboardHelper` - Created `ContextMenu` page object, `BaseDialog` base class, and `BottomPanel` page object - Extracted `DefaultGraphPositions` constants ### Locator Stability - Added `data-testid` attributes to Vue components (sidebar, dialogs, node library) - Created centralized `selectors.ts` with test ID constants - Replaced fragile CSS selectors (`.nth()`, `:nth-child()`) with `getByTestId`/`getByRole` ### Performance & Reliability - Removed `setTimeout` anti-patterns (replaced with `waitForFunction`) - Replaced `waitForTimeout` with retrying assertions - Replaced hardcoded coordinates with computed `NodeReference` positions - Enforced LF line endings for all text files ### Type Safety - Enabled `no-explicit-any` lint rule for browser_tests via oxlint - Purged `as any` casts from browser_tests - Added Window type augmentation for standardized window access - Added proper type annotations throughout ### Bug Fixes - Restored `ExtensionManager` API contract - Removed test-only settings from production schema - Fixed flaky selectors and missing test setup ## Testing - All browser tests pass - Typecheck passes <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Overhauled browser E2E test infrastructure with many new helpers/fixtures, updated test APIs, and CI test container image bumped for consistency. * **Chores** * Standardized line endings and applied stricter lint rules for browser tests; workspace dependency version updated. * **Documentation** * Updated Playwright and TypeScript testing guidance and test-run commands. * **UI** * Added stable data-testids to multiple components to improve testability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
45 lines
1.1 KiB
Vue
45 lines
1.1 KiB
Vue
<script setup lang="ts">
|
|
import Button from '@/components/ui/button/Button.vue'
|
|
import { t } from '@/i18n'
|
|
import { useCanvasStore } from '@/renderer/core/canvas/canvasStore'
|
|
import { useCommandStore } from '@/stores/commandStore'
|
|
|
|
const canvasStore = useCanvasStore()
|
|
function toggleLinearMode() {
|
|
useCommandStore().execute('Comfy.ToggleLinear', {
|
|
metadata: { source: 'button' }
|
|
})
|
|
}
|
|
</script>
|
|
<template>
|
|
<div
|
|
data-testid="mode-toggle"
|
|
class="p-1 bg-secondary-background rounded-lg w-10"
|
|
>
|
|
<Button
|
|
v-tooltip="{
|
|
value: t('linearMode.linearMode'),
|
|
showDelay: 300,
|
|
hideDelay: 300
|
|
}"
|
|
size="icon"
|
|
:variant="canvasStore.linearMode ? 'inverted' : 'secondary'"
|
|
@click="toggleLinearMode"
|
|
>
|
|
<i class="icon-[lucide--panels-top-left]" />
|
|
</Button>
|
|
<Button
|
|
v-tooltip="{
|
|
value: t('linearMode.graphMode'),
|
|
showDelay: 300,
|
|
hideDelay: 300
|
|
}"
|
|
size="icon"
|
|
:variant="canvasStore.linearMode ? 'secondary' : 'inverted'"
|
|
@click="toggleLinearMode"
|
|
>
|
|
<i class="icon-[comfy--workflow]" />
|
|
</Button>
|
|
</div>
|
|
</template>
|