## Summary Migrate the default combo widget select from the PrimeVue `SelectPlus` wrapper to a Reka `Combobox` implementation while preserving the existing Comfy combo widget contract and the node-canvas dropdown behavior. ## Changes - **What**: Rewrites `WidgetSelectDefault.vue` on top of Reka `ComboboxRoot`, `ComboboxTrigger`, `ComboboxInput`, `ComboboxContent`, and `ComboboxItem`. - **What**: Preserves the default combo widget surface: `v-model`, `widget` prop, `aria-label` from the widget name/label, `data-capture-wheel`, disabled state, placeholder/filter placeholder, default slot controls, invalid current value display, array values, dynamic/factory values, and `getOptionLabel` fallback behavior. - **What**: Keeps dynamic `values` compatibility by refreshing function-backed options when the dropdown opens, without re-evaluating the factory on every search keystroke. - **What**: Deletes the now-unused PrimeVue `SelectPlus.vue` wrapper and removes the PrimeVue test plugin/stub path from the default widget select tests. - **What**: Updates App Mode dropdown clipping coverage and combo-widget browser coverage to target the new Reka overlay/viewport structure. - **Breaking**: No breaking change is intended for the documented Comfy combo widget contract. This migration does not preserve incidental PrimeVue `Select` prop pass-through from `widget.options`; that was a side effect of wrapping PrimeVue rather than a stable widget API. - **Dependencies**: No new dependencies. ## Review Focus ### Compatibility choices The goal of this PR is a migration PR, not a broad behavior redesign. The new implementation keeps the Comfy-specific combo contract rather than attempting to emulate PrimeVue internals. In particular: - `values` still accepts arrays and functions, and function values are re-read on open to support dynamic/custom node option sources. - `getOptionLabel(value) || value` is intentionally preserved to match the sibling dropdown path and avoid turning an empty-string label into a blank rendered option. - Invalid/current values that are not present in the option list are still rendered in the trigger instead of disappearing. - `WidgetWithControl` continues to render its default slot in the control area, with trigger text truncation preserved. - App Mode `OverlayAppendToKey='body'` continues to map to a body portal to avoid panel clipping. ### Visual alignment and screenshot updates The previous PrimeVue implementation passed `size="small"`, which injected internal `.p-select-sm .p-select-label` styling. That internal PrimeVue style used its own small-select font size and padding, overriding the surrounding widget sizing intent and making the select trigger subtly taller with slightly larger text than nearby inline node widget controls. The Reka implementation intentionally keeps the normal widget styling path instead of recreating that PrimeVue-specific internal override. This means the trigger follows the same inline widget sizing direction as neighboring controls rather than preserving the incidental PrimeVue height/text-size delta. Because this is an expected visual difference from the migration, the affected E2E screenshots should be recaptured instead of treating the old PrimeVue select height as the target. ### Scrollbar and focus behavior Reka provides the combobox/listbox semantics we want, including search, arrow navigation, highlighted items, and Enter selection. The tricky part is the canvas dropdown scrollbar behavior. The native Reka viewport path hides/owns scrollbar behavior in a way that made it hard to preserve the previous widget dropdown affordances, especially visible scrollbars and mouse wheel capture over the node canvas. To keep the previous behavior, this PR renders a dedicated scrollable viewport inside `ComboboxContent` with the project scrollbar utilities (`scrollbar-thin`, stable gutter, transparent track). That preserves visible scroll affordance and allows wheel events over the dropdown to scroll the list instead of zooming the canvas. There was one Reka interaction to account for: pressing the native scrollbar can be treated as a focus-outside event from the search input, which previously closed the dropdown on mouse down or caused subsequent wheel events to leak back to the canvas. The new `useRestoreFocusOnViewportPointer` composable handles only that short pointer gesture: - viewport pointerdown marks a short-lived scrollbar/viewport interaction, - the next focus-outside event is prevented only if the search input can be restored, - the guard is cleared by `pointerup`, `pointercancel`, and a timeout so normal outside clicks still close the dropdown. ### Tests and regression coverage Unit coverage was updated around the new Reka implementation: - option sources from arrays and functions, - dynamic values refreshed on open but not on each search keystroke, - selection updates and blank/undefined Reka emissions being ignored, - search filtering and Reka keyboard selection behavior, - disabled state, invalid current values, `getOptionLabel`, empty results status, and WidgetWithControl slot preservation, - composable coverage for pointerup, pointercancel, repeated pointerdown listener cleanup, and no-input/no-op behavior. Browser regression coverage now checks the canvas-specific interaction surface: - opening and selecting default combo widget options, - wheel over the dropdown scrolls the list instead of zooming the canvas, - pressing the scrollbar does not close the dropdown, - wheel capture still works after pressing the scrollbar, - opening another node widget closes the previous dropdown, - switching between node widgets preserves dropdown scroll capture, - serialize/reload retains selected combo values. ## Screenshots (if applicable) New <img width="527" height="753" alt="스크린샷 2026-05-18 오전 1 36 27" src="https://github.com/user-attachments/assets/2293d510-6965-4b84-9b12-b8528f8a734f" /> Old <img width="496" height="473" alt="스크린샷 2026-05-18 오전 1 35 57" src="https://github.com/user-attachments/assets/47c0e28a-27df-44a6-81a8-14fcc1f3bd8f" /> Reka Supports Auto highlight top item on search (Search -> Enter -> Select 👍) https://github.com/user-attachments/assets/9d633dfc-c23a-4e7a-8d39-b044c219f1f3 The default combo widget trigger has a small intentional visual delta from the old PrimeVue path because the Reka implementation does not recreate PrimeVue's internal `size="small"` label override. https://github.com/user-attachments/assets/a9053a14-e39e-4d5e-a846-dcf9aeb0caed ## Validation - `pnpm format` - `pnpm lint` (passes; existing warning-only lint output remains in unrelated tests) - `pnpm typecheck` - `pnpm typecheck:browser` - `pnpm test:unit` - `PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_TEST_URL=http://127.0.0.1:5174 pnpm exec playwright test browser_tests/tests/vueNodes/widgets/combo/comboWidget.spec.ts --project=chromium` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-12288-refactor-migrate-default-combo-widget-select-to-Reka-3616d73d365081fd8742c038a7dc7851) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: github-actions <github-actions@github.com>
Playwright Testing for ComfyUI_frontend
This document outlines the setup, usage, and common patterns for Playwright browser tests in the ComfyUI_frontend project.
Prerequisites
CRITICAL: Start ComfyUI backend with --multi-user flag:
python main.py --multi-user
Without this flag, parallel tests will conflict and fail randomly.
Setup
ComfyUI devtools
ComfyUI_devtools is included in this repository under tools/devtools/. During CI/CD, these files are automatically copied to the custom_nodes directory.
ComfyUI_devtools adds additional API endpoints and nodes to ComfyUI for browser testing.
For local development, copy the devtools files to your ComfyUI installation:
cp -r tools/devtools/* /path/to/your/ComfyUI/custom_nodes/ComfyUI_devtools/
Node.js & Playwright Prerequisites
Ensure you have the Node.js version specified in .nvmrc installed.
Then, set up the Chromium test driver:
pnpm exec playwright install chromium --with-deps
Environment Configuration
Create .env from the template:
cp .env_example .env
Key settings for debugging:
# Remove Vue dev overlay that blocks UI elements
DISABLE_VUE_PLUGINS=true
# Test against dev server (recommended) or backend directly
PLAYWRIGHT_TEST_URL=http://localhost:5173 # Dev server
# PLAYWRIGHT_TEST_URL=http://localhost:8188 # Direct backend
PLAYWRIGHT_SETUP_API_URL=http://localhost:8188 # Setup/auth API when using the dev server URL above
# Path to ComfyUI for backing up user data/settings before tests
TEST_COMFYUI_DIR=/path/to/your/ComfyUI
Common Setup Issues
Release API Mocking
By default, all tests mock the release API (api.comfy.org/releases) to prevent release notification popups from interfering with test execution. This is necessary because the release notifications can appear over UI elements and block test interactions.
To test with real release data, you can disable mocking:
await comfyPage.setup({ mockReleases: false })
For tests that specifically need to test release functionality, see the example in tests/releaseNotifications.spec.ts.
Running Tests
Always use UI mode for development:
pnpm test:browser:local --ui
UI mode features:
- Locator picker: Click the target icon, then click any element to get the exact locator code to use in your test. The code appears in the Locator tab.
- Step debugging: Step through your test line-by-line by clicking Source tab
- Time travel: In the Actions tab/panel, click any step to see the browser state at that moment
- Console/Network Tabs: View logs and API calls at each step
- Attachments Tab: View all snapshots with expected and actual images
For CI or headless testing:
pnpm test:browser:local # Run all tests
pnpm test:browser:local widget.spec.ts # Run specific test file
Slowing the browser down for debugging
When running with --headed (or --ui), set SLOW_MO to a millisecond delay
to slow every Playwright action down so you can watch what is happening. The
delay only applies when PLAYWRIGHT_LOCAL is set (the default for the
pnpm test:browser:local script).
SLOW_MO=250 pnpm test:browser:local --headed widget.spec.ts
Test Structure
Browser tests in this project follow a specific organization pattern:
-
Fixtures: Located in
fixtures/- These provide test setup and utilitiesComfyPage.ts- The main fixture for interacting with ComfyUIComfyMouse.ts- Utility for mouse interactions with the canvas- Components fixtures in
fixtures/components/- Page object models for UI components
-
Tests: Located in
tests/- The actual test specifications- Organized by functionality (e.g.,
widget.spec.ts,interaction.spec.ts) - Snapshot directories (e.g.,
widget.spec.ts-snapshots/) contain reference screenshots
- Organized by functionality (e.g.,
-
Utilities: Located in
utils/- Common utility functionslitegraphUtils.ts- Utilities for working with LiteGraph nodes
Writing Effective Tests
When writing new tests, follow these patterns:
Test Structure
// Import the test fixture
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
test.describe('Feature Name', () => {
// Set up test environment if needed
test.beforeEach(async ({ comfyPage }) => {
// Common setup
})
test('should do something specific', async ({ comfyPage }) => {
// Test implementation
})
})
Leverage Existing Fixtures and Helpers
Always check for existing helpers and fixtures before implementing new ones:
- ComfyPage: Main fixture with methods for canvas interaction and node management
- ComfyMouse: Helper for precise mouse operations on the canvas
- Component Fixtures: Check
browser_tests/fixtures/components/for UI component page objects (e.g.Actionbar.ts,Templates.ts,ContextMenu.ts) - Helper Classes: Check
browser_tests/fixtures/helpers/for domain-specific helper classes wired into ComfyPage (e.g.CanvasHelper.ts,WorkflowHelper.ts) - Utility Functions: Check
browser_tests/fixtures/utils/for standalone utilities (e.g.fitToView.ts,clipboardSpy.ts,builderTestUtils.ts)
Most common testing needs are already addressed by these helpers, which will make your tests more consistent and reliable.
Import Conventions
- Prefer
@e2e/*for imports withinbrowser_tests/ - Continue using
@/*for imports fromsrc/ - Avoid introducing new deep relative imports within
browser_tests/when the alias is available
Key Testing Patterns
-
Focus elements explicitly: Canvas-based elements often need explicit focus before interaction:
// Click the canvas first to focus it before pressing keys await comfyPage.canvas.click() await comfyPage.page.keyboard.press('a') -
Mark canvas as dirty if needed: Some interactions need explicit canvas updates:
// After programmatically changing node state, mark canvas dirty await comfyPage.page.evaluate(() => { window['app'].graph.setDirtyCanvas(true, true) }) -
Use node references over coordinates: Node references from
fixtures/utils/litegraphUtils.tsprovide stable ways to interact with nodes:// Prefer this: const node = await comfyPage.getNodeRefsByType('LoadImage')[0] await node.click('title') // Over this: await comfyPage.canvas.click({ position: { x: 100, y: 100 } }) -
Wait for canvas to render after UI interactions:
await comfyPage.nextFrame() -
Clean up persistent server state: While most state is reset between tests, anything stored on the server persists:
// Reset settings that affect other tests (these are stored on server) await comfyPage.setSetting('Comfy.ColorPalette', 'dark') await comfyPage.setSetting('Comfy.NodeBadge.NodeIdBadgeMode', 'None') // Clean up uploaded files if needed comfyPage.deleteFileAfterTest({ filename: 'image.png' }) -
Prefer functional assertions over screenshots: Use screenshots only when visual verification is necessary:
// Prefer this: await expect.poll(() => node.isPinned()).toBe(true) await expect.poll(() => node.getProperty('title')).toBe('Expected Title') // Over this - only use when needed: await expect(comfyPage.canvas).toHaveScreenshot('state.png') -
Use minimal test workflows: When creating test workflows, keep them as minimal as possible:
// Include only the components needed for the test await comfyPage.loadWorkflow('single_ksampler') -
Debug helpers for visual debugging (remove before committing):
ComfyPage includes temporary debug methods for troubleshooting:
test('debug failing interaction', async ({ comfyPage }, testInfo) => { // Add visual markers to see click positions await comfyPage.debugAddMarker({ x: 100, y: 200 }) // Attach screenshot with markers to test report await comfyPage.debugAttachScreenshot(testInfo, 'node-positions', { element: 'canvas', markers: [{ position: { x: 100, y: 200 } }] }) // Show canvas overlay for easier debugging await comfyPage.debugShowCanvasOverlay() // Remember to remove debug code before committing! })Available debug methods:
debugAddMarker(position)- Red circle at positiondebugAttachScreenshot(testInfo, name)- Attach to test reportdebugShowCanvasOverlay()- Show canvas as overlaydebugGetCanvasDataURL()- Get canvas as base64
Common Patterns and Utilities
Page Object Pattern
Tests use the Page Object pattern to create abstractions over the UI:
// Using the ComfyPage fixture
test('Can toggle boolean widget', async ({ comfyPage }) => {
await comfyPage.loadWorkflow('widgets/boolean_widget')
const node = (await comfyPage.getFirstNodeRef())!
const widget = await node.getWidget(0)
await widget.click()
})
Node References
The NodeReference class provides helpers for interacting with LiteGraph nodes:
// Getting node by type and interacting with it
const nodes = await comfyPage.getNodeRefsByType('LoadImage')
const loadImageNode = nodes[0]
const widget = await loadImageNode.getWidget(0)
await widget.click()
Visual Regression Testing
Tests use screenshot comparisons to verify UI state:
// Take a screenshot and compare to reference
await expect(comfyPage.canvas).toHaveScreenshot('boolean_widget_toggled.png')
Waiting for Animations
Always call nextFrame() after actions that trigger animations:
await comfyPage.canvas.click({ position: { x: 100, y: 100 } })
await comfyPage.nextFrame() // Wait for canvas to redraw
Mouse Interactions
Canvas operations use special helpers to ensure proper timing:
// Using ComfyMouse for drag and drop
await comfyMouse.dragAndDrop(
{ x: 100, y: 100 }, // From
{ x: 200, y: 200 } // To
)
// Standard ComfyPage helpers
await comfyPage.drag({ x: 100, y: 100 }, { x: 200, y: 200 })
await comfyPage.pan({ x: 200, y: 200 })
await comfyPage.zoom(-100) // Zoom in
Workflow Management
Tests use workflows stored in assets/ for consistent starting points:
// Load a test workflow
await comfyPage.loadWorkflow('single_ksampler')
// Wait for workflow to load and stabilize
await comfyPage.nextFrame()
Custom Assertions
The project includes custom Playwright assertions through comfyExpect:
// Check if a node is in a specific state
await expect(node).toBePinned()
await expect(node).toBeBypassed()
await expect(node).toBeCollapsed()
Troubleshooting Common Issues
Flaky Tests
- Timing Issues: Always wait for animations to complete with
nextFrame() - Coordinate Sensitivity: Canvas coordinates are viewport-relative; use node references when possible
- Test Isolation: Tests run in parallel; avoid dependencies between tests
- Screenshots vary: Ensure your OS and browser match the reference environment (Linux)
- Async / await: Race conditions are a very common cause of test flakiness
Screenshot Testing
Due to variations in system font rendering, screenshot expectations are platform-specific. Please note:
- Do not commit local screenshot expectations to the repository
- We maintain Linux screenshot expectations as our GitHub Action runner operates in a Linux environment
- While developing, you can generate local screenshots for your tests, but these will differ from CI-generated ones
Working with Screenshots Locally
Option 1 - Skip screenshot tests (add to playwright.config.ts):
export default defineConfig({
grep: process.env.CI ? undefined : /^(?!.*screenshot).*$/
})
Option 2 - Generate local baselines for comparison:
pnpm test:browser:local --update-snapshots
Creating New Screenshot Baselines
For PRs from Comfy-Org/ComfyUI_frontend branches:
- Write test with
toHaveScreenshot('filename.png') - Create PR and add
New Browser Test Expectationlabel - CI will generate and commit the Linux baseline screenshots
Note: Fork PRs cannot auto-commit screenshots. A maintainer will need to commit the screenshots manually for you (don't worry, they'll do it).
Viewing Test Reports
Automated Test Deployment
The project automatically deploys Playwright test reports to Cloudflare Pages for every PR and push to main branches.
Accessing Test Reports
- From PR comments: Click the "View Report" links for each browser
- Direct URLs: Reports are available at
https://[branch].comfyui-playwright-[browser].pages.dev(branch-specific deployments) - From GitHub Actions: Download artifacts from failed runs
How It Works
-
Test execution: All browser tests run in parallel across multiple browsers
-
Report generation: HTML reports are generated for each browser configuration
-
Cloudflare deployment: Each browser's report deploys to its own Cloudflare Pages project with branch isolation:
comfyui-playwright-chromium(with branch-specific URLs)comfyui-playwright-mobile-chrome(with branch-specific URLs)comfyui-playwright-chromium-2x(2x scale, with branch-specific URLs)comfyui-playwright-chromium-0-5x(0.5x scale, with branch-specific URLs)
-
PR comments: GitHub automatically updates PR comments with:
- ✅/❌ Test status for each browser
- Direct links to interactive test reports
- Real-time progress updates as tests complete
Resources
- Playwright UI Mode - Interactive test debugging
- Playwright Debugging Guide
- act - Run GitHub Actions locally for CI debugging