mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
98a9facc7d
## Summary - Add a Playwright-based diagnostic tool (`@audit` tagged) that automatically detects DOM elements where CSS `contain: layout style` would improve rendering performance - Extend `ComfyPage` fixture and `playwright.config.ts` to support `@audit` tag (excluded from CI, perf infra enabled) - Add `/contain-audit` skill definition documenting the workflow ## How it works 1. Loads the 245-node workflow in a real browser 2. Walks the DOM tree and scores every element by subtree size and sizing constraints 3. For each high-scoring candidate, applies `contain: layout style` via JS 4. Measures rendering performance (style recalcs, layouts, task duration) before and after 5. Takes before/after screenshots to detect visual breakage 6. Outputs a ranked report to console ## Test plan - [ ] `pnpm typecheck` passes - [ ] `pnpm typecheck:browser` passes - [ ] `pnpm lint` passes - [ ] Existing Playwright tests unaffected (`@audit` excluded from CI via `grepInvert`) - [ ] Run `pnpm exec playwright test browser_tests/tests/containAudit.spec.ts --project=chromium` locally with dev server ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10026-tool-add-CSS-containment-audit-skill-and-Playwright-diagnostic-3256d73d365081b29470df164f798f7d) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
117 lines
3.0 KiB
TypeScript
117 lines
3.0 KiB
TypeScript
import { defineConfig, devices } from '@playwright/test'
|
|
import type { PlaywrightTestConfig } from '@playwright/test'
|
|
|
|
const maybeLocalOptions: PlaywrightTestConfig = process.env.PLAYWRIGHT_LOCAL
|
|
? {
|
|
// VERY HELPFUL: Skip screenshot tests locally
|
|
// grep: process.env.CI ? undefined : /^(?!.*screenshot).*$/,
|
|
timeout: 30_000, // Longer timeout for breakpoints
|
|
retries: 0, // No retries while debugging. Increase if writing new tests. that may be flaky.
|
|
workers: 1, // Single worker for easier debugging. Increase to match CPU cores if you want to run a lot of tests in parallel.
|
|
|
|
use: {
|
|
trace: 'on', // Always capture traces (CI uses 'on-first-retry')
|
|
video: 'on' // Always record video (CI uses 'retain-on-failure')
|
|
}
|
|
}
|
|
: {
|
|
retries: process.env.CI ? 3 : 0,
|
|
use: {
|
|
trace: 'on-first-retry'
|
|
}
|
|
}
|
|
|
|
export default defineConfig({
|
|
testDir: './browser_tests',
|
|
fullyParallel: true,
|
|
forbidOnly: !!process.env.CI,
|
|
reporter: 'html',
|
|
...maybeLocalOptions,
|
|
|
|
globalSetup: './browser_tests/globalSetup.ts',
|
|
globalTeardown: './browser_tests/globalTeardown.ts',
|
|
|
|
projects: [
|
|
{
|
|
name: 'chromium',
|
|
use: { ...devices['Desktop Chrome'] },
|
|
timeout: 15000,
|
|
grepInvert: /@mobile|@perf|@audit/ // Run all tests except those tagged with @mobile, @perf, or @audit
|
|
},
|
|
|
|
{
|
|
name: 'performance',
|
|
use: {
|
|
...devices['Desktop Chrome'],
|
|
trace: 'retain-on-failure'
|
|
},
|
|
timeout: 60_000,
|
|
grep: /@perf/,
|
|
fullyParallel: false
|
|
},
|
|
|
|
{
|
|
name: 'audit',
|
|
use: {
|
|
...devices['Desktop Chrome'],
|
|
trace: 'retain-on-failure'
|
|
},
|
|
timeout: 120_000,
|
|
grep: /@audit/,
|
|
fullyParallel: false
|
|
},
|
|
|
|
{
|
|
name: 'chromium-2x',
|
|
use: { ...devices['Desktop Chrome'], deviceScaleFactor: 2 },
|
|
timeout: 15000,
|
|
grep: /@2x/ // Run all tests tagged with @2x
|
|
},
|
|
|
|
{
|
|
name: 'chromium-0.5x',
|
|
use: { ...devices['Desktop Chrome'], deviceScaleFactor: 0.5 },
|
|
timeout: 15000,
|
|
grep: /@0.5x/ // Run all tests tagged with @0.5x
|
|
},
|
|
|
|
// {
|
|
// name: 'firefox',
|
|
// use: { ...devices['Desktop Firefox'] },
|
|
// },
|
|
|
|
// {
|
|
// name: 'webkit',
|
|
// use: { ...devices['Desktop Safari'] },
|
|
// },
|
|
|
|
/* Test against mobile viewports. */
|
|
{
|
|
name: 'mobile-chrome',
|
|
use: { ...devices['Pixel 5'], hasTouch: true },
|
|
grep: /@mobile/ // Run only tests tagged with @mobile
|
|
}
|
|
// {
|
|
// name: 'Mobile Safari',
|
|
// use: { ...devices['iPhone 12'] },
|
|
// },
|
|
|
|
/* Test against branded browsers. */
|
|
// {
|
|
// name: 'Microsoft Edge',
|
|
// use: { ...devices['Desktop Edge'], channel: 'msedge' },
|
|
// },
|
|
// {
|
|
// name: 'Google Chrome',
|
|
// use: { ...devices['Desktop Chrome'], channel: 'chrome' },
|
|
// },
|
|
]
|
|
|
|
/* Run your local dev server before starting the tests */
|
|
// webServer: {
|
|
// command: 'pnpm dev',
|
|
// url: 'http://127.0.0.1:5173',
|
|
// reuseExistingServer: !process.env.CI,
|
|
// },
|
|
})
|