mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 06:20:11 +00:00
## Summary Adds a `@perf` test to establish a baseline for viewport panning GC churn on large graphs. ## Changes - **What**: New `large graph viewport pan sweep` perf test that pans aggressively back and forth across a 245-node graph, forcing many nodes to cross the viewport boundary. Measures style recalcs, forced layouts, task duration, heap delta, and DOM node count. ## Review Focus This is **PR 1 of 2** (perf-fix-with-proof pattern). The fix (viewport culling) will follow in a separate PR once this baseline is established on main. CI will then show the delta proving the improvement. The test uses 120 steps out + 120 steps back at 8px/step = ~960px total displacement, enough to sweep across a significant portion of the large graph layout. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10479-test-add-perf-test-for-viewport-pan-sweep-GC-churn-32d6d73d365081cc9f15fe3d5890675d) by [Unito](https://www.unito.io)
82 lines
2.4 KiB
TypeScript
82 lines
2.4 KiB
TypeScript
import { mkdirSync, readdirSync, readFileSync, writeFileSync } from 'fs'
|
|
import { join } from 'path'
|
|
|
|
import type { PerfMeasurement } from '../fixtures/helpers/PerformanceHelper'
|
|
|
|
export interface PerfReport {
|
|
timestamp: string
|
|
gitSha: string
|
|
branch: string
|
|
measurements: PerfMeasurement[]
|
|
}
|
|
|
|
const TEMP_DIR = join('test-results', 'perf-temp')
|
|
|
|
type MeasurementField = keyof PerfMeasurement
|
|
|
|
const FIELD_FORMATTERS: Record<string, (m: PerfMeasurement) => string> = {
|
|
styleRecalcs: (m) => `${m.styleRecalcs} recalcs`,
|
|
layouts: (m) => `${m.layouts} layouts`,
|
|
taskDurationMs: (m) => `${m.taskDurationMs.toFixed(1)}ms task`,
|
|
layoutDurationMs: (m) => `${m.layoutDurationMs.toFixed(1)}ms layout`,
|
|
frameDurationMs: (m) => `${m.frameDurationMs.toFixed(1)}ms/frame`,
|
|
totalBlockingTimeMs: (m) => `TBT=${m.totalBlockingTimeMs.toFixed(0)}ms`,
|
|
durationMs: (m) => `${m.durationMs.toFixed(0)}ms total`,
|
|
heapDeltaBytes: (m) => `heap Δ${(m.heapDeltaBytes / 1024).toFixed(0)}KB`,
|
|
domNodes: (m) => `DOM Δ${m.domNodes}`,
|
|
heapUsedBytes: (m) => `heap ${(m.heapUsedBytes / 1024 / 1024).toFixed(1)}MB`
|
|
}
|
|
|
|
/**
|
|
* Log a perf measurement to the console in a consistent format.
|
|
* Fields are formatted automatically based on their type.
|
|
*/
|
|
export function logMeasurement(
|
|
label: string,
|
|
m: PerfMeasurement,
|
|
fields: MeasurementField[]
|
|
) {
|
|
const parts = fields.map((f) => {
|
|
const formatter = FIELD_FORMATTERS[f]
|
|
if (formatter) return formatter(m)
|
|
return `${f}=${m[f]}`
|
|
})
|
|
console.log(`${label}: ${parts.join(', ')}`)
|
|
}
|
|
|
|
export function recordMeasurement(m: PerfMeasurement) {
|
|
mkdirSync(TEMP_DIR, { recursive: true })
|
|
const filename = `${m.name}-${Date.now()}.json`
|
|
writeFileSync(join(TEMP_DIR, filename), JSON.stringify(m))
|
|
}
|
|
|
|
export function writePerfReport(
|
|
gitSha = process.env.GITHUB_SHA ?? 'local',
|
|
branch = process.env.GITHUB_HEAD_REF ?? 'local'
|
|
) {
|
|
if (!readdirSync('test-results', { withFileTypes: true }).length) return
|
|
|
|
let tempFiles: string[]
|
|
try {
|
|
tempFiles = readdirSync(TEMP_DIR).filter((f) => f.endsWith('.json'))
|
|
} catch {
|
|
return
|
|
}
|
|
if (tempFiles.length === 0) return
|
|
|
|
const measurements: PerfMeasurement[] = tempFiles.map((f) =>
|
|
JSON.parse(readFileSync(join(TEMP_DIR, f), 'utf-8'))
|
|
)
|
|
|
|
const report: PerfReport = {
|
|
timestamp: new Date().toISOString(),
|
|
gitSha,
|
|
branch,
|
|
measurements
|
|
}
|
|
writeFileSync(
|
|
join('test-results', 'perf-metrics.json'),
|
|
JSON.stringify(report, null, 2)
|
|
)
|
|
}
|