mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
8c9328c1b2
## Summary Add eslint-plugin-playwright as an oxlint JS plugin scoped to browser_tests/, enforcing Playwright best practices at lint time. ## Changes - **What**: Configure eslint-plugin-playwright@2.10.1 via oxlint's alpha `jsPlugins` field (`.oxlintrc.json` override scoped to `browser_tests/**/*.ts`). 18 recommended rules + `prefer-native-locators` + `require-to-pass-timeout` at error severity. All 173 initial violations resolved (config, auto-fix, manual fixes). `no-force-option` set to off — 28 violations need triage (canvas overlay workarounds vs unnecessary force) in a dedicated PR. - **Dependencies**: `eslint-plugin-playwright@^2.10.1` (devDependency, required by oxlint jsPlugins at runtime) ## Review Focus - `.oxlintrc.json` override structure — this is the first use of oxlint's JS plugins alpha feature in this repo - Manual fixes in spec files: `waitForSelector` → `locator.waitFor`, deprecated page methods → locator equivalents, `toPass()` timeout additions - Compound CSS selectors replaced with `.and()` (Playwright native locator composition) to avoid `prefer-native-locators` suppressions - Lint script changes in `package.json` to include `browser_tests/` in oxlint targets --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com>
87 lines
2.4 KiB
TypeScript
87 lines
2.4 KiB
TypeScript
import type { Locator } from '@playwright/test'
|
|
|
|
import {
|
|
comfyPageFixture as test,
|
|
comfyExpect as expect
|
|
} from '@e2e/fixtures/ComfyPage'
|
|
|
|
test.describe('Job History Actions', { tag: '@ui' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
await comfyPage.setup()
|
|
|
|
// Expand the queue overlay so the JobHistoryActionsMenu is visible
|
|
await comfyPage.page.getByTestId('queue-overlay-toggle').click()
|
|
})
|
|
|
|
async function openMoreOptionsPopover(comfyPage: {
|
|
page: { getByLabel(label: string | RegExp): Locator }
|
|
}) {
|
|
const moreButton = comfyPage.page.getByLabel(/More options/i).first()
|
|
await moreButton.click()
|
|
}
|
|
|
|
test('More options popover opens', async ({ comfyPage }) => {
|
|
await openMoreOptionsPopover(comfyPage)
|
|
|
|
await expect(
|
|
comfyPage.page.getByTestId('docked-job-history-action')
|
|
).toBeVisible()
|
|
})
|
|
|
|
test('Docked job history action is visible with text', async ({
|
|
comfyPage
|
|
}) => {
|
|
await openMoreOptionsPopover(comfyPage)
|
|
|
|
const action = comfyPage.page.getByTestId('docked-job-history-action')
|
|
await expect(action).toBeVisible()
|
|
await expect(action).not.toBeEmpty()
|
|
})
|
|
|
|
test('Show run progress bar action is visible', async ({ comfyPage }) => {
|
|
await openMoreOptionsPopover(comfyPage)
|
|
|
|
await expect(
|
|
comfyPage.page.getByTestId('show-run-progress-bar-action')
|
|
).toBeVisible()
|
|
})
|
|
|
|
test('Clear history action is visible', async ({ comfyPage }) => {
|
|
await openMoreOptionsPopover(comfyPage)
|
|
|
|
await expect(
|
|
comfyPage.page.getByTestId('clear-history-action')
|
|
).toBeVisible()
|
|
})
|
|
|
|
test('Clicking docked job history closes popover', async ({ comfyPage }) => {
|
|
await openMoreOptionsPopover(comfyPage)
|
|
|
|
const action = comfyPage.page.getByTestId('docked-job-history-action')
|
|
await expect(action).toBeVisible()
|
|
await action.click()
|
|
|
|
await expect(action).toBeHidden()
|
|
})
|
|
|
|
test('Clicking show run progress bar toggles setting', async ({
|
|
comfyPage
|
|
}) => {
|
|
const settingBefore = await comfyPage.settings.getSetting<boolean>(
|
|
'Comfy.Queue.ShowRunProgressBar'
|
|
)
|
|
|
|
await openMoreOptionsPopover(comfyPage)
|
|
|
|
const action = comfyPage.page.getByTestId('show-run-progress-bar-action')
|
|
await action.click()
|
|
|
|
await expect
|
|
.poll(() =>
|
|
comfyPage.settings.getSetting<boolean>('Comfy.Queue.ShowRunProgressBar')
|
|
)
|
|
.toBe(!settingBefore)
|
|
})
|
|
})
|