mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
## Summary
Harden 98 E2E spec files and 8 fixtures/helpers for deterministic CI
runs by replacing race-prone patterns with retry-safe alternatives.
No source code changes -- only `browser_tests/` is touched.
## Changes
- **E2E spec hardening** (98 spec files, 6 fixtures, 2 helpers):
| Fix class | Sites | Examples |
|-----------|-------|---------:|
| `expect(await ...)` -> `expect.poll()` | ~153 | interaction,
defaultKeybindings, workflows, featureFlags |
| `const x = await loc.count(); expect(x)` -> `toHaveCount()` | ~19 |
menu, linkInteraction, assets, bottomPanelShortcuts |
| `nextFrame()` -> `waitForHidden()` after menu clicks | ~22 |
contextMenu, rightClickMenu, subgraphHelper |
| Redundant `nextFrame()` removed | many | defaultKeybindings, minimap,
builderSaveFlow |
| `expect(async () => { ... }).toPass()` retry blocks | 5 | interaction
(graphdialog dismiss guard) |
| `force:true` removed from `BaseDialog.close()` | 1 | BaseDialog
fixture |
| ContextMenu `waitForHidden` simplified (check-then-act race removed) |
1 | ContextMenu fixture |
| Non-deterministic node order -> proximity-based selection | 1 |
interaction (toggle dom widget) |
| Tight poll timeout (250ms) -> >=2000ms | 2 | templates |
- **Helper improvements**: Exposed locator getters on
`ComfyPage.domWidgets`, `ToastHelper.toastErrors`, and
`WorkflowsSidebarTab.activeWorkflowLabel` so callers can use retrying
assertions (`toHaveCount()`, `toHaveText()`) directly.
- **Flake pattern catalog**: Added section 7 table to
`browser_tests/FLAKE_PREVENTION_RULES.md` documenting 8 pattern classes
for reviewers and future authors.
- **Docs**: Fixed bad examples in `browser_tests/README.md` to use
`expect.poll()`.
- **Breaking**: None
- **Dependencies**: None
## Review Focus
- All fixes follow the rules in
`browser_tests/FLAKE_PREVENTION_RULES.md`
- No behavioral changes to tests -- only timing/retry strategy is
updated
- The `ContextMenu.waitForHidden` simplification removes a
swallowed-error anti-pattern; both locators now use direct `waitFor({
state: 'hidden' })`
---------
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: github-actions <github-actions@github.com>
74 lines
2.0 KiB
TypeScript
74 lines
2.0 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
import type { Locator, Page } from '@playwright/test'
|
|
|
|
export class ContextMenu {
|
|
constructor(public readonly page: Page) {}
|
|
|
|
get primeVueMenu() {
|
|
return this.page.locator('.p-contextmenu, .p-menu')
|
|
}
|
|
|
|
get litegraphMenu() {
|
|
return this.page.locator('.litemenu')
|
|
}
|
|
|
|
get menuItems() {
|
|
return this.page.locator('.p-menuitem, .litemenu-entry')
|
|
}
|
|
|
|
async clickMenuItem(name: string): Promise<void> {
|
|
await this.page.getByRole('menuitem', { name }).click()
|
|
}
|
|
|
|
async clickMenuItemExact(name: string): Promise<void> {
|
|
await this.page.getByRole('menuitem', { name, exact: true }).click()
|
|
}
|
|
|
|
async clickLitegraphMenuItem(name: string): Promise<void> {
|
|
await this.page.locator(`.litemenu-entry:has-text("${name}")`).click()
|
|
}
|
|
|
|
async isVisible(): Promise<boolean> {
|
|
const primeVueVisible = await this.primeVueMenu
|
|
.isVisible()
|
|
.catch(() => false)
|
|
const litegraphVisible = await this.litegraphMenu
|
|
.isVisible()
|
|
.catch(() => false)
|
|
return primeVueVisible || litegraphVisible
|
|
}
|
|
|
|
async assertHasItems(items: string[]): Promise<void> {
|
|
for (const item of items) {
|
|
await expect
|
|
.soft(this.page.getByRole('menuitem', { name: item }))
|
|
.toBeVisible()
|
|
}
|
|
}
|
|
|
|
async openFor(locator: Locator): Promise<this> {
|
|
await locator.click({ button: 'right' })
|
|
await expect.poll(() => this.isVisible()).toBe(true)
|
|
return this
|
|
}
|
|
|
|
/**
|
|
* Select a Vue node by clicking its header, then right-click to open
|
|
* the context menu. Vue nodes require a selection click before the
|
|
* right-click so the correct per-node menu items appear.
|
|
*/
|
|
async openForVueNode(header: Locator): Promise<this> {
|
|
await header.click()
|
|
await header.click({ button: 'right' })
|
|
await this.primeVueMenu.waitFor({ state: 'visible' })
|
|
return this
|
|
}
|
|
|
|
async waitForHidden(): Promise<void> {
|
|
await Promise.all([
|
|
this.primeVueMenu.waitFor({ state: 'hidden' }),
|
|
this.litegraphMenu.waitFor({ state: 'hidden' })
|
|
])
|
|
}
|
|
}
|