mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
90 lines
2.9 KiB
TypeScript
90 lines
2.9 KiB
TypeScript
import type { Page } from '@playwright/test'
|
|
|
|
import type { KeyCombo } from '@/platform/keybindings/types'
|
|
|
|
export class CommandHelper {
|
|
constructor(private readonly page: Page) {}
|
|
|
|
async executeCommand(
|
|
commandId: string,
|
|
metadata?: Record<string, unknown>
|
|
): Promise<void> {
|
|
await this.page.evaluate(
|
|
({ commandId, metadata }) => {
|
|
const app = window.app
|
|
if (!app) throw new Error('window.app is not available')
|
|
|
|
return app.extensionManager.command.execute(commandId, {
|
|
metadata
|
|
})
|
|
},
|
|
{ commandId, metadata }
|
|
)
|
|
}
|
|
|
|
async registerCommand(
|
|
commandId: string,
|
|
command: (() => void) | (() => Promise<void>)
|
|
): Promise<void> {
|
|
// SECURITY: eval() is intentionally used here to deserialize/execute functions
|
|
// passed from controlled test code across the Node/Playwright browser boundary.
|
|
// Execution happens in isolated Playwright browser contexts with test-only data.
|
|
// This pattern is unsafe for production and must not be copied elsewhere.
|
|
await this.page.evaluate(
|
|
({ commandId, commandStr }) => {
|
|
const app = window.app!
|
|
const randomSuffix = Math.random().toString(36).substring(2, 8)
|
|
const extensionName = `TestExtension_${randomSuffix}`
|
|
|
|
app.registerExtension({
|
|
name: extensionName,
|
|
commands: [
|
|
{
|
|
id: commandId,
|
|
// oxlint-disable-next-line no-eval -- intentional: eval reconstructs a serialized function inside Playwright's page context
|
|
function: eval(commandStr)
|
|
}
|
|
]
|
|
})
|
|
},
|
|
{ commandId, commandStr: command.toString() }
|
|
)
|
|
}
|
|
|
|
async registerKeybinding(
|
|
keyCombo: KeyCombo,
|
|
command: () => void
|
|
): Promise<void> {
|
|
// SECURITY: eval() is intentionally used here to deserialize/execute functions
|
|
// passed from controlled test code across the Node/Playwright browser boundary.
|
|
// Execution happens in isolated Playwright browser contexts with test-only data.
|
|
// This pattern is unsafe for production and must not be copied elsewhere.
|
|
await this.page.evaluate(
|
|
({ keyCombo, commandStr }) => {
|
|
const app = window.app!
|
|
const randomSuffix = Math.random().toString(36).substring(2, 8)
|
|
const extensionName = `TestExtension_${randomSuffix}`
|
|
const commandId = `TestCommand_${randomSuffix}`
|
|
|
|
app.registerExtension({
|
|
name: extensionName,
|
|
keybindings: [
|
|
{
|
|
combo: keyCombo,
|
|
commandId: commandId
|
|
}
|
|
],
|
|
commands: [
|
|
{
|
|
id: commandId,
|
|
// oxlint-disable-next-line no-eval -- intentional: eval reconstructs a serialized function inside Playwright's page context
|
|
function: eval(commandStr)
|
|
}
|
|
]
|
|
})
|
|
},
|
|
{ keyCombo, commandStr: command.toString() }
|
|
)
|
|
}
|
|
}
|