mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
103 lines
3.0 KiB
TypeScript
103 lines
3.0 KiB
TypeScript
import {
|
|
comfyPageFixture as test,
|
|
comfyExpect as expect
|
|
} from '@e2e/fixtures/ComfyPage'
|
|
|
|
test.describe('Bottom Panel Logs', { tag: '@ui' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
})
|
|
|
|
test('should open bottom panel via toggle button', async ({ comfyPage }) => {
|
|
const { bottomPanel } = comfyPage
|
|
|
|
await expect(bottomPanel.root).not.toBeVisible()
|
|
await bottomPanel.toggleButton.click()
|
|
await expect(bottomPanel.root).toBeVisible()
|
|
})
|
|
|
|
test('should show Logs tab when terminal panel opens', async ({
|
|
comfyPage
|
|
}) => {
|
|
const { bottomPanel } = comfyPage
|
|
|
|
await bottomPanel.toggleButton.click()
|
|
await expect(bottomPanel.root).toBeVisible()
|
|
|
|
const logsTab = comfyPage.page.getByRole('tab', { name: /Logs/i })
|
|
await expect(logsTab).toBeVisible()
|
|
})
|
|
|
|
test('should close bottom panel via toggle button', async ({ comfyPage }) => {
|
|
const { bottomPanel } = comfyPage
|
|
|
|
await bottomPanel.toggleButton.click()
|
|
await expect(bottomPanel.root).toBeVisible()
|
|
|
|
await bottomPanel.toggleButton.click()
|
|
await expect(bottomPanel.root).not.toBeVisible()
|
|
})
|
|
|
|
test('should switch between shortcuts and terminal panels', async ({
|
|
comfyPage
|
|
}) => {
|
|
const { bottomPanel } = comfyPage
|
|
|
|
await bottomPanel.keyboardShortcutsButton.click()
|
|
await expect(bottomPanel.root).toBeVisible()
|
|
await expect(
|
|
comfyPage.page.locator('[id*="tab_shortcuts-essentials"]')
|
|
).toBeVisible()
|
|
|
|
await bottomPanel.toggleButton.click()
|
|
|
|
const logsTab = comfyPage.page.getByRole('tab', { name: /Logs/i })
|
|
await expect(logsTab).toBeVisible()
|
|
await expect(
|
|
comfyPage.page.locator('[id*="tab_shortcuts-essentials"]')
|
|
).not.toBeVisible()
|
|
})
|
|
|
|
test('should persist Logs tab content in bottom panel', async ({
|
|
comfyPage
|
|
}) => {
|
|
const { bottomPanel } = comfyPage
|
|
|
|
await bottomPanel.toggleButton.click()
|
|
await expect(bottomPanel.root).toBeVisible()
|
|
|
|
const logsTab = comfyPage.page.getByRole('tab', { name: /Logs/i })
|
|
await expect(logsTab).toBeVisible()
|
|
|
|
const isAlreadyActive =
|
|
(await logsTab.getAttribute('aria-selected')) === 'true'
|
|
if (!isAlreadyActive) {
|
|
await logsTab.click()
|
|
}
|
|
|
|
const xtermContainer = bottomPanel.root.locator('.xterm')
|
|
await expect(xtermContainer).toBeVisible()
|
|
})
|
|
|
|
test('should render xterm container in terminal panel', async ({
|
|
comfyPage
|
|
}) => {
|
|
const { bottomPanel } = comfyPage
|
|
|
|
await bottomPanel.toggleButton.click()
|
|
await expect(bottomPanel.root).toBeVisible()
|
|
|
|
const logsTab = comfyPage.page.getByRole('tab', { name: /Logs/i })
|
|
await expect(logsTab).toBeVisible()
|
|
|
|
const isAlreadyActive =
|
|
(await logsTab.getAttribute('aria-selected')) === 'true'
|
|
if (!isAlreadyActive) {
|
|
await logsTab.click()
|
|
}
|
|
|
|
const xtermScreen = bottomPanel.root.locator('.xterm, .xterm-screen')
|
|
await expect(xtermScreen.first()).toBeVisible()
|
|
})
|
|
})
|