mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 06:20:11 +00:00
*PR Created by the Glary-Bot Agent* --- ## Summary - Replace all `as unknown as Type` assertions in 59 unit test files with type-safe `@total-typescript/shoehorn` functions - Use `fromPartial<Type>()` for partial mock objects where deep-partial type-checks (21 files) - Use `fromAny<Type>()` for fundamentally incompatible types: null, undefined, primitives, variables, class expressions, and mocks with test-specific extra properties that `PartialDeepObject` rejects (remaining files) - All explicit type parameters preserved so TypeScript return types are correct - Browser test `.spec.ts` files excluded (shoehorn unavailable in `page.evaluate` browser context) ## Verification - `pnpm typecheck` ✅ - `pnpm lint` ✅ - `pnpm format` ✅ - Pre-commit hooks passed (format + oxlint + eslint + typecheck) - Migrated test files verified passing (ran representative subset) - No test behavior changes — only type assertion syntax changed - No UI changes — screenshots not applicable ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10761-test-migrate-as-unknown-as-to-total-typescript-shoehorn-3336d73d365081f6b8adc44db5dcc380) by [Unito](https://www.unito.io) --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com>
114 lines
3.1 KiB
TypeScript
114 lines
3.1 KiB
TypeScript
import { fromAny, fromPartial } from '@total-typescript/shoehorn'
|
|
import { describe, expect, it } from 'vitest'
|
|
|
|
import type {
|
|
LGraph,
|
|
LGraphNode,
|
|
Subgraph
|
|
} from '@/lib/litegraph/src/litegraph'
|
|
import type { ComfyNodeDefImpl } from '@/stores/nodeDefStore'
|
|
import {
|
|
collectMissingNodes,
|
|
graphHasMissingNodes
|
|
} from '@/workbench/extensions/manager/utils/graphHasMissingNodes'
|
|
import type { NodeDefLookup } from '@/workbench/extensions/manager/utils/graphHasMissingNodes'
|
|
|
|
type NodeDefs = NodeDefLookup
|
|
|
|
let nodeIdCounter = 0
|
|
const mockNodeDef = {} as ComfyNodeDefImpl
|
|
|
|
const createGraph = (nodes: LGraphNode[] = []): LGraph => {
|
|
return fromPartial<LGraph>({ nodes })
|
|
}
|
|
|
|
const createSubgraph = (nodes: LGraphNode[]): Subgraph => {
|
|
return fromPartial<Subgraph>({ nodes })
|
|
}
|
|
|
|
const createNode = (
|
|
type?: string,
|
|
subgraphNodes?: LGraphNode[]
|
|
): LGraphNode => {
|
|
return fromAny<LGraphNode, unknown>({
|
|
id: nodeIdCounter++,
|
|
type,
|
|
isSubgraphNode: subgraphNodes ? () => true : undefined,
|
|
subgraph: subgraphNodes ? createSubgraph(subgraphNodes) : undefined
|
|
})
|
|
}
|
|
|
|
describe('graphHasMissingNodes', () => {
|
|
it('returns false when graph is null', () => {
|
|
expect(graphHasMissingNodes(null, {})).toBe(false)
|
|
})
|
|
|
|
it('returns false when graph is undefined', () => {
|
|
expect(graphHasMissingNodes(undefined, {})).toBe(false)
|
|
})
|
|
|
|
it('returns false when graph has no nodes', () => {
|
|
expect(graphHasMissingNodes(createGraph(), {})).toBe(false)
|
|
})
|
|
|
|
it('returns false when every node has a definition', () => {
|
|
const graph = createGraph([createNode('FooNode'), createNode('BarNode')])
|
|
const nodeDefs: NodeDefs = {
|
|
FooNode: mockNodeDef,
|
|
BarNode: mockNodeDef
|
|
}
|
|
|
|
expect(graphHasMissingNodes(graph, nodeDefs)).toBe(false)
|
|
})
|
|
|
|
it('returns true when at least one node is missing', () => {
|
|
const graph = createGraph([
|
|
createNode('FooNode'),
|
|
createNode('MissingNode')
|
|
])
|
|
const nodeDefs: NodeDefs = {
|
|
FooNode: mockNodeDef
|
|
}
|
|
|
|
expect(graphHasMissingNodes(graph, nodeDefs)).toBe(true)
|
|
})
|
|
|
|
it('checks nodes nested in subgraphs', () => {
|
|
const graph = createGraph([
|
|
createNode('ContainerNode', [createNode('InnerMissing')])
|
|
])
|
|
const nodeDefs: NodeDefs = {
|
|
ContainerNode: mockNodeDef
|
|
}
|
|
|
|
const missingNodes = collectMissingNodes(graph, nodeDefs)
|
|
expect(missingNodes).toHaveLength(1)
|
|
expect(missingNodes[0]?.type).toBe('InnerMissing')
|
|
})
|
|
|
|
it('ignores nodes without a type', () => {
|
|
const graph = createGraph([createNode(undefined), createNode(null!)])
|
|
|
|
expect(graphHasMissingNodes(graph, {})).toBe(false)
|
|
})
|
|
|
|
it('traverses deeply nested subgraphs', () => {
|
|
const deepGraph = createGraph([
|
|
createNode('Layer1', [
|
|
createNode('Layer2', [
|
|
createNode('Layer3', [createNode('MissingDeep')])
|
|
])
|
|
])
|
|
])
|
|
const nodeDefs: NodeDefs = {
|
|
Layer1: mockNodeDef,
|
|
Layer2: mockNodeDef,
|
|
Layer3: mockNodeDef
|
|
}
|
|
|
|
const missingNodes = collectMissingNodes(deepGraph, nodeDefs)
|
|
expect(missingNodes).toHaveLength(1)
|
|
expect(missingNodes[0]?.type).toBe('MissingDeep')
|
|
})
|
|
})
|