mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-24 22:58:08 +00:00
de1c1ee1f2
## Summary API and other legacy JSON generated by python `json.dumps` can contain `NaN` and `Infinity` which cannot be parsed with JS `JSON.parse`. This adds regex to replace these invalid tokens with `null`. ## Changes - **What**: - add regex replace on bare NaN/infinity tokens after JSON.parse fails - update call sites - tests ## Review Focus - The regex should only rewrite bare NaN/-Infinity/Infinity and not touch string values or other invalid tokens. - A small regex was chosen over JSON5 due to package size (30.3kB Minified, 9kB Minified + Gzipped) or a manual parser due to the unnecessarily complexity vs a single regex replace. - The happy path is run first, the safe parse is only executed if that failed, meaning no overhead the vast majority of the time and no possiblity of corrupting valid workflows due to a bug in the fallback parser - Multiple call sites had to be updated due to pre-existing architecture of the various parsers, an issue for unifying these is logged for future cleanup - New binary fixtures added for validating e2e import using real files ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-12217-fix-add-support-for-parsing-python-generated-json-with-NaN-infinite-35f6d73d365081889fc7f4af823f29c1) by [Unito](https://www.unito.io)
68 lines
2.0 KiB
TypeScript
68 lines
2.0 KiB
TypeScript
import fs from 'fs'
|
|
import path from 'path'
|
|
import { afterEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
import {
|
|
EXPECTED_PROMPT,
|
|
EXPECTED_PROMPT_NAN_COERCED,
|
|
EXPECTED_WORKFLOW,
|
|
mockFileReaderAbort,
|
|
mockFileReaderError
|
|
} from './__fixtures__/helpers'
|
|
import { getFromIsobmffFile } from './isobmff'
|
|
|
|
const fixturePath = path.resolve(__dirname, '__fixtures__/with_metadata.mp4')
|
|
const nanFixturePath = path.resolve(
|
|
__dirname,
|
|
'__fixtures__/with_nan_metadata.mp4'
|
|
)
|
|
|
|
describe('ISOBMFF (MP4) metadata', () => {
|
|
it('extracts workflow and prompt from QuickTime keys/ilst boxes', async () => {
|
|
const bytes = fs.readFileSync(fixturePath)
|
|
const file = new File([bytes], 'test.mp4', { type: 'video/mp4' })
|
|
|
|
const result = await getFromIsobmffFile(file)
|
|
|
|
expect(result.workflow).toEqual(EXPECTED_WORKFLOW)
|
|
expect(result.prompt).toEqual(EXPECTED_PROMPT)
|
|
})
|
|
|
|
it('parses Python generated prompt with bare NaN/Infinity tokens', async () => {
|
|
const bytes = fs.readFileSync(nanFixturePath)
|
|
const file = new File([bytes], 'nan.mp4', { type: 'video/mp4' })
|
|
|
|
const result = await getFromIsobmffFile(file)
|
|
|
|
expect(result.workflow).toBeUndefined()
|
|
expect(result.prompt).toEqual(EXPECTED_PROMPT_NAN_COERCED)
|
|
})
|
|
|
|
it('returns empty for non-ISOBMFF data', async () => {
|
|
const file = new File([new Uint8Array(16)], 'fake.mp4', {
|
|
type: 'video/mp4'
|
|
})
|
|
|
|
const result = await getFromIsobmffFile(file)
|
|
|
|
expect(result).toEqual({})
|
|
})
|
|
|
|
describe('FileReader failure modes', () => {
|
|
afterEach(() => vi.restoreAllMocks())
|
|
|
|
const file = new File([new Uint8Array(16)], 'test.mp4')
|
|
|
|
it('resolves empty when the FileReader fires error', async () => {
|
|
vi.spyOn(console, 'error').mockImplementation(() => {})
|
|
mockFileReaderError('readAsArrayBuffer')
|
|
expect(await getFromIsobmffFile(file)).toEqual({})
|
|
})
|
|
|
|
it('resolves empty when the FileReader fires abort', async () => {
|
|
mockFileReaderAbort('readAsArrayBuffer')
|
|
expect(await getFromIsobmffFile(file)).toEqual({})
|
|
})
|
|
})
|
|
})
|