mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-19 06:20:10 +00:00
Continuation of #6034 with - Updated synchronization for seed - Properly truncates the displayed widget value for the button - Synchronizes control after generate state with litegraph and allows for serialization Several issues from original PR have not (yet) been addressed, but are likely better moved to future PR - fix step value being 10 (legacy system) - ensure it works with COMBO (Fixed in #7095) - ensure it works with FLOAT (Fixed in #7095) - either implement or remove the config button functionality - think it should open settings? <img width="280" height="694" alt="image" src="https://github.com/user-attachments/assets/f36f1cb0-237d-4bfc-bff1-e4976775cf98" /> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6985-Support-control-after-generate-in-vue-2b86d73d365081d8b01ce489d887ff00) by [Unito](https://www.unito.io) --------- Co-authored-by: bymyself <cbyrne@comfy.org> Co-authored-by: github-actions <github-actions@github.com>
164 lines
4.8 KiB
TypeScript
164 lines
4.8 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
import { NumberControlRegistry } from '@/renderer/extensions/vueNodes/widgets/services/NumberControlRegistry'
|
|
|
|
// Mock the settings store
|
|
const mockGetSetting = vi.fn()
|
|
vi.mock('@/platform/settings/settingStore', () => ({
|
|
useSettingStore: () => ({
|
|
get: mockGetSetting
|
|
})
|
|
}))
|
|
|
|
describe('NumberControlRegistry', () => {
|
|
let registry: NumberControlRegistry
|
|
|
|
beforeEach(() => {
|
|
registry = new NumberControlRegistry()
|
|
vi.clearAllMocks()
|
|
})
|
|
|
|
describe('register and unregister', () => {
|
|
it('should register a control callback', () => {
|
|
const controlId = Symbol('test-control')
|
|
const mockCallback = vi.fn()
|
|
|
|
registry.register(controlId, mockCallback)
|
|
|
|
expect(registry.getControlCount()).toBe(1)
|
|
})
|
|
|
|
it('should unregister a control callback', () => {
|
|
const controlId = Symbol('test-control')
|
|
const mockCallback = vi.fn()
|
|
|
|
registry.register(controlId, mockCallback)
|
|
expect(registry.getControlCount()).toBe(1)
|
|
|
|
registry.unregister(controlId)
|
|
expect(registry.getControlCount()).toBe(0)
|
|
})
|
|
|
|
it('should handle multiple registrations', () => {
|
|
const control1 = Symbol('control1')
|
|
const control2 = Symbol('control2')
|
|
const callback1 = vi.fn()
|
|
const callback2 = vi.fn()
|
|
|
|
registry.register(control1, callback1)
|
|
registry.register(control2, callback2)
|
|
|
|
expect(registry.getControlCount()).toBe(2)
|
|
|
|
registry.unregister(control1)
|
|
expect(registry.getControlCount()).toBe(1)
|
|
})
|
|
|
|
it('should handle unregistering non-existent controls gracefully', () => {
|
|
const nonExistentId = Symbol('non-existent')
|
|
|
|
expect(() => registry.unregister(nonExistentId)).not.toThrow()
|
|
expect(registry.getControlCount()).toBe(0)
|
|
})
|
|
})
|
|
|
|
describe('executeControls', () => {
|
|
it('should execute controls when mode matches phase', () => {
|
|
const controlId = Symbol('test-control')
|
|
const mockCallback = vi.fn()
|
|
|
|
// Mock setting store to return 'before'
|
|
mockGetSetting.mockReturnValue('before')
|
|
|
|
registry.register(controlId, mockCallback)
|
|
registry.executeControls('before')
|
|
|
|
expect(mockCallback).toHaveBeenCalledTimes(1)
|
|
expect(mockGetSetting).toHaveBeenCalledWith('Comfy.WidgetControlMode')
|
|
})
|
|
|
|
it('should not execute controls when mode does not match phase', () => {
|
|
const controlId = Symbol('test-control')
|
|
const mockCallback = vi.fn()
|
|
|
|
// Mock setting store to return 'after'
|
|
mockGetSetting.mockReturnValue('after')
|
|
|
|
registry.register(controlId, mockCallback)
|
|
registry.executeControls('before')
|
|
|
|
expect(mockCallback).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('should execute all registered controls when mode matches', () => {
|
|
const control1 = Symbol('control1')
|
|
const control2 = Symbol('control2')
|
|
const callback1 = vi.fn()
|
|
const callback2 = vi.fn()
|
|
|
|
mockGetSetting.mockReturnValue('before')
|
|
|
|
registry.register(control1, callback1)
|
|
registry.register(control2, callback2)
|
|
registry.executeControls('before')
|
|
|
|
expect(callback1).toHaveBeenCalledTimes(1)
|
|
expect(callback2).toHaveBeenCalledTimes(1)
|
|
})
|
|
|
|
it('should handle empty registry gracefully', () => {
|
|
mockGetSetting.mockReturnValue('before')
|
|
|
|
expect(() => registry.executeControls('before')).not.toThrow()
|
|
expect(mockGetSetting).toHaveBeenCalledWith('Comfy.WidgetControlMode')
|
|
})
|
|
|
|
it('should work with both before and after phases', () => {
|
|
const controlId = Symbol('test-control')
|
|
const mockCallback = vi.fn()
|
|
|
|
registry.register(controlId, mockCallback)
|
|
|
|
// Test 'before' phase
|
|
mockGetSetting.mockReturnValue('before')
|
|
registry.executeControls('before')
|
|
expect(mockCallback).toHaveBeenCalledTimes(1)
|
|
|
|
// Test 'after' phase
|
|
mockGetSetting.mockReturnValue('after')
|
|
registry.executeControls('after')
|
|
expect(mockCallback).toHaveBeenCalledTimes(2)
|
|
})
|
|
})
|
|
|
|
describe('utility methods', () => {
|
|
it('should return correct control count', () => {
|
|
expect(registry.getControlCount()).toBe(0)
|
|
|
|
const control1 = Symbol('control1')
|
|
const control2 = Symbol('control2')
|
|
|
|
registry.register(control1, vi.fn())
|
|
expect(registry.getControlCount()).toBe(1)
|
|
|
|
registry.register(control2, vi.fn())
|
|
expect(registry.getControlCount()).toBe(2)
|
|
|
|
registry.unregister(control1)
|
|
expect(registry.getControlCount()).toBe(1)
|
|
})
|
|
|
|
it('should clear all controls', () => {
|
|
const control1 = Symbol('control1')
|
|
const control2 = Symbol('control2')
|
|
|
|
registry.register(control1, vi.fn())
|
|
registry.register(control2, vi.fn())
|
|
expect(registry.getControlCount()).toBe(2)
|
|
|
|
registry.clear()
|
|
expect(registry.getControlCount()).toBe(0)
|
|
})
|
|
})
|
|
})
|