threaded loaded errors #109

New issue

Closed

opened 2026-10-26 22:24:38 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:24:38 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-aimdo/pull/80
Author: @rattus128
Created: 8/4/2026
Status: ✅ Merged
Merged: 8/4/2026
Merged by: @rattus128

Base: master ← Head: dev/threaded-loaded-errors

📝 Commits (6)

a5258f8 add CHECK_CU_OOM_ERROR
8d9e358 Add ERROR logging for all possible failure paths of read_file_slice
e28fa47 Add ERROR logging for all possible failure paths of read_file_slice
5cb5c5c Add CHECK_CU_ERROR logging
66c036b Route native logs through Python logging
cf39c84 fix namespace collision

📊 Changes

20 files changed (+201 additions, -85 deletions)

View changed files

📝 comfy_aimdo/control.py (+26 -2)
📝 src-cuda/dispatch.c (+7 -7)
📝 src-hip/dispatch.c (+2 -2)
📝 src-posix/cuda-funchooks.c (+6 -6)
📝 src-posix/hostbuf-plat.c (+1 -1)
📝 src-posix/model-mmap.c (+7 -7)
📝 src-posix/module-load.c (+1 -1)
📝 src-posix/xfer-file-plat.c (+1 -1)
📝 src-win/cuda-detour.c (+4 -4)
📝 src-win/model-mmap.c (+12 -12)
📝 src-win/module-load.c (+1 -1)
📝 src-win/xfer-file-plat.c (+20 -4)
📝 src/debug.c (+37 -2)
📝 src/hostbuf-file-reader.c (+25 -9)
📝 src/hostbuf.c (+24 -6)
📝 src/model-vbar.c (+3 -3)
📝 src/plat.h (+15 -13)
📝 src/pyt-cu-plug-alloc.c (+1 -1)
📝 src/vrambuf.c (+3 -3)
📝 src/xfer-file.c (+5 -0)

📄 Description

Add more robust error reporting to comfy-aimdo.

Promote a range of error conditions to the error level and log to python logging.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-aimdo/pull/80 **Author:** [@rattus128](https://github.com/rattus128) **Created:** 8/4/2026 **Status:** ✅ Merged **Merged:** 8/4/2026 **Merged by:** [@rattus128](https://github.com/rattus128) **Base:** `master` ← **Head:** `dev/threaded-loaded-errors` --- ### 📝 Commits (6) - [`a5258f8`](https://github.com/Comfy-Org/comfy-aimdo/commit/a5258f86216b0a213a802951fcffaa7bbf602725) add CHECK_CU_OOM_ERROR - [`8d9e358`](https://github.com/Comfy-Org/comfy-aimdo/commit/8d9e3586138a34f05cedcaed2a8a4d7408a47ccd) Add ERROR logging for all possible failure paths of read_file_slice - [`e28fa47`](https://github.com/Comfy-Org/comfy-aimdo/commit/e28fa47e9cea2bb8eaaf0242d9e3772ca1f4b3cf) Add ERROR logging for all possible failure paths of read_file_slice - [`5cb5c5c`](https://github.com/Comfy-Org/comfy-aimdo/commit/5cb5c5cf7df04bb757e350dbadc2593b8aac23c9) Add CHECK_CU_ERROR logging - [`66c036b`](https://github.com/Comfy-Org/comfy-aimdo/commit/66c036b7d2d424c42707d47eb306d32ca38564fc) Route native logs through Python logging - [`cf39c84`](https://github.com/Comfy-Org/comfy-aimdo/commit/cf39c84d35d2832029c3957f05350783f8c71b74) fix namespace collision ### 📊 Changes **20 files changed** (+201 additions, -85 deletions) <details> <summary>View changed files</summary> 📝 `comfy_aimdo/control.py` (+26 -2) 📝 `src-cuda/dispatch.c` (+7 -7) 📝 `src-hip/dispatch.c` (+2 -2) 📝 `src-posix/cuda-funchooks.c` (+6 -6) 📝 `src-posix/hostbuf-plat.c` (+1 -1) 📝 `src-posix/model-mmap.c` (+7 -7) 📝 `src-posix/module-load.c` (+1 -1) 📝 `src-posix/xfer-file-plat.c` (+1 -1) 📝 `src-win/cuda-detour.c` (+4 -4) 📝 `src-win/model-mmap.c` (+12 -12) 📝 `src-win/module-load.c` (+1 -1) 📝 `src-win/xfer-file-plat.c` (+20 -4) 📝 `src/debug.c` (+37 -2) 📝 `src/hostbuf-file-reader.c` (+25 -9) 📝 `src/hostbuf.c` (+24 -6) 📝 `src/model-vbar.c` (+3 -3) 📝 `src/plat.h` (+15 -13) 📝 `src/pyt-cu-plug-alloc.c` (+1 -1) 📝 `src/vrambuf.c` (+3 -3) 📝 `src/xfer-file.c` (+5 -0) </details> ### 📄 Description Add more robust error reporting to comfy-aimdo. Promote a range of error conditions to the error level and log to python logging. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:24:38 +00:00