[PR #6] [MERGED] cuda-detour: go via the the cuda Driver API #56

Closed
opened 2026-10-26 22:24:10 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-aimdo/pull/6
Author: @rattus128
Created: 2/25/2026
Status: ✅ Merged
Merged: 2/25/2026
Merged by: @rattus128

Base: master ← Head: dev/cuda13-fix2


📝 Commits (1)

  • 69035b9 cuda-detour: go via the the cuda Driver API

📊 Changes

4 files changed (+93 additions, -50 deletions)

View changed files

📝 src-win/cuda-detour.c (+48 -28)
📝 src/plat.h (+8 -6)
📝 src/pyt-cu-plug-alloc-async.c (+32 -11)
📝 src/pyt-cu-plug-alloc.c (+5 -5)

📄 Description

cuda13 cudart on Windows is statically linked. Fail. Rehook via the driver API.

Contribution Agreement

  • [ X ] I agree that my contributions are licensed under the GPLv3.
  • [ X ] I grant Comfy Org the rights to relicense these contributions as outlined in CONTRIBUTING.md.

Covert the hook to the driver API so it works with CU13+Windows. Linux unchanged with some code refactoring.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-aimdo/pull/6 **Author:** [@rattus128](https://github.com/rattus128) **Created:** 2/25/2026 **Status:** ✅ Merged **Merged:** 2/25/2026 **Merged by:** [@rattus128](https://github.com/rattus128) **Base:** `master` ← **Head:** `dev/cuda13-fix2` --- ### 📝 Commits (1) - [`69035b9`](https://github.com/Comfy-Org/comfy-aimdo/commit/69035b9fb90f4824e684d7ffcf6c134b5d1d2b5e) cuda-detour: go via the the cuda Driver API ### 📊 Changes **4 files changed** (+93 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `src-win/cuda-detour.c` (+48 -28) 📝 `src/plat.h` (+8 -6) 📝 `src/pyt-cu-plug-alloc-async.c` (+32 -11) 📝 `src/pyt-cu-plug-alloc.c` (+5 -5) </details> ### 📄 Description cuda13 cudart on Windows is statically linked. Fail. Rehook via the driver API. ### Contribution Agreement - [ X ] I agree that my contributions are licensed under the GPLv3. - [ X ] I grant **Comfy Org** the rights to relicense these contributions as outlined in [CONTRIBUTING.md](./CONTRIBUTING.md). Covert the hook to the driver API so it works with CU13+Windows. Linux unchanged with some code refactoring. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 22:24:10 +00:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/comfy-aimdo#56
No description provided.