[PR #10] [MERGED] Prs/align vram buf #59

New issue

Closed

opened 2026-10-26 22:24:12 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:24:12 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-aimdo/pull/10
Author: @rattus128
Created: 3/2/2026
Status: ✅ Merged
Merged: 3/2/2026
Merged by: @rattus128

Base: master ← Head: prs/align-vram-buf

📝 Commits (4)

4b9a716 vrambuf: add log for failed alloc
4780eb7 factor out ALIGN_UP macro
0476ec7 alloc: move VMM size alignment from alloc_fn into vrambuf_create
3ad284b trivial cleanup

📊 Changes

4 files changed (+15 additions, -17 deletions)

View changed files

📝 src/plat.h (+6 -0)
📝 src/pyt-cu-plug-alloc-async.c (+2 -4)
📝 src/pyt-cu-plug-alloc.c (+3 -12)
📝 src/vrambuf.c (+4 -1)

📄 Description

Contribution Agreement

[ X ] I agree that my contributions are licensed under the GPLv3.
[ X ] I grant Comfy Org the rights to relicense these contributions as outlined in CONTRIBUTING.md.

There are non-allocator cuMemAlloc paths that can pass non aligned > 2MB sizes. Handle with a universal round up to the 2MB standard.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-aimdo/pull/10 **Author:** [@rattus128](https://github.com/rattus128) **Created:** 3/2/2026 **Status:** ✅ Merged **Merged:** 3/2/2026 **Merged by:** [@rattus128](https://github.com/rattus128) **Base:** `master` ← **Head:** `prs/align-vram-buf` --- ### 📝 Commits (4) - [`4b9a716`](https://github.com/Comfy-Org/comfy-aimdo/commit/4b9a716b9a3487918716bc3778893ee3e1a1b1b1) vrambuf: add log for failed alloc - [`4780eb7`](https://github.com/Comfy-Org/comfy-aimdo/commit/4780eb7612bdd0033df2aaf66481dd24cba790d1) factor out ALIGN_UP macro - [`0476ec7`](https://github.com/Comfy-Org/comfy-aimdo/commit/0476ec7b33e0c0605bff88783c5390dc9ab9a468) alloc: move VMM size alignment from alloc_fn into vrambuf_create - [`3ad284b`](https://github.com/Comfy-Org/comfy-aimdo/commit/3ad284b7bd068110911de3c9598aced3ac897e93) trivial cleanup ### 📊 Changes **4 files changed** (+15 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/plat.h` (+6 -0) 📝 `src/pyt-cu-plug-alloc-async.c` (+2 -4) 📝 `src/pyt-cu-plug-alloc.c` (+3 -12) 📝 `src/vrambuf.c` (+4 -1) </details> ### 📄 Description ### Contribution Agreement - [ X ] I agree that my contributions are licensed under the GPLv3. - [ X ] I grant **Comfy Org** the rights to relicense these contributions as outlined in [CONTRIBUTING.md](./CONTRIBUTING.md). There are non-allocator cuMemAlloc paths that can pass non aligned > 2MB sizes. Handle with a universal round up to the 2MB standard. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:24:12 +00:00