mirror of
https://github.com/Comfy-Org/comfy-aimdo.git
synced 2026-11-04 23:37:21 +00:00
[PR #20] [MERGED] allocators: Dont use the VMA allocator for cuda_malloc #65
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Comfy-Org/comfy-aimdo#65
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Comfy-Org/comfy-aimdo/pull/20
Author: @rattus128
Created: 3/11/2026
Status: ✅ Merged
Merged: 3/11/2026
Merged by: @rattus128
Base:
master← Head:dev/vanilla-cuda-malloc📝 Commits (1)
1c6fa0dallocators: Dont use the VMA allocator for cuda_malloc📊 Changes
4 files changed (+125 additions, -72 deletions)
View changed files
📝
src-win/cuda-detour.c(+2 -2)📝
src/plat.h(+4 -6)📝
src/pyt-cu-plug-alloc-async.c(+119 -42)📝
src/pyt-cu-plug-alloc.c(+0 -22)📄 Description
This has some closed-source synchronization semantics so its actually impossible to self implement safely. Its subject to more fragmentation than the main allocator, but just add a little bit of extra headroom. Rejig the code to make the linux wrappers the same as for the async allocators.
Contribution Agreement
Example Test Conditions:
This test case (vibe code):
foo.py
Before:
After:
Windows:
before:
after:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.