[PR #77] [CLOSED] Triton Backend - Ensure different dim1/dim2 matched against freqs_cis independently #127

New issue

Closed

opened 2026-10-26 22:20:38 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:20:38 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-kitchen/pull/77
Author: @sleppyrobot
Created: 7/14/2026
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (1)

bd7ddf9 Ensure different dim1/dim2 matched against freqs_cis independently

📊 Changes

1 file changed (+39 additions, -17 deletions)

View changed files

📝 comfy_kitchen/backends/triton/rope.py (+39 -17)

📄 Description

Since Krea2 launched i have not been able to get it running with --enable-triton-backend on Linux on my 7900xtx, it triggers ; "CUDA error: an illegal memory access was encountered"

Comparing the eager rope.py to the triton revealed an issue that may occur due to the shapes\stride generated by Krea2.

This change mimics the eager logic to allow the model to run, also give a small speed up as triton rope is faster than eager rope.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-kitchen/pull/77 **Author:** [@sleppyrobot](https://github.com/sleppyrobot) **Created:** 7/14/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`bd7ddf9`](https://github.com/Comfy-Org/comfy-kitchen/commit/bd7ddf96c608e0093a5d90fc260bc2b40560e90c) Ensure different dim1/dim2 matched against freqs_cis independently ### 📊 Changes **1 file changed** (+39 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `comfy_kitchen/backends/triton/rope.py` (+39 -17) </details> ### 📄 Description Since Krea2 launched i have not been able to get it running with --enable-triton-backend on Linux on my 7900xtx, it triggers ; "CUDA error: an illegal memory access was encountered" Comparing the eager rope.py to the triton revealed an issue that may occur due to the shapes\stride generated by Krea2. This change mimics the eager logic to allow the model to run, also give a small speed up as triton rope is faster than eager rope. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:20:38 +00:00