[PR #89] [MERGED] Fix HIP backend device detection on ROCm lazy initialization #138

New issue

Closed

opened 2026-10-26 22:20:44 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:20:44 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-kitchen/pull/89
Author: @derfasthirnlosenick
Created: 7/31/2026
Status: ✅ Merged
Merged: 7/31/2026
Merged by: @comfyanonymous

Base: main ← Head: fix-rocm-device-init

📝 Commits (1)

659425b Fix HIP backend device detection on ROCm lazy initialization

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 comfy_kitchen/backends/hip/__init__.py (+4 -0)

📄 Description

Don't know if I missed this when I tested https://github.com/Comfy-Org/comfy-kitchen/pull/74, but with the current build, it fails to detect my 6800xt (RDNA2) card, as it returned a device count of 0.

[INFO] Found comfy_kitchen backend hip: {'available': False, 'disabled': False, 'unavailable_reason': 'no HIP device available', 'capabilities': []}

The fix seems to relatively easy to initialize the device before counting. I've tested it on my machine and it now correctly returns

[INFO] Found comfy_kitchen backend hip: {'available': True, 'disabled': False, 'unavailable_reason': None, 'capabilities': ['adaln', 'apply_rope', 'apply_rope1', 'apply_rope1_', 'apply_rope_', 'apply_rope_split_half', 'apply_rope_split_half1', 'apply_rope_split_half1_', 'apply_rope_split_half_', 'dequantize_convrot_w4a4_weight', 'dequantize_int8_convrot_weight_dtype', 'dequantize_int8_simple_dtype', 'dequantize_per_tensor_fp8', 'gemv_awq_w4a16', 'quantize_and_rotate_rowwise', 'quantize_convrot_w4a4_weight', 'quantize_int8_convrot_weight', 'quantize_int8_rowwise', 'quantize_int8_tensorwise', 'quantize_per_tensor_fp8', 'quantize_svdquant_w4a4', 'rms_adaln', 'rms_rope', 'rms_rope1', 'rms_rope1_', 'rms_rope_', 'rms_rope_split_half', 'rms_rope_split_half1', 'rms_rope_split_half1_', 'rms_rope_split_half_', 'stochastic_rounding_fp8']}

I have read and agree to the DCO, although this fix doesn't really have much intellectual property going for it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-kitchen/pull/89 **Author:** [@derfasthirnlosenick](https://github.com/derfasthirnlosenick) **Created:** 7/31/2026 **Status:** ✅ Merged **Merged:** 7/31/2026 **Merged by:** [@comfyanonymous](https://github.com/comfyanonymous) **Base:** `main` ← **Head:** `fix-rocm-device-init` --- ### 📝 Commits (1) - [`659425b`](https://github.com/Comfy-Org/comfy-kitchen/commit/659425be18f595f88bf679614493521f73b4d986) Fix HIP backend device detection on ROCm lazy initialization ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `comfy_kitchen/backends/hip/__init__.py` (+4 -0) </details> ### 📄 Description Don't know if I missed this when I tested https://github.com/Comfy-Org/comfy-kitchen/pull/74, but with the current build, it fails to detect my 6800xt (RDNA2) card, as it returned a device count of 0. > [INFO] Found comfy_kitchen backend hip: {'available': False, 'disabled': False, 'unavailable_reason': 'no HIP device available', 'capabilities': []} The fix seems to relatively easy to initialize the device before counting. I've tested it on my machine and it now correctly returns > [INFO] Found comfy_kitchen backend hip: {'available': True, 'disabled': False, 'unavailable_reason': None, 'capabilities': ['adaln', 'apply_rope', 'apply_rope1', 'apply_rope1_', 'apply_rope_', 'apply_rope_split_half', 'apply_rope_split_half1', 'apply_rope_split_half1_', 'apply_rope_split_half_', 'dequantize_convrot_w4a4_weight', 'dequantize_int8_convrot_weight_dtype', 'dequantize_int8_simple_dtype', 'dequantize_per_tensor_fp8', 'gemv_awq_w4a16', 'quantize_and_rotate_rowwise', 'quantize_convrot_w4a4_weight', 'quantize_int8_convrot_weight', 'quantize_int8_rowwise', 'quantize_int8_tensorwise', 'quantize_per_tensor_fp8', 'quantize_svdquant_w4a4', 'rms_adaln', 'rms_rope', 'rms_rope1', 'rms_rope1_', 'rms_rope_', 'rms_rope_split_half', 'rms_rope_split_half1', 'rms_rope_split_half1_', 'rms_rope_split_half_', 'stochastic_rounding_fp8']} I have read and agree to the DCO, although this fix doesn't really have much intellectual property going for it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:20:44 +00:00