[PR #109] [CLOSED] Fix HIP SageAttention argument binding #152

New issue

Closed

opened 2026-10-26 22:20:54 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:20:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-kitchen/pull/109
Author: @Yasei-no-otoko
Created: 8/12/2026
Status: ❌ Closed

Base: main ← Head: codex/sage-sdpa-positional-abi

📝 Commits (1)

8cae7d2 Name the HIP sage_sdpa module on ABI mismatch

📊 Changes

3 files changed (+147 additions, -3 deletions)

View changed files

📝 comfy_kitchen/backends/hip/__init__.py (+26 -3)
📝 tests/test_hip_dispatch.py (+77 -0)
📝 tests/test_int8_attention.py (+44 -0)

📄 Description

Summary

pass the optional attn_mask and cta_k arguments positionally to the nanobind sage_sdpa entry point
preserve the existing no-mask and masked launch paths\n\nSome gfx1151 Windows builds expose the same signature but reject cta_k as a keyword, producing sage_sdpa(): incompatible function arguments. The positional call matches the ABI across those builds.

Validation

Python compile check passed\n- fake-backend ABI smoke test passed for masked and unmasked calls
reproduced the original keyword-binding failure and confirmed the corrected argument positions

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-kitchen/pull/109 **Author:** [@Yasei-no-otoko](https://github.com/Yasei-no-otoko) **Created:** 8/12/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `codex/sage-sdpa-positional-abi` --- ### 📝 Commits (1) - [`8cae7d2`](https://github.com/Comfy-Org/comfy-kitchen/commit/8cae7d2eb777eb2568150d43b36b89ad437cc204) Name the HIP sage_sdpa module on ABI mismatch ### 📊 Changes **3 files changed** (+147 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `comfy_kitchen/backends/hip/__init__.py` (+26 -3) 📝 `tests/test_hip_dispatch.py` (+77 -0) 📝 `tests/test_int8_attention.py` (+44 -0) </details> ### 📄 Description ## Summary - pass the optional attn_mask and cta_k arguments positionally to the nanobind sage_sdpa entry point - preserve the existing no-mask and masked launch paths\n\nSome gfx1151 Windows builds expose the same signature but reject cta_k as a keyword, producing sage_sdpa(): incompatible function arguments. The positional call matches the ABI across those builds. ## Validation - Python compile check passed\n- fake-backend ABI smoke test passed for masked and unmasked calls - reproduced the original keyword-binding failure and confirmed the corrected argument positions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:20:54 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/comfy-kitchen#152

No description provided.

Rows
Columns