[PR #255] [MERGED] Fuse input activations into the W4A8/W6A8 quantizer #261

Closed
opened 2026-10-26 22:22:13 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-kitchen/pull/255
Author: @kijai
Created: 10/18/2026
Status: ✅ Merged
Merged: 10/18/2026
Merged by: @comfyanonymous

Base: main ← Head: w4a8-fused-input-act


📝 Commits (3)

  • 4a03b0a Fuse input activations into the W4A8/W6A8 quantizer
  • 9b0526c Match the ConvRot quantizer's shared-memory estimate to its launch, test the fused prefill activation
  • 2a83b87 Fix test

📊 Changes

3 files changed (+88 additions, -23 deletions)

View changed files

📝 comfy_kitchen/backends/cuda/__init__.py (+63 -21)
📝 tests/test_convrot_w4a4.py (+2 -2)
📝 tests/test_w4a8_mma.py (+23 -0)

📄 Description

W4A8/W6A8 linears applied the input activation (swiglu, situ, ...) as a separate pass before quantizing, except for M<=8. The quantizer they use already supports fusing it.

MOSS-Image mixed file now matches int8 speed, and MiniMax-H3 is slightly faster as well.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-kitchen/pull/255 **Author:** [@kijai](https://github.com/kijai) **Created:** 10/18/2026 **Status:** ✅ Merged **Merged:** 10/18/2026 **Merged by:** [@comfyanonymous](https://github.com/comfyanonymous) **Base:** `main` ← **Head:** `w4a8-fused-input-act` --- ### 📝 Commits (3) - [`4a03b0a`](https://github.com/Comfy-Org/comfy-kitchen/commit/4a03b0a64210bc5bf7bfb7d762d20b51d876c7a2) Fuse input activations into the W4A8/W6A8 quantizer - [`9b0526c`](https://github.com/Comfy-Org/comfy-kitchen/commit/9b0526c97932665b2327f2cb5fb4d7c9eebb2a0b) Match the ConvRot quantizer's shared-memory estimate to its launch, test the fused prefill activation - [`2a83b87`](https://github.com/Comfy-Org/comfy-kitchen/commit/2a83b874e026872e3249ae81216c214588c562a4) Fix test ### 📊 Changes **3 files changed** (+88 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `comfy_kitchen/backends/cuda/__init__.py` (+63 -21) 📝 `tests/test_convrot_w4a4.py` (+2 -2) 📝 `tests/test_w4a8_mma.py` (+23 -0) </details> ### 📄 Description W4A8/W6A8 linears applied the input activation (swiglu, situ, ...) as a separate pass before quantizing, except for M<=8. The quantizer they use already supports fusing it. MOSS-Image mixed file now matches int8 speed, and MiniMax-H3 is slightly faster as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 22:22:13 +00:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/comfy-kitchen#261
No description provided.