[PR #33] [CLOSED] Add ROCm backend #93

New issue

Closed

opened 2026-10-26 22:20:18 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:20:18 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-kitchen/pull/33
Author: @0xDELUXA
Created: 3/20/2026
Status: ❌ Closed

Base: main ← Head: feature/rocm-backend

📝 Commits (1)

7d2edfa Add ROCm backend

📊 Changes

8 files changed (+1038 additions, -27 deletions)

View changed files

➕ .github/workflows/rocm.yml (+153 -0)
📝 README.md (+54 -24)
📝 comfy_kitchen/__init__.py (+1 -0)
➕ comfy_kitchen/backends/rocm/__init__.py (+234 -0)
📝 comfy_kitchen/constraints.py (+51 -0)
📝 comfy_kitchen/registry.py (+1 -1)
📝 setup.py (+87 -2)
➕ tests/test_rocm_backend.py (+457 -0)

📄 Description

This PR is not intended for merging as-is. It’s an experiment to explore adding a ROCm backend to comfy-kitchen.

I’d appreciate feedback on whether this direction might be worth pursuing in the future, or if comfy-kitchen will continue focusing primarily on eager execution on AMD ROCm.

Testing was limited to Windows on RDNA4 hardware.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-kitchen/pull/33 **Author:** [@0xDELUXA](https://github.com/0xDELUXA) **Created:** 3/20/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feature/rocm-backend` --- ### 📝 Commits (1) - [`7d2edfa`](https://github.com/Comfy-Org/comfy-kitchen/commit/7d2edfa07ffaa6c023a97239408a1e654e35b218) Add ROCm backend ### 📊 Changes **8 files changed** (+1038 additions, -27 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/rocm.yml` (+153 -0) 📝 `README.md` (+54 -24) 📝 `comfy_kitchen/__init__.py` (+1 -0) ➕ `comfy_kitchen/backends/rocm/__init__.py` (+234 -0) 📝 `comfy_kitchen/constraints.py` (+51 -0) 📝 `comfy_kitchen/registry.py` (+1 -1) 📝 `setup.py` (+87 -2) ➕ `tests/test_rocm_backend.py` (+457 -0) </details> ### 📄 Description This PR is not intended for merging as-is. It’s an experiment to explore adding a ROCm backend to `comfy-kitchen`. I’d appreciate feedback on whether this direction might be worth pursuing in the future, or if `comfy-kitchen` will continue focusing primarily on eager execution on AMD ROCm. Testing was limited to Windows on RDNA4 hardware. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:20:18 +00:00