[PR #6] [MERGED] ci: tag-driven release workflow + accurate install docs #15

New issue

Closed

opened 2026-10-26 22:40:42 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:40:42 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-python-sdk/pull/6
Author: @wei-hai
Created: 7/17/2026
Status: ✅ Merged
Merged: 7/17/2026
Merged by: @wei-hai

Base: main ← Head: ci/tag-driven-release

📝 Commits (2)

5a2e35e ci: tag-driven release workflow + accurate install docs
e3218e6 ci: accept full SemVer release tags in the version guard

📊 Changes

2 files changed (+138 additions, -41 deletions)

View changed files

📝 .github/workflows/publish.yml (+126 -37)
📝 README.md (+12 -4)

📄 Description

Follow-up to #5 (merged) — the tag-driven release workflow and the install-doc update landed on the PR branch after #5 was squash-merged, so they weren't part of the merge.

Tag-driven versioning: the GitHub Release tag (vX.Y.Z) is the single source of truth. publish.yml injects it into pyproject.toml at build time (replacing a tag-vs-manifest check), so the committed version is just a placeholder and cutting a release is a single action — create a GitHub Release with the tag you want, no version-bump commit/PR. Publishes to PyPI via Trusted Publishing (OIDC, no stored token), gated behind a pypi environment with required reviewers; workflow_dispatch is a build + twine check dry run.

Docs: the README's "not yet published" note is replaced with pip install comfy-sdk and the real release process; the from-source path is kept for local dev.

Maintainer setup to enable publishing (registry side): the comfy-sdk PyPI project + Trusted Publisher (owner Comfy-Org, repo ComfyPythonSDK, workflow publish.yml, environment pypi) + the pypi GitHub environment with reviewers.

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-python-sdk/pull/6 **Author:** [@wei-hai](https://github.com/wei-hai) **Created:** 7/17/2026 **Status:** ✅ Merged **Merged:** 7/17/2026 **Merged by:** [@wei-hai](https://github.com/wei-hai) **Base:** `main` ← **Head:** `ci/tag-driven-release` --- ### 📝 Commits (2) - [`5a2e35e`](https://github.com/Comfy-Org/comfy-python-sdk/commit/5a2e35e6390d9890cf9274723b5026d466a5d612) ci: tag-driven release workflow + accurate install docs - [`e3218e6`](https://github.com/Comfy-Org/comfy-python-sdk/commit/e3218e6a73c57fcbb76aff3d549868fa9a391b04) ci: accept full SemVer release tags in the version guard ### 📊 Changes **2 files changed** (+138 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/publish.yml` (+126 -37) 📝 `README.md` (+12 -4) </details> ### 📄 Description Follow-up to #5 (merged) — the tag-driven release workflow and the install-doc update landed on the PR branch after #5 was squash-merged, so they weren't part of the merge. **Tag-driven versioning:** the GitHub Release tag (`vX.Y.Z`) is the single source of truth. `publish.yml` injects it into `pyproject.toml` at build time (replacing a tag-vs-manifest check), so the committed version is just a placeholder and cutting a release is a single action — create a GitHub Release with the tag you want, no version-bump commit/PR. Publishes to PyPI via Trusted Publishing (OIDC, no stored token), gated behind a `pypi` environment with required reviewers; `workflow_dispatch` is a build + `twine check` dry run. **Docs:** the README's "not yet published" note is replaced with `pip install comfy-sdk` and the real release process; the from-source path is kept for local dev. Maintainer setup to enable publishing (registry side): the `comfy-sdk` PyPI project + Trusted Publisher (owner `Comfy-Org`, repo `ComfyPythonSDK`, workflow `publish.yml`, environment `pypi`) + the `pypi` GitHub environment with reviewers. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:40:42 +00:00