[PR #150] [MERGED] docs(changelog): move the queued model surface out of the released 0.2.0 section #151

New issue

Closed

opened 2026-10-31 22:01:49 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:01:49 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-python-sdk/pull/150
Author: @mattmillerai
Created: 9/14/2026
Status: ✅ Merged
Merged: 9/14/2026
Merged by: @mattmillerai

Base: main ← Head: matt/changelog-unfile-queued-surface-from-020

📝 Commits (2)

5a5cf7a docs(changelog): move the queued model surface out of the released 0.2.0 section
1162409 Merge remote-tracking branch 'origin/main' into matt/changelog-unfile-queued-surface-from-020

📊 Changes

1 file changed (+5 additions, -2 deletions)

View changed files

📝 CHANGELOG.md (+5 -2)

📄 Description

ELI-5

The changelog says version 0.2.0 shipped client.models.submit(). It didn't — that code landed today. This moves those notes to the "not released yet" heading so the next release describes what it actually contains.

What happened

#137 was branched while 0.2.0 was still the upcoming version, so it wrote its CHANGELOG entry under ## [0.2.0]. Meanwhile #144 cut 0.2.0 and the v0.2.0 tag shipped. When #137's conflict was resolved on merge, two bullets were filed under a version that never contained them:

The queued model surface (submit / subscribe / handle + RequestHandle)
comfy_sdk.router_exceptions.error_from_completion()

Evidence

The published sdist is the check — comfy_sdk-0.2.0/src/comfy_sdk/models.py defines only run:

$ grep -E "^\s+(async )?def " comfy_sdk-0.2.0/src/comfy_sdk/models.py
    def run(
    async def run(

versus main today, which has run, submit, subscribe and handle on both the sync and async classes.

Verification

The [0.2.0] section is now byte-for-byte identical to the one carried by the v0.2.0 tag (diff against git show v0.2.0:CHANGELOG.md is empty).
Both moved bullets appear exactly once in the file — nothing dropped, nothing duplicated.
Documentation only; no source, test or spec files touched.

Why it matters now

Releases here are tag-driven (publish.yml injects the tag version at build time), so the CHANGELOG is the release narrative. Cutting the next version off main as-is would publish notes crediting 0.2.0 with features it never had, and would leave today's queued surface invisible under [Unreleased].

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-python-sdk/pull/150 **Author:** [@mattmillerai](https://github.com/mattmillerai) **Created:** 9/14/2026 **Status:** ✅ Merged **Merged:** 9/14/2026 **Merged by:** [@mattmillerai](https://github.com/mattmillerai) **Base:** `main` ← **Head:** `matt/changelog-unfile-queued-surface-from-020` --- ### 📝 Commits (2) - [`5a5cf7a`](https://github.com/Comfy-Org/comfy-python-sdk/commit/5a5cf7ae6207a6773daf18f38910a50548af2c3d) docs(changelog): move the queued model surface out of the released 0.2.0 section - [`1162409`](https://github.com/Comfy-Org/comfy-python-sdk/commit/116240915ec069fd932c57367a37786be6d8d17d) Merge remote-tracking branch 'origin/main' into matt/changelog-unfile-queued-surface-from-020 ### 📊 Changes **1 file changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+5 -2) </details> ### 📄 Description ## ELI-5 The changelog says version 0.2.0 shipped `client.models.submit()`. It didn't — that code landed today. This moves those notes to the "not released yet" heading so the next release describes what it actually contains. ## What happened #137 was branched while `0.2.0` was still the *upcoming* version, so it wrote its CHANGELOG entry under `## [0.2.0]`. Meanwhile #144 cut 0.2.0 and the `v0.2.0` tag shipped. When #137's conflict was resolved on merge, two bullets were filed under a version that never contained them: - **The queued model surface** (`submit` / `subscribe` / `handle` + `RequestHandle`) - `comfy_sdk.router_exceptions.error_from_completion()` ## Evidence The published sdist is the check — `comfy_sdk-0.2.0/src/comfy_sdk/models.py` defines only `run`: ``` $ grep -E "^\s+(async )?def " comfy_sdk-0.2.0/src/comfy_sdk/models.py def run( async def run( ``` versus `main` today, which has `run`, `submit`, `subscribe` and `handle` on both the sync and async classes. ## Verification - The `[0.2.0]` section is now byte-for-byte identical to the one carried by the `v0.2.0` tag (`diff` against `git show v0.2.0:CHANGELOG.md` is empty). - Both moved bullets appear exactly once in the file — nothing dropped, nothing duplicated. - Documentation only; no source, test or spec files touched. ## Why it matters now Releases here are tag-driven (`publish.yml` injects the tag version at build time), so the CHANGELOG is the release narrative. Cutting the next version off `main` as-is would publish notes crediting 0.2.0 with features it never had, and would leave today's queued surface invisible under `[Unreleased]`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:01:49 +00:00