[PR #23] [MERGED] fix: ship py.typed so consumers get the SDK's type information #30

New issue

Closed

opened 2026-10-31 22:00:54 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:00:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-python-sdk/pull/23
Author: @robinjhuang
Created: 7/30/2026
Status: ✅ Merged
Merged: 7/30/2026
Merged by: @robinjhuang

Base: main ← Head: fix/pep561-py-typed

📝 Commits (1)

4805537 fix: ship py.typed so consumers get the SDK's type information

📊 Changes

2 files changed (+0 additions, -0 deletions)

View changed files

➕ src/comfy_low/py.typed (+0 -0)
➕ src/comfy_sdk/py.typed (+0 -0)

📄 Description

Both comfy_sdk and comfy_low are fully annotated and mypy-gated in CI, but without a PEP 561 marker none of that reaches users — type checkers report module is installed, but missing library stubs or py.typed marker and silently treat every import as Any.

Verified against a built wheel installed into a clean venv: mypy goes from that error to Success: no issues found. The existing wheel packages config already picks the markers up, so no build change is needed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-python-sdk/pull/23 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 7/30/2026 **Status:** ✅ Merged **Merged:** 7/30/2026 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `fix/pep561-py-typed` --- ### 📝 Commits (1) - [`4805537`](https://github.com/Comfy-Org/comfy-python-sdk/commit/48055372d650a1df54e37e2f649b8114105cf893) fix: ship py.typed so consumers get the SDK's type information ### 📊 Changes **2 files changed** (+0 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `src/comfy_low/py.typed` (+0 -0) ➕ `src/comfy_sdk/py.typed` (+0 -0) </details> ### 📄 Description Both `comfy_sdk` and `comfy_low` are fully annotated and mypy-gated in CI, but without a PEP 561 marker none of that reaches users — type checkers report `module is installed, but missing library stubs or py.typed marker` and silently treat every import as `Any`. Verified against a built wheel installed into a clean venv: mypy goes from that error to `Success: no issues found`. The existing wheel `packages` config already picks the markers up, so no build change is needed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:00:54 +00:00