[PR #24] [MERGED] chore: add MIT license #32

New issue

Closed

opened 2026-10-31 22:00:54 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:00:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-python-sdk/pull/24
Author: @robinjhuang
Created: 7/30/2026
Status: ✅ Merged
Merged: 7/30/2026
Merged by: @robinjhuang

Base: main ← Head: chore/mit-license

📝 Commits (1)

cb1be2f chore: add MIT license

📊 Changes

2 files changed (+23 additions, -0 deletions)

View changed files

➕ LICENSE (+21 -0)
📝 pyproject.toml (+2 -0)

📄 Description

The repo had no LICENSE file and no license metadata, so the built package reported an empty License: field and GitHub detected no license — which leaves it unusable by default for anyone who cares about provenance.

Declared as a PEP 639 SPDX expression; verified it builds to License-Expression: MIT with the LICENSE bundled into the wheel, and twine check passes. No License :: OSI Approved classifier is added on purpose, since PyPI rejects uploads that set both that and License-Expression.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-python-sdk/pull/24 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 7/30/2026 **Status:** ✅ Merged **Merged:** 7/30/2026 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `chore/mit-license` --- ### 📝 Commits (1) - [`cb1be2f`](https://github.com/Comfy-Org/comfy-python-sdk/commit/cb1be2f08c677904fd3079ff592548ce953438f1) chore: add MIT license ### 📊 Changes **2 files changed** (+23 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `LICENSE` (+21 -0) 📝 `pyproject.toml` (+2 -0) </details> ### 📄 Description The repo had no LICENSE file and no license metadata, so the built package reported an empty `License:` field and GitHub detected no license — which leaves it unusable by default for anyone who cares about provenance. Declared as a PEP 639 SPDX expression; verified it builds to `License-Expression: MIT` with the LICENSE bundled into the wheel, and `twine check` passes. No `License :: OSI Approved` classifier is added on purpose, since PyPI rejects uploads that set both that and `License-Expression`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:00:54 +00:00