[PR #26] [MERGED] chore: stop shipping local dev droppings in the sdist #34

New issue

Closed

opened 2026-10-31 22:00:56 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:00:56 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-python-sdk/pull/26
Author: @robinjhuang
Created: 7/30/2026
Status: ✅ Merged
Merged: 7/30/2026
Merged by: @robinjhuang

Base: main ← Head: chore/sdist-hygiene

📝 Commits (1)

ab7ce90 chore: stop shipping local dev droppings in the sdist

📊 Changes

3 files changed (+21 additions, -0 deletions)

View changed files

➖ .coverage (+0 -0)
📝 .gitignore (+6 -0)
📝 pyproject.toml (+15 -0)

📄 Description

.coverage — a 53KB SQLite database from someone's local coverage run — was committed, missing from .gitignore, and published inside the sdist. This untracks it, ignores it along with the other tool caches, and gives the sdist an explicit include list so hatchling stops sweeping in repo-only files (.github/, .coderabbit.yaml, uv.lock).

src/, tests/, spec/ and scripts/ are kept so the suite and the codegen drift check still run from an unpacked tarball; verified with python -m build --sdist + twine check.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-python-sdk/pull/26 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 7/30/2026 **Status:** ✅ Merged **Merged:** 7/30/2026 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `chore/sdist-hygiene` --- ### 📝 Commits (1) - [`ab7ce90`](https://github.com/Comfy-Org/comfy-python-sdk/commit/ab7ce90a08076617b32d872ac9d5604a93ca48fe) chore: stop shipping local dev droppings in the sdist ### 📊 Changes **3 files changed** (+21 additions, -0 deletions) <details> <summary>View changed files</summary> ➖ `.coverage` (+0 -0) 📝 `.gitignore` (+6 -0) 📝 `pyproject.toml` (+15 -0) </details> ### 📄 Description `.coverage` — a 53KB SQLite database from someone's local coverage run — was committed, missing from `.gitignore`, and published inside the sdist. This untracks it, ignores it along with the other tool caches, and gives the sdist an explicit include list so hatchling stops sweeping in repo-only files (`.github/`, `.coderabbit.yaml`, `uv.lock`). `src/`, `tests/`, `spec/` and `scripts/` are kept so the suite and the codegen drift check still run from an unpacked tarball; verified with `python -m build --sdist` + `twine check`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:00:56 +00:00