[PR #27] [MERGED] chore: fill in the empty package metadata #36

Closed
opened 2026-10-31 22:00:56 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-python-sdk/pull/27
Author: @robinjhuang
Created: 7/30/2026
Status: ✅ Merged
Merged: 7/30/2026
Merged by: @robinjhuang

Base: main ← Head: chore/project-metadata


📝 Commits (1)

  • e49b2f1 chore: fill in the empty package metadata

📊 Changes

1 file changed (+23 additions, -0 deletions)

View changed files

📝 pyproject.toml (+23 -0)

📄 Description

Author, Home-page, Project-URL, Keywords and Classifier were all absent from the built artifact, so pip show comfy-sdk gave no route back to the repo or docs, and the PyPI page would carry no filterable metadata — including no signal that 3.10–3.13 are supported, which CI already tests.

Two deliberate omissions: no License :: OSI Approved classifier, since PyPI rejects uploads pairing one with the PEP 639 License-Expression added in #24; and the Typing :: Typed classifier here only becomes truthful once #23 ships the py.typed markers, so that one should merge first.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-python-sdk/pull/27 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 7/30/2026 **Status:** ✅ Merged **Merged:** 7/30/2026 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `chore/project-metadata` --- ### 📝 Commits (1) - [`e49b2f1`](https://github.com/Comfy-Org/comfy-python-sdk/commit/e49b2f15fc5dfe2e5d3be13b247f4f46dd1cedbd) chore: fill in the empty package metadata ### 📊 Changes **1 file changed** (+23 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pyproject.toml` (+23 -0) </details> ### 📄 Description `Author`, `Home-page`, `Project-URL`, `Keywords` and `Classifier` were all absent from the built artifact, so `pip show comfy-sdk` gave no route back to the repo or docs, and the PyPI page would carry no filterable metadata — including no signal that 3.10–3.13 are supported, which CI already tests. Two deliberate omissions: no `License :: OSI Approved` classifier, since PyPI rejects uploads pairing one with the PEP 639 `License-Expression` added in #24; and the `Typing :: Typed` classifier here only becomes truthful once #23 ships the `py.typed` markers, so that one should merge first. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-31 22:00:56 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/comfy-python-sdk#36
No description provided.