[PR #29] [MERGED] chore: make CI catch deprecations, untyped defs, and typos in config #37

New issue

Closed

opened 2026-10-31 22:00:56 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:00:56 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-python-sdk/pull/29
Author: @robinjhuang
Created: 7/30/2026
Status: ✅ Merged
Merged: 7/30/2026
Merged by: @robinjhuang

Base: main ← Head: chore/tighten-tooling-config

📝 Commits (1)

40d0f08 chore: make CI catch deprecations, untyped defs, and typos in config

📊 Changes

1 file changed (+30 additions, -0 deletions)

View changed files

📝 pyproject.toml (+30 -0)

📄 Description

Three gaps where CI currently stays green on things it should catch: dependency deprecation warnings passed silently (so a breaking httpx/pydantic bump would first show up as the breakage), a typo'd pytest marker or malformed ini key no-ops instead of failing, and comfy_sdk ships py.typed while unannotated defs in it were still allowed.

filterwarnings is scoped to Deprecation/PendingDeprecation rather than a blanket error on purpose — the tests' own local HTTP servers emit ResourceWarning on teardown, which turns 63 passing tests red without saying anything about the SDK. Also declares pytest-cov, which was producing a .coverage database locally without being declared anywhere. Verified: suite still 102 passed, mypy clean, and the new override does flag a probe untyped def.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-python-sdk/pull/29 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 7/30/2026 **Status:** ✅ Merged **Merged:** 7/30/2026 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `chore/tighten-tooling-config` --- ### 📝 Commits (1) - [`40d0f08`](https://github.com/Comfy-Org/comfy-python-sdk/commit/40d0f080926fce506838647fee261fcb5959281e) chore: make CI catch deprecations, untyped defs, and typos in config ### 📊 Changes **1 file changed** (+30 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pyproject.toml` (+30 -0) </details> ### 📄 Description Three gaps where CI currently stays green on things it should catch: dependency deprecation warnings passed silently (so a breaking httpx/pydantic bump would first show up *as* the breakage), a typo'd pytest marker or malformed ini key no-ops instead of failing, and `comfy_sdk` ships `py.typed` while unannotated defs in it were still allowed. `filterwarnings` is scoped to Deprecation/PendingDeprecation rather than a blanket `error` on purpose — the tests' own local HTTP servers emit `ResourceWarning` on teardown, which turns 63 passing tests red without saying anything about the SDK. Also declares `pytest-cov`, which was producing a `.coverage` database locally without being declared anywhere. Verified: suite still 102 passed, mypy clean, and the new override does flag a probe untyped def. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:00:56 +00:00