[PR #38] [MERGED] docs: present per-deployment subdomains as the gateway's URL shape #46

New issue

Closed

opened 2026-10-31 22:01:00 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:01:00 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-python-sdk/pull/38
Author: @sundar-svg
Created: 8/4/2026
Status: ✅ Merged
Merged: 8/4/2026
Merged by: @sundar-svg

Base: main ← Head: sundar-svg/subdomain-url-docs

📝 Commits (1)

b8f53a6 docs: present per-deployment subdomains as the gateway's URL shape

📊 Changes

3 files changed (+144 additions, -16 deletions)

View changed files

📝 tests/integration/test_gateway_e2e.py (+1 -1)
📝 tests/test_follow_up_links.py (+23 -14)
📝 uv.lock (+120 -1)

📄 Description

Description

Comfy Cloud deployments now serve on per-deployment subdomains (https://{dep_id}.run.comfy.app); the path-mounted gateway shape (platformapi.comfy.org/deployment/{id}) is being retired. Docs/tests cleanup only — no client code changes (the SDK is base-URL-agnostic and already works with both shapes):

test_follow_up_links.py: docstring reframed (subdomain is the current gateway shape; origin-resolution stays pinned for any path-carrying base, e.g. a proxy mount), fixture renamed PATH_MOUNTED_BASE with a neutral example host, and a new test_subdomain_links_resolve_against_base covering the modern shape.
test_gateway_e2e.py: the COMFY_BASE_URL example now shows the subdomain form.

How tested

pytest tests/test_follow_up_links.py — 6 passed (5 existing + 1 new).

🤖 Generated with Claude Code

https://claude.ai/code/session_01KV7wUb2hyzKHsR52ZJTvAm

Summary by CodeRabbit

Tests
- Expanded coverage for deployments using subdomains and path-mounted gateway URLs.
- Added validation for correct link origins and internal /jobs and /assets paths.
- Updated authorization and absolute-link test coverage for path-mounted gateways.
Documentation
- Updated the documented COMFY_BASE_URL example to use a deployment-specific serverless gateway URL.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-python-sdk/pull/38 **Author:** [@sundar-svg](https://github.com/sundar-svg) **Created:** 8/4/2026 **Status:** ✅ Merged **Merged:** 8/4/2026 **Merged by:** [@sundar-svg](https://github.com/sundar-svg) **Base:** `main` ← **Head:** `sundar-svg/subdomain-url-docs` --- ### 📝 Commits (1) - [`b8f53a6`](https://github.com/Comfy-Org/comfy-python-sdk/commit/b8f53a623a85dcdcd19b34fe952548579402d811) docs: present per-deployment subdomains as the gateway's URL shape ### 📊 Changes **3 files changed** (+144 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `tests/integration/test_gateway_e2e.py` (+1 -1) 📝 `tests/test_follow_up_links.py` (+23 -14) 📝 `uv.lock` (+120 -1) </details> ### 📄 Description ## Description Comfy Cloud deployments now serve on per-deployment subdomains (`https://{dep_id}.run.comfy.app`); the path-mounted gateway shape (`platformapi.comfy.org/deployment/{id}`) is being retired. Docs/tests cleanup only — no client code changes (the SDK is base-URL-agnostic and already works with both shapes): - `test_follow_up_links.py`: docstring reframed (subdomain is the current gateway shape; origin-resolution stays pinned for any path-carrying base, e.g. a proxy mount), fixture renamed `PATH_MOUNTED_BASE` with a neutral example host, and a new `test_subdomain_links_resolve_against_base` covering the modern shape. - `test_gateway_e2e.py`: the `COMFY_BASE_URL` example now shows the subdomain form. ## How tested `pytest tests/test_follow_up_links.py` — 6 passed (5 existing + 1 new). 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01KV7wUb2hyzKHsR52ZJTvAm  ## Summary by CodeRabbit * **Tests** * Expanded coverage for deployments using subdomains and path-mounted gateway URLs. * Added validation for correct link origins and internal `/jobs` and `/assets` paths. * Updated authorization and absolute-link test coverage for path-mounted gateways. * **Documentation** * Updated the documented `COMFY_BASE_URL` example to use a deployment-specific serverless gateway URL.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:01:00 +00:00