[PR #41] [CLOSED] feat: add asset delete #49

New issue

Closed

opened 2026-10-31 22:01:01 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:01:01 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-python-sdk/pull/41
Author: @jab416171
Created: 8/7/2026
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (3)

3c2b9e2 feat: add asset delete
1317e5f address coderabbit PR comments
7de4ad0 address coderabbit PR comments

📊 Changes

6 files changed (+144 additions, -0 deletions)

View changed files

📝 spec/openapi.yaml (+19 -0)
📝 src/comfy_low/transport.py (+10 -0)
📝 src/comfy_sdk/assets.py (+26 -0)
📝 tests/conftest.py (+22 -0)
📝 tests/test_assets.py (+34 -0)
📝 tests/test_async.py (+33 -0)

📄 Description

Summary by CodeRabbit

New Features
- Added synchronous and asynchronous asset deletion by ID.
- Added deletion support for committed asset instances.
- Asset instances clear their stored ID after successful deletion.
- Uncommitted assets cannot be deleted and raise an error.
Bug Fixes
- API deletion failures now return consistent parsed errors.
Tests
- Added coverage for synchronous and asynchronous deletion scenarios.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-python-sdk/pull/41 **Author:** [@jab416171](https://github.com/jab416171) **Created:** 8/7/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`3c2b9e2`](https://github.com/Comfy-Org/comfy-python-sdk/commit/3c2b9e2e728b5e245dfcb6eda17453953f9c2bc5) feat: add asset delete - [`1317e5f`](https://github.com/Comfy-Org/comfy-python-sdk/commit/1317e5f5a67bba83663f22cb1e6cc486b5c0abef) address coderabbit PR comments - [`7de4ad0`](https://github.com/Comfy-Org/comfy-python-sdk/commit/7de4ad0e2125f36ba7a21c700eaeebf4eb00da9d) address coderabbit PR comments ### 📊 Changes **6 files changed** (+144 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `spec/openapi.yaml` (+19 -0) 📝 `src/comfy_low/transport.py` (+10 -0) 📝 `src/comfy_sdk/assets.py` (+26 -0) 📝 `tests/conftest.py` (+22 -0) 📝 `tests/test_assets.py` (+34 -0) 📝 `tests/test_async.py` (+33 -0) </details> ### 📄 Description  ## Summary by CodeRabbit - **New Features** - Added synchronous and asynchronous asset deletion by ID. - Added deletion support for committed asset instances. - Asset instances clear their stored ID after successful deletion. - Uncommitted assets cannot be deleted and raise an error. - **Bug Fixes** - API deletion failures now return consistent parsed errors. - **Tests** - Added coverage for synchronous and asynchronous deletion scenarios.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:01:01 +00:00