svg tokens, advertise round-trippable encodings #6

New issue

Closed

opened 2026-10-26 22:28:51 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:28:51 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-remote-nodes/pull/8
Author: @Kosinkadink
Created: 5/15/2026
Status: ✅ Merged
Merged: 5/15/2026
Merged by: @Kosinkadink

Base: main ← Head: feat/capability-mirror-sync

📝 Commits (1)

1c8d341 feat(capabilities): mirror missing audio/video/svg tokens, advertise round-trippable encodings

📊 Changes

2 files changed (+10 additions, -0 deletions)

View changed files

📝 client.py (+5 -0)
📝 protocol.py (+5 -0)

📄 Description

Summary

Pre-F1 immediate-follow-up #1 (client side): the client Capability mirror in protocol.py had drifted away from the server's comfy_rnp_protocol/constants.py. The audio sweep that landed AUDIO_MP3_BASE64 / AUDIO_WAV_BASE64 / AUDIO_WAV_INLINE, the video sweep that landed VIDEO_MP4_BASE64, and SVG_XML_BASE64 were never mirrored.

Paired with comfy-rnp-server#13 — server-side capability gates. Both PRs must merge for the gates to be useful end-to-end.

Changes

protocol.py::Capability — adds VIDEO_MP4_BASE64, AUDIO_MP3_BASE64, AUDIO_WAV_BASE64, AUDIO_WAV_INLINE, SVG_XML_BASE64 (byte-equivalent with server constants).
client.py::CLIENT_CAPABILITIES — advertises VIDEO_MP4_BASE64, AUDIO_MP3_INLINE, AUDIO_MP3_BASE64, AUDIO_WAV_BASE64, AUDIO_WAV_INLINE (the client serialization.py already encodes/decodes these). AUDIO_MP3_INLINE was implicitly supported but never advertised; now it is.

SVG_XML_BASE64 lands in the mirror but is not added to CLIENT_CAPABILITIES — there is no SVG envelope decoder in serialization.py yet (Recraft SVG providers currently round-trip via the IO.Custom opaque fallthrough Track §B added; a real decode_svg_envelope is a follow-up).

Lockstep

Client PR: this PR.
Server PR: https://github.com/Comfy-Org/comfy-rnp-server/pull/13.
Both must merge.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-remote-nodes/pull/8 **Author:** [@Kosinkadink](https://github.com/Kosinkadink) **Created:** 5/15/2026 **Status:** ✅ Merged **Merged:** 5/15/2026 **Merged by:** [@Kosinkadink](https://github.com/Kosinkadink) **Base:** `main` ← **Head:** `feat/capability-mirror-sync` --- ### 📝 Commits (1) - [`1c8d341`](https://github.com/Comfy-Org/comfy-remote-nodes/commit/1c8d3419185f2a43d4c0df76dca34ffb8b0f4338) feat(capabilities): mirror missing audio/video/svg tokens, advertise round-trippable encodings ### 📊 Changes **2 files changed** (+10 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `client.py` (+5 -0) 📝 `protocol.py` (+5 -0) </details> ### 📄 Description ## Summary Pre-F1 immediate-follow-up #1 (client side): the client `Capability` mirror in `protocol.py` had drifted away from the server's `comfy_rnp_protocol/constants.py`. The audio sweep that landed `AUDIO_MP3_BASE64` / `AUDIO_WAV_BASE64` / `AUDIO_WAV_INLINE`, the video sweep that landed `VIDEO_MP4_BASE64`, and `SVG_XML_BASE64` were never mirrored. Paired with [comfy-rnp-server#13](https://github.com/Comfy-Org/comfy-rnp-server/pull/13) — server-side capability gates. Both PRs must merge for the gates to be useful end-to-end. ## Changes - `protocol.py::Capability` — adds `VIDEO_MP4_BASE64`, `AUDIO_MP3_BASE64`, `AUDIO_WAV_BASE64`, `AUDIO_WAV_INLINE`, `SVG_XML_BASE64` (byte-equivalent with server constants). - `client.py::CLIENT_CAPABILITIES` — advertises `VIDEO_MP4_BASE64`, `AUDIO_MP3_INLINE`, `AUDIO_MP3_BASE64`, `AUDIO_WAV_BASE64`, `AUDIO_WAV_INLINE` (the client `serialization.py` already encodes/decodes these). `AUDIO_MP3_INLINE` was implicitly supported but never advertised; now it is. `SVG_XML_BASE64` lands in the mirror but is **not** added to `CLIENT_CAPABILITIES` — there is no SVG envelope decoder in `serialization.py` yet (Recraft SVG providers currently round-trip via the `IO.Custom` opaque fallthrough Track §B added; a real `decode_svg_envelope` is a follow-up). ## Lockstep - Client PR: this PR. - Server PR: https://github.com/Comfy-Org/comfy-rnp-server/pull/13. - Both must merge. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:28:51 +00:00